From 2e44767fc2e202da87f51d4c25b83791cdf40e03 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Thu, 28 Nov 2013 13:30:23 +1100 Subject: [PATCH] Incremental: remove test that can never succeed. Incremental_container never returns 1, so this test is pointless. It is a holdover from when we called "Incremental()" rather than "Incremental_container()" at this point. Signed-off-by: NeilBrown --- Incremental.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Incremental.c b/Incremental.c index 1bb3638f..68080957 100644 --- a/Incremental.c +++ b/Incremental.c @@ -480,11 +480,6 @@ int Incremental(char *devname, struct context *c, if (!rv) rv = Incremental_container(st, chosen_name, c, NULL); map_unlock(&map); - if (rv == 1) - /* Don't fail the whole -I if a subarray didn't - * have enough devices to start yet - */ - rv = 0; /* after spare is added, ping monitor for external metadata * so that it can eg. try to rebuild degraded array */ if (st->ss->external) -- 2.39.2