From 733eedc8f21dfe09349430d01bbfc38cf4d67ff2 Mon Sep 17 00:00:00 2001 From: NeilBrown Date: Wed, 21 May 2014 13:00:08 +1000 Subject: [PATCH] DDF: remove an old incorrect FIXME comment. We mustn't close fds in write_init_super if ->update_tail was set. Signed-off-by: NeilBrown --- super-ddf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/super-ddf.c b/super-ddf.c index 943b51aa..d3234c5b 100644 --- a/super-ddf.c +++ b/super-ddf.c @@ -3259,13 +3259,15 @@ static int write_init_super_ddf(struct supertype *st) len); append_metadata_update(st, vc, tlen); - /* FIXME I need to close the fds! */ return 0; } else { struct dl *d; if (!currentconf) for (d = ddf->dlist; d; d=d->next) while (Kill(d->devname, NULL, 0, -1, 1) == 0); + /* Note: we don't close the fd's now, but a subsequent + * ->free_super() will + */ return __write_init_super_ddf(st); } } -- 2.39.2