]> git.ipfire.org Git - thirdparty/openssl.git/commit
Call ENGINE_init() before trying to use keys from engine
authorDavid Woodhouse <David.Woodhouse@intel.com>
Wed, 28 Sep 2016 13:31:22 +0000 (14:31 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Wed, 28 Sep 2016 13:34:20 +0000 (14:34 +0100)
commit4badd2b3c29c2c6c551c737c07a429a53d9d1a0d
tree55890f54d9828ba22b4bbf71af201faefe6d6ad7
parent9702bf5fa269eea8eb3d8bad13cc11fc58fb7e8e
Call ENGINE_init() before trying to use keys from engine

Things like 'openssl s_client' only ever worked with keys from an engine
which provided a default generic method for some key type — because it
called ENGINE_set_default() and that ended up being an implicit
initialisation and functional refcount.

But an engine which doesn't provide generic methods doesn't get
initialised, and then when you try to use it you get an error:

cannot load client certificate private key file from engine
140688147056384:error:26096075:engine routines:ENGINE_load_private_key:not initialised:crypto/engine/eng_pkey.c:66:
unable to load client certificate private key file

cf. https://github.com/OpenSC/libp11/issues/107 (in which we discover
that engine_pkcs11 *used* to provide generic methods that OpenSSL would
try to use for ephemeral DH keys when negotiating ECDHE cipher suites in
TLS, and that didn't work out very well.)

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/1640)
apps/apps.c