]> git.ipfire.org Git - thirdparty/openssl.git/commit
[test] computing ECC cofactors: regression test
authorBilly Brumley <bbrumley@gmail.com>
Fri, 6 Sep 2019 14:26:08 +0000 (17:26 +0300)
committerNicola Tuveri <nic.tuv@gmail.com>
Sat, 7 Sep 2019 12:37:13 +0000 (15:37 +0300)
commit5041ea38c96c9c8d7fc207a7fd25969f167f0f76
tree8ee55d371bda546435fccce8f81b0c8a88385e23
parente97bab6929bbbc5b8364b25ca2ef4fcb02dd6e2a
[test] computing ECC cofactors: regression test

This is a forward port from
    https://github.com/openssl/openssl/pull/9781
for the test logic introduced by
    https://github.com/openssl/openssl/pull/9727

As @mattcaswell commented
(https://github.com/openssl/openssl/pull/9781#discussion_r321621541):

> These `TEST_true` calls should be `!TEST_false` because we are
> *expecting* a failure.
> The difference is that the test framework will print error details if
> the test doesn't give the expected answer.
> So by using `TEST_true` instead of `!TEST_false` we'll get error
> details printed, but the test will succeed anyway.

(cherry picked from commit e8aafc891d9bd7fa1cce0401d858ef842f09b49e)

Reviewed-by: Nicola Tuveri <nic.tuv@gmail.com>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/9797)
test/ectest.c