]> git.ipfire.org Git - thirdparty/openssl.git/commit
Adding Test.pm with workaround for Perl abs2rel bug
authorMartin Peylo <martin.peylo@nokia.com>
Wed, 22 Aug 2018 09:48:22 +0000 (12:48 +0300)
committerRichard Levitte <levitte@openssl.org>
Tue, 2 Jul 2019 18:10:57 +0000 (20:10 +0200)
commit7a2027240e1d01f7f5b209998d1de36af221b34b
tree4b1432bca3f39bb1dd539d97cdebfc3da86b735e
parentbd01733fdd9a5a0acdc72cf5c6601d37e8ddd801
Adding Test.pm with workaround for Perl abs2rel bug

If SRCTOP != BLDTOP, and SRCTOP is given in relative form, e.g.
"./config ../openssl", then a bug in Perl's abs2rel may trigger that directory-
rewriting in __cwd results in wrong entries in %directories under certain
circumstances, e.g. when a test executes run(app(["openssl"]) after indir.

There should not be any need to go to a higher directory from BLDDIR or SRCDIR,
so it should be OK to use them in their absolute form, also resolving all
possible symlinks, right from the start.

Following the File::Spec::Functions bug description (reported to perl.org):

When abs2rel gets a path argument with ..s that are crossing over the ..s
trailing the base argument, the result is wrong.

Example
PATH: /home/goal/test/..
BASE: /home/goal/test/../../base
Good result: ../goal
Bad  result: ../..

Bug verified with File::Spec versions
- 3.6301
- 3.74 (latest)

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7031)
util/perl/OpenSSL/Test.pm