]> git.ipfire.org Git - thirdparty/openssl.git/commit
Appease -Werror=stringop-overflow=
authorPatrick Steuer <patrick.steuer@de.ibm.com>
Tue, 11 Aug 2020 11:51:04 +0000 (13:51 +0200)
committerPatrick Steuer <patrick.steuer@de.ibm.com>
Thu, 13 Aug 2020 19:32:29 +0000 (21:32 +0200)
commitc19e6da9a345b1e14caca23c50a0c7690309e0e4
tree7aeb877117e3b0ae8419f62b097f6ef50fd03f9b
parentcddbcf0d2887388d95d5b338b249ac3923be00f1
Appease -Werror=stringop-overflow=

gcc 10 seems to think of assigning to an (unsigned) char
array as a stringop and demands additional space for a
terminating '\0':

In function 'ssl3_generate_key_block',
    inlined from 'ssl3_setup_key_block' at ssl/s3_enc.c:304:11:
ssl/s3_enc.c:51:20: error: writing 1 byte into a region of size 0
[-Werror=stringop-overflow=]
   51 |             buf[j] = c;
      |             ~~~~~~~^~~
ssl/s3_enc.c: In function 'ssl3_setup_key_block':
ssl/s3_enc.c:23:19: note: at offset 16 to object 'buf' with size 16
declared here
   23 |     unsigned char buf[16], smd[SHA_DIGEST_LENGTH];
      |                   ^~~

Signed-off-by: Patrick Steuer <patrick.steuer@de.ibm.com>
Reviewed-by: Tomas Mraz <tmraz@fedoraproject.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/12632)
ssl/s3_enc.c