From: Matt Caswell Date: Tue, 11 Jun 2019 12:27:45 +0000 (+0100) Subject: Move a fall through comment X-Git-Tag: openssl-3.0.0-alpha1~1965 X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fopenssl.git;a=commitdiff_plain;h=a2e520447e17a58b52cdf41ab1218b020f44e4a6 Move a fall through comment When compiling with --strict-warnings using gcc 7.4.0 the compiler complains that a case falls through, even though there is an explicit comment stating this. Moving the comment outside of the conditional compilation section resolves this. Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/9131) --- diff --git a/crypto/bio/b_addr.c b/crypto/bio/b_addr.c index 261d439f63..d7fcf2fcb5 100644 --- a/crypto/bio/b_addr.c +++ b/crypto/bio/b_addr.c @@ -718,8 +718,8 @@ int BIO_lookup_ex(const char *host, const char *service, int lookup_type, hints.ai_flags &= ~AI_ADDRCONFIG; goto retry; } - /* fall through */ # endif + /* fall through */ default: BIOerr(BIO_F_BIO_LOOKUP_EX, ERR_R_SYS_LIB); ERR_add_error_data(1, gai_strerror(gai_ret));