]> git.ipfire.org Git - thirdparty/openvpn.git/commit
phase2_tcp_server: fix Coverity issue 'Dereference after null check'
authorFrank Lichtenheld <frank@lichtenheld.com>
Mon, 25 Mar 2024 07:14:48 +0000 (08:14 +0100)
committerGert Doering <gert@greenie.muc.de>
Mon, 25 Mar 2024 16:53:34 +0000 (17:53 +0100)
commite8c629fe64c67ea0a8454753be99db44df7ce53e
tree849592cb977864079cf014e09d940080d3663540
parent6a60d1bef424088df55f4d07efd45ce080fc7132
phase2_tcp_server: fix Coverity issue 'Dereference after null check'

As Coverity says:
Either the check against null is unnecessary, or there may be a null
pointer dereference.
In phase2_tcp_server: Pointer is checked against null but then
dereferenced anyway

There is only one caller (link_socket_init_phase2) and it already has
an ASSERT(sig_info). So use that here was well.

v2:
 - fix cleanly by actually asserting that sig_info is defined

Change-Id: I8ef199463d46303129a3f563fd9eace780a58b8a
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Arne Schwabe <arne-openvpn@rfc2549.org>
Message-Id: <20240325071448.12143-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg28452.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/socket.c