From 3b203c83768f2b2f8b610ef2b362d45ec451dedd Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 8 Aug 2019 11:06:20 +0200 Subject: [PATCH] dnsdist: Increase the default value of setMaxUDPOutstanding to 65535 --- pdns/dnsdist.cc | 2 +- pdns/dnsdistdist/docs/advanced/tuning.rst | 2 +- pdns/dnsdistdist/docs/reference/tuning.rst | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/pdns/dnsdist.cc b/pdns/dnsdist.cc index 46ad4dfa39..e9ca2aff0d 100644 --- a/pdns/dnsdist.cc +++ b/pdns/dnsdist.cc @@ -83,7 +83,7 @@ bool g_verbose; struct DNSDistStats g_stats; MetricDefinitionStorage g_metricDefinitions; -uint16_t g_maxOutstanding{10240}; +uint16_t g_maxOutstanding{std::numeric_limits::max()}; bool g_verboseHealthChecks{false}; uint32_t g_staleCacheEntriesTTL{0}; bool g_syslog{true}; diff --git a/pdns/dnsdistdist/docs/advanced/tuning.rst b/pdns/dnsdistdist/docs/advanced/tuning.rst index cf72ca7c51..4fbbd171b7 100644 --- a/pdns/dnsdistdist/docs/advanced/tuning.rst +++ b/pdns/dnsdistdist/docs/advanced/tuning.rst @@ -25,7 +25,7 @@ This might cause issues if some connections are taking a very long time, since i The experimental :func:`setTCPUseSinglePipe` directive can be used so that all the incoming TCP connections are put into a single queue and handled by the first TCP worker available. When dispatching UDP queries to backend servers, dnsdist keeps track of at most **n** outstanding queries for each backend. -This number **n** can be tuned by the :func:`setMaxUDPOutstanding` directive, defaulting to 10240, with a maximum value of 65535. +This number **n** can be tuned by the :func:`setMaxUDPOutstanding` directive, defaulting to 10240 (65535 since 1.4.0), with a maximum value of 65535. Large installations are advised to increase the default value at the cost of a slightly increased memory usage. Most of the query processing is done in C++ for maximum performance, but some operations are executed in Lua for maximum flexibility: diff --git a/pdns/dnsdistdist/docs/reference/tuning.rst b/pdns/dnsdistdist/docs/reference/tuning.rst index 0f63a51454..b1dd58c5d6 100644 --- a/pdns/dnsdistdist/docs/reference/tuning.rst +++ b/pdns/dnsdistdist/docs/reference/tuning.rst @@ -32,8 +32,10 @@ Tuning related functions :param int num: .. function:: setMaxUDPOutstanding(num) + .. versionchanged:: 1.4.0 + Before 1.4.0 the default value was 10240 - Set the maximum number of outstanding UDP queries to a given backend server. This can only be set at configuration time and defaults to 10240 + Set the maximum number of outstanding UDP queries to a given backend server. This can only be set at configuration time and defaults to 65535 (10240 before 1.4.0) :param int num: -- 2.39.2