From aa93edd57665c282872855d8973dce8f37346e7d Mon Sep 17 00:00:00 2001
From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Thu, 30 Apr 2020 10:30:22 +0200
Subject: [PATCH] auth: Fix 'loop variable [...] creates a copy' warnings

Reported by clang++ 10.
---
 pdns/dnsbackend.cc        | 2 +-
 pdns/pdnsutil.cc          | 8 ++++----
 pdns/receiver.cc          | 2 +-
 pdns/slavecommunicator.cc | 2 +-
 pdns/test-signers.cc      | 2 +-
 pdns/ws-auth.cc           | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/pdns/dnsbackend.cc b/pdns/dnsbackend.cc
index 07fe9c6d42..5869df3be1 100644
--- a/pdns/dnsbackend.cc
+++ b/pdns/dnsbackend.cc
@@ -139,7 +139,7 @@ void BackendMakerClass::launch(const string &instr)
   vector<string> parts;
   stringtok(parts,instr,", ");
 
-  for (const auto part : parts)
+  for (const auto& part : parts)
     if (count(parts.begin(), parts.end(), part) > 1)
       throw ArgException("Refusing to launch multiple backends with the same name '" + part + "', verify all 'launch' statements in your configuration");
 
diff --git a/pdns/pdnsutil.cc b/pdns/pdnsutil.cc
index 406f5b074d..fd5bcccfe9 100644
--- a/pdns/pdnsutil.cc
+++ b/pdns/pdnsutil.cc
@@ -782,7 +782,7 @@ static int listKeys(const string &zname, DNSSECKeeper& dk){
     vector<DomainInfo> domainInfo;
     B.getAllDomains(&domainInfo);
     bool printHeader = true;
-    for (auto const di : domainInfo) {
+    for (const auto& di : domainInfo) {
       listKey(di, dk, printHeader);
       printHeader = false;
     }
@@ -1595,7 +1595,7 @@ static bool showZone(DNSSECKeeper& dk, const DNSName& zone, bool exportDS = fals
       cout<<endl;
 
       for(const auto& m : metamap) {
-        for(const auto i : m.second)
+        for(const auto& i : m.second)
           cout << '\t' << m.first<<'\t' << i <<endl;
       }
     }
@@ -2133,7 +2133,7 @@ try
     cout<<"DNSKEY algorithms supported by this installation of PowerDNS:"<<endl;
 
     auto algosWithBackend = DNSCryptoKeyEngine::listAllAlgosWithBackend();
-    for (auto const algoWithBackend : algosWithBackend){
+    for (const auto& algoWithBackend : algosWithBackend){
       string algoName = DNSSECKeeper::algorithm2name(algoWithBackend.first);
       cout<<std::to_string(algoWithBackend.first)<<" - "<<algoName;
       if (cmds.size() == 2 && cmds[1] == "with-backend")
@@ -3089,7 +3089,7 @@ try
     if (cmds.size() > 2) {
       keys.assign(cmds.begin() + 2, cmds.end());
       std::cout << "Metadata for '" << zone << "'" << endl;
-      for(const string kind :  keys) {
+      for(const auto& kind :  keys) {
         vector<string> meta;
         meta.clear();
         if (B.getDomainMetadata(zone, kind, meta)) {
diff --git a/pdns/receiver.cc b/pdns/receiver.cc
index 3e908d3209..da65e8bf25 100644
--- a/pdns/receiver.cc
+++ b/pdns/receiver.cc
@@ -494,7 +494,7 @@ int main(int argc, char **argv)
       }
       cerr<<" (";
       bool first = true;
-      for (auto const c : ::arg().getCommands()) {
+      for (const auto& c : ::arg().getCommands()) {
         if (!first) {
           cerr<<", ";
         }
diff --git a/pdns/slavecommunicator.cc b/pdns/slavecommunicator.cc
index 0638c51e1c..4b0ade2113 100644
--- a/pdns/slavecommunicator.cc
+++ b/pdns/slavecommunicator.cc
@@ -135,7 +135,7 @@ void CommunicatorClass::ixfrSuck(const DNSName &domain, const TSIGTriplet& tt, c
         grouped[{x.d_name, x.d_type}].second.push_back(x);
 
       di.backend->startTransaction(domain, -1);
-      for(const auto g : grouped) {
+      for(const auto& g : grouped) {
         vector<DNSRecord> rrset;
         {
           DNSZoneRecord zrr;
diff --git a/pdns/test-signers.cc b/pdns/test-signers.cc
index da21db062a..135dbf665a 100644
--- a/pdns/test-signers.cc
+++ b/pdns/test-signers.cc
@@ -161,7 +161,7 @@ static void checkRR(const signerParams& signer)
 
 BOOST_AUTO_TEST_CASE(test_generic_signers)
 {
-  for (const auto signer : signers) {
+  for (const auto& signer : signers) {
     DNSKEYRecordContent drc;
     auto dcke = DNSCryptoKeyEngine::makeFromISCString(drc, signer.iscMap);
 
diff --git a/pdns/ws-auth.cc b/pdns/ws-auth.cc
index 1d081e3a09..f8a3280e64 100644
--- a/pdns/ws-auth.cc
+++ b/pdns/ws-auth.cc
@@ -2184,7 +2184,7 @@ static void apiServerSearchData(HttpRequest* req, HttpResponse* resp) {
 
   B.getAllDomains(&domains, true);
 
-  for(const DomainInfo di: domains)
+  for(const DomainInfo& di: domains)
   {
     if ((objectType == ObjectType::ALL || objectType == ObjectType::ZONE) && ents < maxEnts && sm.match(di.zone)) {
       doc.push_back(Json::object {
-- 
2.39.2