]> git.ipfire.org Git - thirdparty/qemu.git/commit - block.c
block: Add status callback to bdrv_amend_options()
authorMax Reitz <mreitz@redhat.com>
Mon, 27 Oct 2014 10:12:50 +0000 (11:12 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 3 Nov 2014 11:41:48 +0000 (11:41 +0000)
commit77485434206bbbfbb7f6a446866f6a327b062d5e
treed899b92276dd04c297aad774d923ae61e0691fb4
parent9ea92c210675b0d2b0ff3ccd2f7a360d1f6c5129
block: Add status callback to bdrv_amend_options()

Depending on the changed options and the image format,
bdrv_amend_options() may take a significant amount of time. In these
cases, a way to be informed about the operation's status is desirable.

Since the operation is rather complex and may fundamentally change the
image, implementing it as AIO or a coroutine does not seem feasible. On
the other hand, implementing it as a block job would be significantly
more difficult than a simple callback and would not add benefits other
than progress report to the amending operation, because it should not
actually be run as a block job at all.

A callback may not be very pretty, but it's very easy to implement and
perfectly fits its purpose here.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: BenoƮt Canet <benoit.canet@nodalink.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1414404776-4919-2-git-send-email-mreitz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
block.c
block/qcow2.c
include/block/block.h
include/block/block_int.h
qemu-img.c