]> git.ipfire.org Git - thirdparty/qemu.git/commit
virtfs: error out gracefully when mandatory suboptions are missing
authorGreg Kurz <groug@kaod.org>
Mon, 4 Sep 2017 07:59:01 +0000 (09:59 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 12 Sep 2017 16:25:01 +0000 (11:25 -0500)
commit168ff32c5d1e05d7e11db28d6bcc257783ba849a
treecd3a89760cfb9ee0cad56190dea31ba8227b1470
parent728bfa3273ebaaab51bb41467a20790c7e5f5268
virtfs: error out gracefully when mandatory suboptions are missing

We internally convert -virtfs to -fsdev/-device. If the user doesn't
provide the path or security_model suboptions, and the fsdev backend
requires them, we hit an assertion when populating the internal -fsdev
option:

util/qemu-option.c:547: opt_set: Assertion `opt->str' failed.
Aborted (core dumped)

Let's test the suboption presence on the command line before trying
to set it in the internal -fsdev option, and let the backend code
error out gracefully (ie, like it already does when the user passes
-fsdev on the command line).

Reported-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
(cherry picked from commit 32b6943699948f7adc35ada233fbd25daffad5e9)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
vl.c