]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ppc: Take QEMU lock when calling ppc_dcr_read/write()
authorPeter Maydell <peter.maydell@linaro.org>
Sun, 22 Mar 2020 19:22:58 +0000 (19:22 +0000)
committerDavid Gibson <david@gibson.dropbear.id.au>
Tue, 24 Mar 2020 00:56:37 +0000 (11:56 +1100)
commit235352ee6e73d7716d20e706d484fd45c232ec09
tree6e01bce45ae899e50252816c76267dd3b07d2c35
parentce05fa0fcc9e23d16b2ff079cb3cb6aceaccbc28
hw/ppc: Take QEMU lock when calling ppc_dcr_read/write()

The ppc_dcr_read() and ppc_dcr_write() functions call into callbacks
in device code, so we need to hold the QEMU iothread lock while
calling them.  This is the case already for the callsites in
kvmppc_handle_dcr_read/write(), but we must also take the lock when
calling the helpers from TCG.

This fixes a bug where attempting to initialise the PPC405EP
SDRAM will cause an assertion when sdram_map_bcr() attempts
to remap memory regions.

Reported-by: Amit Lazar <abasarlaz@hotmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20200322192258.14039-1-peter.maydell@linaro.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
target/ppc/timebase_helper.c