]> git.ipfire.org Git - thirdparty/qemu.git/commit
thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 19 Mar 2020 19:33:20 +0000 (19:33 +0000)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 14 Apr 2020 08:44:31 +0000 (09:44 +0100)
commit2e7980244585a5be6f2c1b4e14c19d7932ee2fcb
tree9b0fb86ba711d8c9b510ed631fcb310ab742223b
parent062c73c51e19da0703d7505f9497a70e5398cf89
thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc

All the Coverity-specific definitions of qemu_mutex_lock() and friends
have a trailing semicolon. This works fine almost everywhere because
of QEMU's mandatory-braces coding style and because most callsites are
simple, but target/s390x/sigp.c has a use of qemu_mutex_trylock() as
an if() statement, which makes the ';' a syntax error:
"../target/s390x/sigp.c", line 461: warning #18: expected a ")"
      if (qemu_mutex_trylock(&qemu_sigp_mutex)) {
          ^

Remove the bogus semicolons from the macro definitions.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20200319193323.2038-4-peter.maydell@linaro.org
include/qemu/thread.h