]> git.ipfire.org Git - thirdparty/qemu.git/commit
qapi: Drop qapi_event_send_FOO()'s Error ** argument
authorPeter Xu <peterx@redhat.com>
Wed, 15 Aug 2018 13:37:37 +0000 (21:37 +0800)
committerMarkus Armbruster <armbru@redhat.com>
Tue, 28 Aug 2018 16:21:38 +0000 (18:21 +0200)
commit3ab72385b21d8d66df3f5fea42097ce264dc9d6b
tree47e25323bfe6a14e3cd5bdf66cdc6b94dbfa9533
parentbdd2d42b890b3a908fa3fbdc9661541e1b57eb15
qapi: Drop qapi_event_send_FOO()'s Error ** argument

The generated qapi_event_send_FOO() take an Error ** argument.  They
can't actually fail, because all they do with the argument is passing it
to functions that can't fail: the QObject output visitor, and the
@qmp_emit callback, which is either monitor_qapi_event_queue() or
event_test_emit().

Drop the argument, and pass &error_abort to the QObject output visitor
and @qmp_emit instead.

Suggested-by: Eric Blake <eblake@redhat.com>
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180815133747.25032-4-peterx@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message rewritten, update to qapi-code-gen.txt corrected]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
29 files changed:
block/block-backend.c
block/qcow2.c
block/quorum.c
block/write-threshold.c
blockjob.c
cpus.c
docs/devel/qapi-code-gen.txt
dump.c
hw/acpi/core.c
hw/acpi/cpu.c
hw/acpi/memory_hotplug.c
hw/char/virtio-console.c
hw/core/qdev.c
hw/net/virtio-net.c
hw/ppc/spapr_rtc.c
hw/timer/mc146818rtc.c
hw/virtio/virtio-balloon.c
hw/watchdog/watchdog.c
include/qapi/qmp-event.h
job.c
migration/migration.c
migration/ram.c
monitor.c
scripts/qapi/events.py
scsi/pr-manager-helper.c
tests/test-qmp-event.c
ui/spice-core.c
ui/vnc.c
vl.c