]> git.ipfire.org Git - thirdparty/qemu.git/commit
net/virtio: Drop useless n->primary_dev not null checks
authorMarkus Armbruster <armbru@redhat.com>
Sat, 30 Nov 2019 19:42:20 +0000 (20:42 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 2 Dec 2019 15:14:33 +0000 (16:14 +0100)
commit4dbac1aed2ca7e68e9384b0e49750d54d4cbd43d
tree654a02603532782bf2b2204c6bf09a8c6245ddae
parentfb2246882a2c8d7f084ebe0617e97ac78467d156
net/virtio: Drop useless n->primary_dev not null checks

virtio_net_handle_migration_primary() returns early when it can't
ensure n->primary_dev is non-null.  Checking it again right after that
early return is redundant.  Drop.

If n->primary_dev is null on entering failover_replug_primary(), @pdev
will become null, and pdev->partially_hotplugged will crash.  Checking
n->primary_dev later is useless.  It can't actually be null, because
its caller virtio_net_handle_migration_primary() ensures it isn't.
Drop the useless check.

Cc: Jens Freimann <jfreimann@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20191130194240.10517-2-armbru@redhat.com>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
hw/net/virtio-net.c