]> git.ipfire.org Git - thirdparty/qemu.git/commit
scsi: fix cancellation when I/O was completed but DMA was not.
authorPaolo Bonzini <pbonzini@redhat.com>
Mon, 12 Jan 2015 10:47:30 +0000 (11:47 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 23 Feb 2015 00:12:51 +0000 (18:12 -0600)
commitb0a231a9a9ab7cca0ad24b8c2eb2249e17727fdb
treec9a9fe48dccb9cfca67c4e3652b099ee5829bcdb
parent09e2753be0e7841ae0045a87ee974e47ba10befd
scsi: fix cancellation when I/O was completed but DMA was not.

Commit d577646 (scsi: Introduce scsi_req_cancel_complete, 2014-09-25)
was supposed to have no semantic change, but it missed a case.  When
r->aiocb has already been NULLed, but DMA was not complete and the
SCSI layer was waiting for scsi_req_continue, after the patch the
SCSI layer will not call the .cancel callback of SCSIBusInfo.

Fixes: d5776465ee9a55815792efa34d79de240f4ffd99
Cc: qemu-stable@nongnu.org
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Tested-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 488eef2f1d16c97cf7f9ebf644ecafa1ea1e9acc)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/scsi/scsi-bus.c