]> git.ipfire.org Git - thirdparty/qemu.git/commit
linux-user: fix "may be used uninitialized" warnings
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Tue, 5 Mar 2019 15:15:00 +0000 (16:15 +0100)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 7 Mar 2019 09:57:29 +0000 (10:57 +0100)
commitb78c522ab949582b5e580e15d6ebf979845ccc94
tree8c3d5405ef83ce10bad312b7e7b8e8219aa6bde6
parentba584f1de30e58b0d93cd81bd437271b894eefbf
linux-user: fix "may be used uninitialized" warnings

Fixes:

/home/elmarco/src/qemu/linux-user/syscall.c: In function ‘do_ioctl_rt’:
/home/elmarco/src/qemu/linux-user/syscall.c:4773:9: error: ‘host_rt_dev_ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
     if (*host_rt_dev_ptr != 0) {
         ^~~~~~~~~~~~~~~~
/home/elmarco/src/qemu/linux-user/syscall.c:4774:9: error: ‘target_rt_dev_ptr’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
         unlock_user((void *)*host_rt_dev_ptr,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                     *target_rt_dev_ptr, 0);
                     ~~~~~~~~~~~~~~~~~~~~~~

Based on previous discussion from patch "linux-users/syscall: make
do_ioctl_rt safer" by Alex Bennée.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20190305151500.25038-1-marcandre.lureau@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
linux-user/syscall.c