]> git.ipfire.org Git - thirdparty/qemu.git/commit
qcow2: Avoid feature name extension on small cluster size
authorEric Blake <eblake@redhat.com>
Tue, 24 Mar 2020 17:42:32 +0000 (12:42 -0500)
committerMax Reitz <mreitz@redhat.com>
Thu, 26 Mar 2020 13:44:33 +0000 (14:44 +0100)
commite7be13ad3ff593608a118bfb69553037bd221563
treedc2b8da191a1c4ee29500d769ec7ee773603c5b6
parentbb40ebce2cb0bd4bf37968074d43d5a864fb6dee
qcow2: Avoid feature name extension on small cluster size

As the feature name table can be quite large (over 9k if all 64 bits
of all three feature fields have names; a mere 8 features leaves only
8 bytes for a backing file name in a 512-byte cluster), it is unwise
to emit this optional header in images with small cluster sizes.

Update iotest 036 to skip running on small cluster sizes; meanwhile,
note that iotest 061 never passed on alternative cluster sizes
(however, I limited this patch to tests with output affected by adding
feature names, rather than auditing for other tests that are not
robust to alternative cluster sizes).

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-Id: <20200324174233.1622067-4-eblake@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
block/qcow2.c
tests/qemu-iotests/036
tests/qemu-iotests/061