]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/rdma: avoid suspicious strncpy() use
authorStefan Hajnoczi <stefanha@redhat.com>
Mon, 16 Mar 2020 16:07:02 +0000 (16:07 +0000)
committerMarcel Apfelbaum <marcel.apfelbaum@gmail.com>
Sat, 21 Mar 2020 17:21:20 +0000 (19:21 +0200)
commitf93cfdc583d4c26b2a878642adf574e11909863c
tree86fc7514ad6c0ee4e016d2a48f6b0e24cab154f1
parentb196d4f1d62dc0976fd3999ff753f94944fcb657
hw/rdma: avoid suspicious strncpy() use

gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled
reports the following error:

  CC      x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ring.o
In file included from /usr/include/string.h:495,
                 from include/qemu/osdep.h:101,
                 from hw/rdma/vmw/pvrdma_dev_ring.c:16:
In function ‘strncpy’,
    inlined from ‘pvrdma_ring_init’ at hw/rdma/vmw/pvrdma_dev_ring.c:33:5:
/usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Werror=stringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Use pstrcpy() instead of strncpy().  It is guaranteed to NUL-terminate
strings.

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Yuval Shaia <yuval.shaia.ml.gmail.com>
Message-Id: <20200316160702.478964-3-stefanha@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
hw/rdma/vmw/pvrdma_dev_ring.c