]> git.ipfire.org Git - thirdparty/qemu.git/commit
osdep: Change default value of qemu_hw_version() to "2.5+"
authorEduardo Habkost <ehabkost@redhat.com>
Thu, 12 Nov 2015 17:29:54 +0000 (15:29 -0200)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 25 Nov 2015 11:42:37 +0000 (13:42 +0200)
commitfac862ffa605f6fa41f52033b27346d26a96bea5
tree3621d13c24bc340449eb2ab7f071961afbb766b3
parent541abd10a01da56c5f16582cd32d67114ec22a5c
osdep: Change default value of qemu_hw_version() to "2.5+"

There are two issues with qemu_hw_version() today:

1) If a machine has hw_version set, the value returned by it is
   not very useful, because it is not the actual QEMU version.
2) If a machine does't set hw_version, the return value of
   qemu_hw_version() is broken, because it will change when
   upgrading QEMU.

For those reasons, using qemu_hw_version() is strongly
discouraged, and should be used only in code that used
QEMU_VERSION in the past and needs to keep compatibility.

To fix (2), instead of making every machine broken by default
unless they set hw_version, make qemu_hw_version() simply return
"2.5+" if qemu_set_hw_version() is not called.

Suggested-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
include/hw/boards.h
include/qemu/osdep.h
util/osdep.c