]> git.ipfire.org Git - thirdparty/qemu.git/commit
aio-posix: fix io_uring with external events
authorStefan Hajnoczi <stefanha@redhat.com>
Thu, 19 Mar 2020 16:35:59 +0000 (16:35 +0000)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 23 Mar 2020 11:05:44 +0000 (11:05 +0000)
commitff807d559205a434fd37d3343f01a0ab128bd190
tree6a914a7b42b68bb6b2e2fb2978926da9cc18e8b1
parent29e0855c5af62bbb0b0b6fed792e004dad92ba95
aio-posix: fix io_uring with external events

When external event sources are disabled fdmon-io_uring falls back to
fdmon-poll.  The ->need_wait() callback needs to watch for this so it
can return true when external event sources are disabled.

It is also necessary to call ->wait() when AioHandlers have changed
because io_uring is asynchronous and we must submit new sqes.

Both of these changes to ->need_wait() together fix tests/test-aio -p
/aio/external-client, which failed with:

  test-aio: tests/test-aio.c:404: test_aio_external_client: Assertion `aio_poll(ctx, false)' failed.

Reported-by: Julia Suvorova <jusual@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Message-id: 20200319163559.117903-1-stefanha@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
util/fdmon-io_uring.c