From: Anthony PERARD <anthony.perard@citrix.com>
Date: Mon, 6 Apr 2020 16:42:07 +0000 (+0100)
Subject: xen-block: Fix uninitialized variable
X-Git-Tag: v5.0.0-rc2~2^2~1
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fqemu.git;a=commitdiff_plain;h=0cd40042c53a78057f4811379207ad9f141af703

xen-block: Fix uninitialized variable

Since 7f5d9b206d1e ("object-add: don't create return value if
failed"), qmp_object_add() don't write any value in 'ret_data', thus
has random data. Then qobject_unref() fails and abort().

Fix by initialising 'ret_data' properly.

Fixes: 5f07c4d60d09 ("qapi: Flatten object-add")
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200406164207.1446817-1-anthony.perard@citrix.com>
---

diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 07bb32e22b5..99cb4c67cb0 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -860,7 +860,7 @@ static XenBlockIOThread *xen_block_iothread_create(const char *id,
     XenBlockIOThread *iothread = g_new(XenBlockIOThread, 1);
     Error *local_err = NULL;
     QDict *opts;
-    QObject *ret_data;
+    QObject *ret_data = NULL;
 
     iothread->id = g_strdup(id);