]> git.ipfire.org Git - thirdparty/qemu.git/commit
s390x/ipl: Fix boot if no bootindex was specified
authorChristian Borntraeger <borntraeger@de.ibm.com>
Thu, 18 Jun 2015 14:37:39 +0000 (16:37 +0200)
committerCornelia Huck <cornelia.huck@de.ibm.com>
Thu, 2 Jul 2015 13:35:33 +0000 (15:35 +0200)
commit6efd2c2a125b4369b8def585b0dac35c849b5eb3
treeb54d5f06a99697d8cc3ddf2aedffe87ffa2511ca
parent213941d73baf8ba7ec5381c8402fed7925d613d4
s390x/ipl: Fix boot if no bootindex was specified

commit fa92e218df1d ("s390x/ipl: avoid sign extension") introduced
a regression:

qemu-system-s390x -drive file=image.qcow,format=qcow2
does not boot, the bios states
"No virtio-blk device found!"

adding bootindex=1 does boot.

The reason is that the uint32_t as return value will not do the right
thing for the return -1 (default without bootindex).
The bios itself, will interpret a 64bit -1 as autodetect (but it will
interpret 32bit -1 as ccw device address ff.ff.ffff)

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-stable@nongnu.org # v2.3.0
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
hw/s390x/ipl.c