]> git.ipfire.org Git - thirdparty/qemu.git/commit
s390x/kvm: Set default cpu model for all machine classes
authorDavid Hildenbrand <david@redhat.com>
Mon, 21 Oct 2019 10:05:15 +0000 (12:05 +0200)
committerCornelia Huck <cohuck@redhat.com>
Mon, 21 Oct 2019 16:03:08 +0000 (18:03 +0200)
commitde60a92ea7b7977854420c58fd98f38cb6de6de6
treef01cd32a13c64cb93570a8a4b40dc3307a760832
parent38ad4fa3de4a0e747940711f16028fc509a4a6b6
s390x/kvm: Set default cpu model for all machine classes

We have to set the default model of all machine classes, not just for
the active one. Otherwise, "query-machines" will indicate the wrong
CPU model ("qemu-s390x-cpu" instead of "host-s390x-cpu") as
"default-cpu-type".

Doing a
    {"execute":"query-machines"}
under KVM now results in
    {"return": [
        {
            "hotpluggable-cpus": true,
            "name": "s390-ccw-virtio-4.0",
            "numa-mem-supported": false,
            "default-cpu-type": "host-s390x-cpu",
            "cpu-max": 248,
            "deprecated": false},
        {
            "hotpluggable-cpus": true,
            "name": "s390-ccw-virtio-2.7",
            "numa-mem-supported": false,
            "default-cpu-type": "host-s390x-cpu",
            "cpu-max": 248,
            "deprecated": false
        } ...

Libvirt probes all machines via "-machine none,accel=kvm:tcg" and will
currently see the wrong CPU model under KVM.

Reported-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Fixes: b6805e127c6b ("s390x: use generic cpu_model parsing")
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20191021100515.6978-1-david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
target/s390x/kvm.c