]> git.ipfire.org Git - thirdparty/squid.git/commit
Bug #3214: "helperHandleRead: unexpected read from ssl_crtd" errors.
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Fri, 6 May 2011 09:17:54 +0000 (12:17 +0300)
committerChristos Tsantilas <chtsanti@users.sourceforge.net>
Fri, 6 May 2011 09:17:54 +0000 (12:17 +0300)
commit0af9303a0200d5aef04d82bf7bd467e59a7cbe5b
tree63aaa26642ce0ce0a686c963a52346d90eabb699
parentb68415a1d7d08d3845db1bfe206d18704c00e663
Bug #3214: "helperHandleRead: unexpected read from ssl_crtd" errors.

Squid would read the beginning of a crtd response split across multiple
read operations and treat it as a complete response, causing various
certificate-related errors.

This patch:
 - allow the use of other than the '\n' character as the end of message mark
   for helper responses.
 - Use the '\1' char as end-of-message char for crtd helper. This char looks
   safe because the crtd messages are clear text only messages.
src/helper.cc
src/helper.h
src/ssl/crtd_message.cc
src/ssl/helper.cc
src/ssl/ssl_crtd.cc