]> git.ipfire.org Git - thirdparty/squid.git/commit
Bug 3214: "helperHandleRead: unexpected read from ssl_crtd" errors.
authorChristos Tsantilas <chtsanti@users.sourceforge.net>
Fri, 17 Jun 2011 12:36:07 +0000 (06:36 -0600)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 17 Jun 2011 12:36:07 +0000 (06:36 -0600)
commit51e23b582e907c31f22bd157dadb81fa2f684b43
tree6a7f9d118d4a980f950e9da64d8417f6d58deb34
parent00a88755213ed1c84b48ec3f5fda4a6b8b0817c3
Bug 3214: "helperHandleRead: unexpected read from ssl_crtd" errors.

Squid would read the beginning of a crtd response split across multiple
read operations and treat it as a complete response, causing various
certificate-related errors.

This patch:
 - allow the use of other than the '\n' character as the end of message mark
   for helper responses.
 - Use the '\1' char as end-of-message char for crtd helper. This char looks
   safe because the crtd messages are clear text only messages.
src/helper.cc
src/helper.h
src/ssl/crtd_message.cc
src/ssl/helper.cc
src/ssl/ssl_crtd.cc