]> git.ipfire.org Git - thirdparty/squid.git/commit
Removed HandshakeParser::parseError and hid/renamed its parseDone.
authorAlex Rousskov <rousskov@measurement-factory.com>
Sat, 23 Apr 2016 04:46:12 +0000 (22:46 -0600)
committerAlex Rousskov <rousskov@measurement-factory.com>
Sat, 23 Apr 2016 04:46:12 +0000 (22:46 -0600)
commitd20cf1863de1c4b3e070c1781d091eea1054ce9f
tree3740e9fab4a86569add409bb18306ab6ce0fe387
parent2549b7ac88340919cfbfbf9d5dbf78f4144ef960
Removed HandshakeParser::parseError and hid/renamed its parseDone.

The presence of two "persistent" parsing outcomes (done and error) was
confusing to the callers: Which one do I check and when? The adjusted
interface uses exceptions for errors and a false parseHandshake() return
value to signal "need more data". This simplifies the API and untangles
the calling code quite a bit.
src/client_side.cc
src/client_side.h
src/security/Handshake.cc
src/security/Handshake.h
src/ssl/bio.cc
src/ssl/bio.h