]> git.ipfire.org Git - thirdparty/strongswan.git/commit
ike: Only track actually sent retransmits as outbound packets
authorTobias Brunner <tobias@strongswan.org>
Thu, 30 Apr 2020 15:42:07 +0000 (17:42 +0200)
committerTobias Brunner <tobias@strongswan.org>
Tue, 2 Jun 2020 12:07:06 +0000 (14:07 +0200)
commit2edc73d84eb9c97ba610edaf75e48cfffd85d31d
tree92fc5fe84a593e61bd172c16885aa278206e6b9b
parentf3695d089b22833c8287bf63f4a8ce336ba5569a
ike: Only track actually sent retransmits as outbound packets

Retransmission jobs for old requests for which we already received a
response previously left the impression that messages were sent more
recently than was actually the case.

task_manager_t always defined INVALID_STATE as possible return value if
no retransmit was sent, this just was never actually returned.

I guess we could further differentiate between actual invalid states
(e.g. if we already received the response) and when we don't send a
retransmit for other reasons e.g. because the IKE_SA became stale.
src/libcharon/sa/ike_sa.c
src/libcharon/sa/ike_sa.h
src/libcharon/sa/ikev1/task_manager_v1.c
src/libcharon/sa/ikev2/task_manager_v2.c