]>
Commit | Line | Data |
---|---|---|
56ebfaf1 LP |
1 | /*** |
2 | This file is part of systemd. | |
3 | ||
4 | Copyright 2015 Lennart Poettering | |
5 | ||
6 | systemd is free software; you can redistribute it and/or modify it | |
7 | under the terms of the GNU Lesser General Public License as published by | |
8 | the Free Software Foundation; either version 2.1 of the License, or | |
9 | (at your option) any later version. | |
10 | ||
11 | systemd is distributed in the hope that it will be useful, but | |
12 | WITHOUT ANY WARRANTY; without even the implied warranty of | |
13 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
14 | Lesser General Public License for more details. | |
15 | ||
16 | You should have received a copy of the GNU Lesser General Public License | |
17 | along with systemd; If not, see <http://www.gnu.org/licenses/>. | |
18 | ***/ | |
19 | ||
56ebfaf1 | 20 | #include <curl/curl.h> |
cf0fbc49 | 21 | #include <sys/prctl.h> |
56ebfaf1 | 22 | |
7079cfef | 23 | #include "sd-daemon.h" |
07630cea | 24 | |
b5efdb8a | 25 | #include "alloc-util.h" |
56ebfaf1 | 26 | #include "btrfs-util.h" |
07630cea LP |
27 | #include "copy.h" |
28 | #include "curl-util.h" | |
3ffd4af2 | 29 | #include "fd-util.h" |
0d39fa9c | 30 | #include "fileio.h" |
f4f15635 | 31 | #include "fs-util.h" |
07630cea LP |
32 | #include "hostname-util.h" |
33 | #include "import-common.h" | |
34 | #include "import-util.h" | |
56ebfaf1 LP |
35 | #include "macro.h" |
36 | #include "mkdir.h" | |
26166c88 | 37 | #include "path-util.h" |
25300b5a | 38 | #include "process-util.h" |
dc2c282b | 39 | #include "pull-common.h" |
07630cea | 40 | #include "pull-job.h" |
3ffd4af2 | 41 | #include "pull-tar.h" |
07630cea LP |
42 | #include "rm-rf.h" |
43 | #include "string-util.h" | |
44 | #include "strv.h" | |
45 | #include "utf8.h" | |
46 | #include "util.h" | |
49cf4170 | 47 | #include "web-util.h" |
56ebfaf1 | 48 | |
7079cfef LP |
49 | typedef enum TarProgress { |
50 | TAR_DOWNLOADING, | |
51 | TAR_VERIFYING, | |
52 | TAR_FINALIZING, | |
53 | TAR_COPYING, | |
54 | } TarProgress; | |
55 | ||
dc2c282b | 56 | struct TarPull { |
56ebfaf1 LP |
57 | sd_event *event; |
58 | CurlGlue *glue; | |
59 | ||
60 | char *image_root; | |
61 | ||
dc2c282b | 62 | PullJob *tar_job; |
9854730b | 63 | PullJob *settings_job; |
dc2c282b LP |
64 | PullJob *checksum_job; |
65 | PullJob *signature_job; | |
56ebfaf1 | 66 | |
dc2c282b | 67 | TarPullFinished on_finished; |
56ebfaf1 LP |
68 | void *userdata; |
69 | ||
56ebfaf1 LP |
70 | char *local; |
71 | bool force_local; | |
26166c88 | 72 | bool grow_machine_directory; |
9854730b | 73 | bool settings; |
56ebfaf1 LP |
74 | |
75 | pid_t tar_pid; | |
76 | ||
56ebfaf1 | 77 | char *final_path; |
9854730b LP |
78 | char *temp_path; |
79 | ||
80 | char *settings_path; | |
81 | char *settings_temp_path; | |
0100b6e1 LP |
82 | |
83 | ImportVerify verify; | |
56ebfaf1 LP |
84 | }; |
85 | ||
dc2c282b | 86 | TarPull* tar_pull_unref(TarPull *i) { |
56ebfaf1 LP |
87 | if (!i) |
88 | return NULL; | |
89 | ||
0100b6e1 | 90 | if (i->tar_pid > 1) { |
8b71fce8 | 91 | (void) kill_and_sigcont(i->tar_pid, SIGKILL); |
0100b6e1 | 92 | (void) wait_for_terminate(i->tar_pid, NULL); |
56ebfaf1 LP |
93 | } |
94 | ||
dc2c282b | 95 | pull_job_unref(i->tar_job); |
9854730b | 96 | pull_job_unref(i->settings_job); |
dc2c282b LP |
97 | pull_job_unref(i->checksum_job); |
98 | pull_job_unref(i->signature_job); | |
56ebfaf1 LP |
99 | |
100 | curl_glue_unref(i->glue); | |
101 | sd_event_unref(i->event); | |
102 | ||
103 | if (i->temp_path) { | |
d9e2daaf | 104 | (void) rm_rf(i->temp_path, REMOVE_ROOT|REMOVE_PHYSICAL|REMOVE_SUBVOLUME); |
0d6e763b | 105 | free(i->temp_path); |
56ebfaf1 LP |
106 | } |
107 | ||
9854730b LP |
108 | if (i->settings_temp_path) { |
109 | (void) unlink(i->settings_temp_path); | |
110 | free(i->settings_temp_path); | |
111 | } | |
112 | ||
56ebfaf1 | 113 | free(i->final_path); |
9854730b | 114 | free(i->settings_path); |
56ebfaf1 LP |
115 | free(i->image_root); |
116 | free(i->local); | |
6b430fdb | 117 | return mfree(i); |
56ebfaf1 LP |
118 | } |
119 | ||
dc2c282b LP |
120 | int tar_pull_new( |
121 | TarPull **ret, | |
8b71fce8 LP |
122 | sd_event *event, |
123 | const char *image_root, | |
dc2c282b | 124 | TarPullFinished on_finished, |
8b71fce8 LP |
125 | void *userdata) { |
126 | ||
dc2c282b | 127 | _cleanup_(tar_pull_unrefp) TarPull *i = NULL; |
56ebfaf1 LP |
128 | int r; |
129 | ||
130 | assert(ret); | |
56ebfaf1 | 131 | |
dc2c282b | 132 | i = new0(TarPull, 1); |
56ebfaf1 LP |
133 | if (!i) |
134 | return -ENOMEM; | |
135 | ||
136 | i->on_finished = on_finished; | |
137 | i->userdata = userdata; | |
138 | ||
139 | i->image_root = strdup(image_root ?: "/var/lib/machines"); | |
140 | if (!i->image_root) | |
141 | return -ENOMEM; | |
142 | ||
26166c88 LP |
143 | i->grow_machine_directory = path_startswith(i->image_root, "/var/lib/machines"); |
144 | ||
9854730b LP |
145 | if (event) |
146 | i->event = sd_event_ref(event); | |
147 | else { | |
148 | r = sd_event_default(&i->event); | |
149 | if (r < 0) | |
150 | return r; | |
151 | } | |
56ebfaf1 LP |
152 | |
153 | r = curl_glue_new(&i->glue, i->event); | |
154 | if (r < 0) | |
155 | return r; | |
156 | ||
dc2c282b | 157 | i->glue->on_finished = pull_job_curl_on_finished; |
56ebfaf1 LP |
158 | i->glue->userdata = i; |
159 | ||
160 | *ret = i; | |
161 | i = NULL; | |
162 | ||
163 | return 0; | |
164 | } | |
165 | ||
dc2c282b | 166 | static void tar_pull_report_progress(TarPull *i, TarProgress p) { |
7079cfef LP |
167 | unsigned percent; |
168 | ||
169 | assert(i); | |
170 | ||
171 | switch (p) { | |
172 | ||
173 | case TAR_DOWNLOADING: { | |
174 | unsigned remain = 85; | |
175 | ||
176 | percent = 0; | |
177 | ||
9854730b LP |
178 | if (i->settings_job) { |
179 | percent += i->settings_job->progress_percent * 5 / 100; | |
180 | remain -= 5; | |
181 | } | |
182 | ||
7079cfef LP |
183 | if (i->checksum_job) { |
184 | percent += i->checksum_job->progress_percent * 5 / 100; | |
185 | remain -= 5; | |
186 | } | |
187 | ||
188 | if (i->signature_job) { | |
189 | percent += i->signature_job->progress_percent * 5 / 100; | |
190 | remain -= 5; | |
191 | } | |
192 | ||
193 | if (i->tar_job) | |
194 | percent += i->tar_job->progress_percent * remain / 100; | |
195 | break; | |
196 | } | |
197 | ||
198 | case TAR_VERIFYING: | |
199 | percent = 85; | |
200 | break; | |
201 | ||
202 | case TAR_FINALIZING: | |
203 | percent = 90; | |
204 | break; | |
205 | ||
206 | case TAR_COPYING: | |
207 | percent = 95; | |
208 | break; | |
209 | ||
210 | default: | |
211 | assert_not_reached("Unknown progress state"); | |
212 | } | |
213 | ||
214 | sd_notifyf(false, "X_IMPORT_PROGRESS=%u", percent); | |
215 | log_debug("Combined progress %u%%", percent); | |
216 | } | |
217 | ||
dc2c282b | 218 | static int tar_pull_make_local_copy(TarPull *i) { |
0d6e763b LP |
219 | int r; |
220 | ||
221 | assert(i); | |
222 | assert(i->tar_job); | |
223 | ||
224 | if (!i->local) | |
225 | return 0; | |
226 | ||
227 | if (!i->final_path) { | |
dc2c282b | 228 | r = pull_make_path(i->tar_job->url, i->tar_job->etag, i->image_root, ".tar-", NULL, &i->final_path); |
0d6e763b LP |
229 | if (r < 0) |
230 | return log_oom(); | |
0d6e763b LP |
231 | } |
232 | ||
dc2c282b | 233 | r = pull_make_local_copy(i->final_path, i->image_root, i->local, i->force_local); |
0100b6e1 LP |
234 | if (r < 0) |
235 | return r; | |
236 | ||
9854730b LP |
237 | if (i->settings) { |
238 | const char *local_settings; | |
239 | assert(i->settings_job); | |
240 | ||
241 | if (!i->settings_path) { | |
242 | r = pull_make_path(i->settings_job->url, i->settings_job->etag, i->image_root, ".settings-", NULL, &i->settings_path); | |
243 | if (r < 0) | |
244 | return log_oom(); | |
245 | } | |
246 | ||
247 | local_settings = strjoina(i->image_root, "/", i->local, ".nspawn"); | |
248 | ||
249 | r = copy_file_atomic(i->settings_path, local_settings, 0664, i->force_local, 0); | |
250 | if (r == -EEXIST) | |
251 | log_warning_errno(r, "Settings file %s already exists, not replacing.", local_settings); | |
33859a6b LP |
252 | else if (r == -ENOENT) |
253 | log_debug_errno(r, "Skipping creation of settings file, since none was found."); | |
254 | else if (r < 0) | |
79b6198b LP |
255 | log_warning_errno(r, "Failed to copy settings files %s, ignoring: %m", local_settings); |
256 | else | |
33859a6b | 257 | log_info("Created new settings file %s.", local_settings); |
9854730b LP |
258 | } |
259 | ||
0d6e763b LP |
260 | return 0; |
261 | } | |
262 | ||
dc2c282b | 263 | static bool tar_pull_is_done(TarPull *i) { |
8b71fce8 LP |
264 | assert(i); |
265 | assert(i->tar_job); | |
266 | ||
9854730b | 267 | if (!PULL_JOB_IS_COMPLETE(i->tar_job)) |
8b71fce8 | 268 | return false; |
9854730b | 269 | if (i->settings_job && !PULL_JOB_IS_COMPLETE(i->settings_job)) |
8b71fce8 | 270 | return false; |
9854730b LP |
271 | if (i->checksum_job && !PULL_JOB_IS_COMPLETE(i->checksum_job)) |
272 | return false; | |
273 | if (i->signature_job && !PULL_JOB_IS_COMPLETE(i->signature_job)) | |
8b71fce8 LP |
274 | return false; |
275 | ||
276 | return true; | |
277 | } | |
278 | ||
dc2c282b LP |
279 | static void tar_pull_job_on_finished(PullJob *j) { |
280 | TarPull *i; | |
56ebfaf1 LP |
281 | int r; |
282 | ||
283 | assert(j); | |
284 | assert(j->userdata); | |
285 | ||
286 | i = j->userdata; | |
9854730b LP |
287 | |
288 | if (j == i->settings_job) { | |
289 | if (j->error != 0) | |
290 | log_info_errno(j->error, "Settings file could not be retrieved, proceeding without."); | |
291 | } else if (j->error != 0) { | |
0100b6e1 LP |
292 | if (j == i->checksum_job) |
293 | log_error_errno(j->error, "Failed to retrieve SHA256 checksum, cannot verify. (Try --verify=no?)"); | |
294 | else if (j == i->signature_job) | |
295 | log_error_errno(j->error, "Failed to retrieve signature file, cannot verify. (Try --verify=no?)"); | |
296 | else | |
297 | log_error_errno(j->error, "Failed to retrieve image file. (Wrong URL?)"); | |
298 | ||
56ebfaf1 LP |
299 | r = j->error; |
300 | goto finish; | |
301 | } | |
302 | ||
303 | /* This is invoked if either the download completed | |
304 | * successfully, or the download was skipped because we | |
305 | * already have the etag. */ | |
306 | ||
dc2c282b | 307 | if (!tar_pull_is_done(i)) |
0100b6e1 LP |
308 | return; |
309 | ||
9854730b LP |
310 | i->tar_job->disk_fd = safe_close(i->tar_job->disk_fd); |
311 | if (i->settings_job) | |
312 | i->settings_job->disk_fd = safe_close(i->settings_job->disk_fd); | |
56ebfaf1 LP |
313 | |
314 | if (i->tar_pid > 0) { | |
315 | r = wait_for_terminate_and_warn("tar", i->tar_pid, true); | |
316 | i->tar_pid = 0; | |
317 | if (r < 0) | |
318 | goto finish; | |
9854730b LP |
319 | if (r > 0) { |
320 | r = -EIO; | |
321 | goto finish; | |
322 | } | |
56ebfaf1 LP |
323 | } |
324 | ||
0100b6e1 LP |
325 | if (!i->tar_job->etag_exists) { |
326 | /* This is a new download, verify it, and move it into place */ | |
327 | ||
dc2c282b | 328 | tar_pull_report_progress(i, TAR_VERIFYING); |
7079cfef | 329 | |
9854730b | 330 | r = pull_verify(i->tar_job, i->settings_job, i->checksum_job, i->signature_job); |
0100b6e1 LP |
331 | if (r < 0) |
332 | goto finish; | |
333 | ||
dc2c282b | 334 | tar_pull_report_progress(i, TAR_FINALIZING); |
7079cfef | 335 | |
b6e676ce | 336 | r = import_make_read_only(i->temp_path); |
56ebfaf1 LP |
337 | if (r < 0) |
338 | goto finish; | |
339 | ||
f85ef957 AC |
340 | r = rename_noreplace(AT_FDCWD, i->temp_path, AT_FDCWD, i->final_path); |
341 | if (r < 0) { | |
342 | log_error_errno(r, "Failed to rename to final image name: %m"); | |
56ebfaf1 LP |
343 | goto finish; |
344 | } | |
56ebfaf1 | 345 | |
9854730b LP |
346 | i->temp_path = mfree(i->temp_path); |
347 | ||
348 | if (i->settings_job && | |
349 | i->settings_job->error == 0 && | |
350 | !i->settings_job->etag_exists) { | |
351 | ||
352 | assert(i->settings_temp_path); | |
353 | assert(i->settings_path); | |
354 | ||
355 | /* Also move the settings file into place, if | |
356 | * it exist. Note that we do so only if we | |
357 | * also moved the tar file in place, to keep | |
358 | * things strictly in sync. */ | |
359 | ||
360 | r = import_make_read_only(i->settings_temp_path); | |
361 | if (r < 0) | |
362 | goto finish; | |
363 | ||
364 | r = rename_noreplace(AT_FDCWD, i->settings_temp_path, AT_FDCWD, i->settings_path); | |
365 | if (r < 0) { | |
366 | log_error_errno(r, "Failed to rename settings file: %m"); | |
367 | goto finish; | |
368 | } | |
369 | ||
370 | i->settings_temp_path = mfree(i->settings_temp_path); | |
371 | } | |
56ebfaf1 LP |
372 | } |
373 | ||
dc2c282b | 374 | tar_pull_report_progress(i, TAR_COPYING); |
7079cfef | 375 | |
dc2c282b | 376 | r = tar_pull_make_local_copy(i); |
0d6e763b LP |
377 | if (r < 0) |
378 | goto finish; | |
379 | ||
56ebfaf1 LP |
380 | r = 0; |
381 | ||
382 | finish: | |
56ebfaf1 LP |
383 | if (i->on_finished) |
384 | i->on_finished(i, r, i->userdata); | |
385 | else | |
386 | sd_event_exit(i->event, r); | |
387 | } | |
388 | ||
9854730b | 389 | static int tar_pull_job_on_open_disk_tar(PullJob *j) { |
dc2c282b | 390 | TarPull *i; |
56ebfaf1 LP |
391 | int r; |
392 | ||
393 | assert(j); | |
394 | assert(j->userdata); | |
395 | ||
396 | i = j->userdata; | |
8b71fce8 LP |
397 | assert(i->tar_job == j); |
398 | assert(!i->final_path); | |
399 | assert(!i->temp_path); | |
400 | assert(i->tar_pid <= 0); | |
56ebfaf1 | 401 | |
dc2c282b | 402 | r = pull_make_path(j->url, j->etag, i->image_root, ".tar-", NULL, &i->final_path); |
56ebfaf1 LP |
403 | if (r < 0) |
404 | return log_oom(); | |
405 | ||
14bcf25c | 406 | r = tempfn_random(i->final_path, NULL, &i->temp_path); |
56ebfaf1 LP |
407 | if (r < 0) |
408 | return log_oom(); | |
409 | ||
410 | mkdir_parents_label(i->temp_path, 0700); | |
411 | ||
412 | r = btrfs_subvol_make(i->temp_path); | |
413 | if (r == -ENOTTY) { | |
414 | if (mkdir(i->temp_path, 0755) < 0) | |
415 | return log_error_errno(errno, "Failed to create directory %s: %m", i->temp_path); | |
416 | } else if (r < 0) | |
709f6e46 | 417 | return log_error_errno(r, "Failed to create subvolume %s: %m", i->temp_path); |
8c9cfc28 LP |
418 | else |
419 | (void) import_assign_pool_quota_and_warn(i->temp_path); | |
56ebfaf1 | 420 | |
587fec42 | 421 | j->disk_fd = import_fork_tar_x(i->temp_path, &i->tar_pid); |
2c140ded LP |
422 | if (j->disk_fd < 0) |
423 | return j->disk_fd; | |
56ebfaf1 LP |
424 | |
425 | return 0; | |
426 | } | |
427 | ||
9854730b LP |
428 | static int tar_pull_job_on_open_disk_settings(PullJob *j) { |
429 | TarPull *i; | |
430 | int r; | |
431 | ||
432 | assert(j); | |
433 | assert(j->userdata); | |
434 | ||
435 | i = j->userdata; | |
436 | assert(i->settings_job == j); | |
437 | assert(!i->settings_path); | |
438 | assert(!i->settings_temp_path); | |
439 | ||
440 | r = pull_make_path(j->url, j->etag, i->image_root, ".settings-", NULL, &i->settings_path); | |
441 | if (r < 0) | |
442 | return log_oom(); | |
443 | ||
444 | r = tempfn_random(i->settings_path, NULL, &i->settings_temp_path); | |
445 | if (r < 0) | |
446 | return log_oom(); | |
447 | ||
448 | mkdir_parents_label(i->settings_temp_path, 0700); | |
449 | ||
450 | j->disk_fd = open(i->settings_temp_path, O_RDWR|O_CREAT|O_EXCL|O_NOCTTY|O_CLOEXEC, 0664); | |
451 | if (j->disk_fd < 0) | |
452 | return log_error_errno(errno, "Failed to create %s: %m", i->settings_temp_path); | |
453 | ||
454 | return 0; | |
455 | } | |
456 | ||
dc2c282b LP |
457 | static void tar_pull_job_on_progress(PullJob *j) { |
458 | TarPull *i; | |
7079cfef LP |
459 | |
460 | assert(j); | |
461 | assert(j->userdata); | |
462 | ||
463 | i = j->userdata; | |
464 | ||
dc2c282b | 465 | tar_pull_report_progress(i, TAR_DOWNLOADING); |
7079cfef LP |
466 | } |
467 | ||
9854730b LP |
468 | int tar_pull_start( |
469 | TarPull *i, | |
470 | const char *url, | |
471 | const char *local, | |
472 | bool force_local, | |
473 | ImportVerify verify, | |
474 | bool settings) { | |
475 | ||
56ebfaf1 LP |
476 | int r; |
477 | ||
478 | assert(i); | |
9854730b LP |
479 | assert(verify < _IMPORT_VERIFY_MAX); |
480 | assert(verify >= 0); | |
56ebfaf1 | 481 | |
56ebfaf1 LP |
482 | if (!http_url_is_valid(url)) |
483 | return -EINVAL; | |
484 | ||
485 | if (local && !machine_name_is_valid(local)) | |
486 | return -EINVAL; | |
487 | ||
8b71fce8 LP |
488 | if (i->tar_job) |
489 | return -EBUSY; | |
490 | ||
56ebfaf1 LP |
491 | r = free_and_strdup(&i->local, local); |
492 | if (r < 0) | |
493 | return r; | |
9854730b | 494 | |
56ebfaf1 | 495 | i->force_local = force_local; |
0100b6e1 | 496 | i->verify = verify; |
9854730b | 497 | i->settings = settings; |
56ebfaf1 | 498 | |
9854730b | 499 | /* Set up download job for TAR file */ |
dc2c282b | 500 | r = pull_job_new(&i->tar_job, url, i->glue, i); |
56ebfaf1 LP |
501 | if (r < 0) |
502 | return r; | |
503 | ||
dc2c282b | 504 | i->tar_job->on_finished = tar_pull_job_on_finished; |
9854730b | 505 | i->tar_job->on_open_disk = tar_pull_job_on_open_disk_tar; |
dc2c282b | 506 | i->tar_job->on_progress = tar_pull_job_on_progress; |
0100b6e1 | 507 | i->tar_job->calc_checksum = verify != IMPORT_VERIFY_NO; |
26166c88 | 508 | i->tar_job->grow_machine_directory = i->grow_machine_directory; |
56ebfaf1 | 509 | |
dc2c282b | 510 | r = pull_find_old_etags(url, i->image_root, DT_DIR, ".tar-", NULL, &i->tar_job->old_etags); |
56ebfaf1 LP |
511 | if (r < 0) |
512 | return r; | |
513 | ||
9854730b LP |
514 | /* Set up download job for the settings file (.nspawn) */ |
515 | if (settings) { | |
516 | r = pull_make_settings_job(&i->settings_job, url, i->glue, tar_pull_job_on_finished, i); | |
517 | if (r < 0) | |
518 | return r; | |
519 | ||
520 | i->settings_job->on_open_disk = tar_pull_job_on_open_disk_settings; | |
521 | i->settings_job->on_progress = tar_pull_job_on_progress; | |
522 | i->settings_job->calc_checksum = verify != IMPORT_VERIFY_NO; | |
523 | ||
524 | r = pull_find_old_etags(i->settings_job->url, i->image_root, DT_REG, ".settings-", NULL, &i->settings_job->old_etags); | |
525 | if (r < 0) | |
526 | return r; | |
527 | } | |
528 | ||
529 | /* Set up download of checksum/signature files */ | |
dc2c282b | 530 | r = pull_make_verification_jobs(&i->checksum_job, &i->signature_job, verify, url, i->glue, tar_pull_job_on_finished, i); |
0100b6e1 LP |
531 | if (r < 0) |
532 | return r; | |
533 | ||
dc2c282b | 534 | r = pull_job_begin(i->tar_job); |
0100b6e1 LP |
535 | if (r < 0) |
536 | return r; | |
537 | ||
9854730b LP |
538 | if (i->settings_job) { |
539 | r = pull_job_begin(i->settings_job); | |
540 | if (r < 0) | |
541 | return r; | |
542 | } | |
543 | ||
0100b6e1 | 544 | if (i->checksum_job) { |
dc2c282b | 545 | i->checksum_job->on_progress = tar_pull_job_on_progress; |
7079cfef | 546 | |
dc2c282b | 547 | r = pull_job_begin(i->checksum_job); |
0100b6e1 LP |
548 | if (r < 0) |
549 | return r; | |
550 | } | |
551 | ||
552 | if (i->signature_job) { | |
dc2c282b | 553 | i->signature_job->on_progress = tar_pull_job_on_progress; |
7079cfef | 554 | |
dc2c282b | 555 | r = pull_job_begin(i->signature_job); |
0100b6e1 LP |
556 | if (r < 0) |
557 | return r; | |
558 | } | |
559 | ||
560 | return 0; | |
56ebfaf1 | 561 | } |