#include <fcntl.h>
#include <stdbool.h>
#include <stddef.h>
-#include <stdio.h>
-#include <string.h>
#include <sys/stat.h>
#include <unistd.h>
#include "fd-util.h"
#include "format-util.h"
#include "fs-util.h"
+#include "libudev-util.h"
+#include "mkdir.h"
#include "path-util.h"
#include "selinux-util.h"
#include "smack-util.h"
#include "stdio-util.h"
#include "string-util.h"
+#include "strxcpyx.h"
#include "udev-node.h"
+#include "user-util.h"
static int node_symlink(sd_device *dev, const char *node, const char *slink) {
_cleanup_free_ char *slink_dirname = NULL, *target = NULL;
/* use relative link */
r = path_make_relative(slink_dirname, node, &target);
if (r < 0)
- return log_error_errno(r, "Failed to get relative path from '%s' to '%s': %m", slink, node);
+ return log_device_error_errno(dev, r, "Failed to get relative path from '%s' to '%s': %m", slink, node);
/* preserve link with correct target, do not replace node of other device */
if (lstat(slink, &stats) == 0) {
if (S_ISBLK(stats.st_mode) || S_ISCHR(stats.st_mode)) {
- log_error("Conflicting device node '%s' found, link to '%s' will not be created.", slink, node);
+ log_device_error(dev, "Conflicting device node '%s' found, link to '%s' will not be created.", slink, node);
return -EOPNOTSUPP;
} else if (S_ISLNK(stats.st_mode)) {
- char buf[PATH_MAX];
- ssize_t len;
-
- len = readlink(slink, buf, sizeof(buf));
- if (len > 0 && len < (ssize_t) sizeof(buf)) {
- buf[len] = '\0';
- if (streq(target, buf)) {
- log_debug("Preserve already existing symlink '%s' to '%s'", slink, target);
- (void) label_fix(slink, LABEL_IGNORE_ENOENT);
- (void) utimensat(AT_FDCWD, slink, NULL, AT_SYMLINK_NOFOLLOW);
- return 0;
- }
+ _cleanup_free_ char *buf = NULL;
+
+ if (readlink_malloc(slink, &buf) >= 0 &&
+ streq(target, buf)) {
+ log_device_debug(dev, "Preserve already existing symlink '%s' to '%s'", slink, target);
+ (void) label_fix(slink, LABEL_IGNORE_ENOENT);
+ (void) utimensat(AT_FDCWD, slink, NULL, AT_SYMLINK_NOFOLLOW);
+ return 0;
}
}
} else {
- log_debug("Creating symlink '%s' to '%s'", slink, target);
+ log_device_debug(dev, "Creating symlink '%s' to '%s'", slink, target);
do {
r = mkdir_parents_label(slink, 0755);
if (!IN_SET(r, 0, -ENOENT))
} while (r == -ENOENT);
if (r == 0)
return 0;
+ if (r < 0)
+ log_device_debug_errno(dev, r, "Failed to create symlink '%s' to '%s', trying to replace '%s': %m", slink, target, slink);
}
- log_debug("Atomically replace '%s'", slink);
+ log_device_debug(dev, "Atomically replace '%s'", slink);
r = device_get_id_filename(dev, &id_filename);
if (r < 0)
- return log_error_errno(r, "Failed to get id_filename: %m");
+ return log_device_error_errno(dev, r, "Failed to get id_filename: %m");
slink_tmp = strjoina(slink, ".tmp-", id_filename);
(void) unlink(slink_tmp);
do {
mac_selinux_create_file_clear();
} while (r == -ENOENT);
if (r < 0)
- return log_error_errno(r, "Failed to create symlink '%s' to '%s': %m", slink_tmp, target);
+ return log_device_error_errno(dev, r, "Failed to create symlink '%s' to '%s': %m", slink_tmp, target);
if (rename(slink_tmp, slink) < 0) {
- r = log_error_errno(errno, "Failed to rename '%s' to '%s' failed: %m", slink_tmp, slink);
+ r = log_device_error_errno(dev, errno, "Failed to rename '%s' to '%s': %m", slink_tmp, slink);
(void) unlink(slink_tmp);
}
if (dent->d_name[0] == '.')
continue;
- log_debug("Found '%s' claiming '%s'", dent->d_name, stackdir);
+ log_device_debug(dev, "Found '%s' claiming '%s'", dent->d_name, stackdir);
if (device_get_id_filename(dev, &id_filename) < 0)
continue;
if (target && db_prio <= priority)
continue;
- if (DEBUG_LOGGING) {
- const char *syspath = NULL;
-
- (void) sd_device_get_syspath(dev_db, &syspath);
- log_debug("Device '%s' claims priority %i for '%s'", strnull(syspath), db_prio, stackdir);
- }
+ log_device_debug(dev_db, "Device claims priority %i for '%s'", db_prio, stackdir);
r = free_and_strdup(&target, devnode);
if (r < 0)
priority = db_prio;
}
+ if (!target)
+ return -ENOENT;
+
*ret = TAKE_PTR(target);
return 0;
}
r = device_get_id_filename(dev, &id_filename);
if (r < 0)
- return log_debug_errno(r, "Failed to get id_filename: %m");
+ return log_device_debug_errno(dev, r, "Failed to get id_filename: %m");
util_path_encode(slink + STRLEN("/dev"), name_enc, sizeof(name_enc));
- dirname = path_join(NULL, "/run/udev/links/", name_enc);
+ dirname = path_join("/run/udev/links/", name_enc);
if (!dirname)
return log_oom();
- filename = path_join(NULL, dirname, id_filename);
+ filename = path_join(dirname, id_filename);
if (!filename)
return log_oom();
r = link_find_prioritized(dev, add, dirname, &target);
if (r < 0) {
- log_debug("No reference left, removing '%s'", slink);
+ log_device_debug(dev, "No reference left, removing '%s'", slink);
if (unlink(slink) == 0)
(void) rmdir_parents(slink, "/");
- } else {
- log_debug("Creating link '%s' to '%s'", slink, target);
+ } else
(void) node_symlink(dev, target, slink);
- }
if (add)
do {
r = sd_device_get_devpath(dev, &devpath);
if (r < 0)
- return log_debug_errno(r, "Failed to get devpath: %m");
+ return log_device_debug_errno(dev, r, "Failed to get devpath: %m");
/* update possible left-over symlinks */
FOREACH_DEVICE_DEVLINK(dev_old, name) {
if (found)
continue;
- log_debug("Updating old name, '%s' no longer belonging to '%s'",
- name, devpath);
+ log_device_debug(dev, "Updating old name, '%s' no longer belonging to '%s'",
+ name, devpath);
link_update(dev, name, false);
}
return 0;
}
-static int node_permissions_apply(sd_device *dev, bool apply,
+static int node_permissions_apply(sd_device *dev, bool apply_mac,
mode_t mode, uid_t uid, gid_t gid,
- struct udev_list *seclabel_list) {
+ OrderedHashmap *seclabel_list) {
const char *devnode, *subsystem, *id_filename = NULL;
- struct udev_list_entry *entry;
struct stat stats;
dev_t devnum;
- int r = 0;
+ bool apply_mode, apply_uid, apply_gid;
+ int r;
assert(dev);
r = sd_device_get_devname(dev, &devnode);
if (r < 0)
- return log_debug_errno(r, "Failed to get devname: %m");
+ return log_device_debug_errno(dev, r, "Failed to get devname: %m");
r = sd_device_get_subsystem(dev, &subsystem);
if (r < 0)
- return log_debug_errno(r, "Failed to get subsystem: %m");
+ return log_device_debug_errno(dev, r, "Failed to get subsystem: %m");
r = sd_device_get_devnum(dev, &devnum);
if (r < 0)
- return log_debug_errno(r, "Failed to get devnum: %m");
+ return log_device_debug_errno(dev, r, "Failed to get devnum: %m");
(void) device_get_id_filename(dev, &id_filename);
if (streq(subsystem, "block"))
mode |= S_IFCHR;
if (lstat(devnode, &stats) < 0)
- return log_debug_errno(errno, "cannot stat() node '%s' (%m)", devnode);
+ return log_device_debug_errno(dev, errno, "cannot stat() node %s: %m", devnode);
- if (((stats.st_mode & S_IFMT) != (mode & S_IFMT)) || (stats.st_rdev != devnum))
- return log_debug_errno(EEXIST, "Found node '%s' with non-matching devnum %s, skip handling",
- devnode, id_filename);
+ if ((mode != MODE_INVALID && (stats.st_mode & S_IFMT) != (mode & S_IFMT)) || stats.st_rdev != devnum)
+ return log_device_debug_errno(dev, SYNTHETIC_ERRNO(EEXIST),
+ "Found node '%s' with non-matching devnum %s, skip handling",
+ devnode, id_filename);
- if (apply) {
- bool selinux = false, smack = false;
+ apply_mode = mode != MODE_INVALID && (stats.st_mode & 0777) != (mode & 0777);
+ apply_uid = uid_is_valid(uid) && stats.st_uid != uid;
+ apply_gid = gid_is_valid(gid) && stats.st_gid != gid;
- if ((stats.st_mode & 0777) != (mode & 0777) || stats.st_uid != uid || stats.st_gid != gid) {
- log_debug("Setting permissions %s, %#o, uid=%u, gid=%u", devnode, mode, uid, gid);
- if (chmod(devnode, mode) < 0)
- r = log_warning_errno(errno, "Failed to set mode of %s to %#o: %m", devnode, mode);
- if (chown(devnode, uid, gid) < 0)
- r = log_warning_errno(errno, "Failed to set owner of %s to uid=%u, gid=%u: %m", devnode, uid, gid);
+ if (apply_mode || apply_uid || apply_gid || apply_mac) {
+ bool selinux = false, smack = false;
+ const char *name, *label;
+ Iterator i;
+
+ if (apply_mode || apply_uid || apply_gid) {
+ log_device_debug(dev, "Setting permissions %s, uid=" UID_FMT ", gid=" GID_FMT ", mode=%#o",
+ devnode,
+ uid_is_valid(uid) ? uid : stats.st_uid,
+ gid_is_valid(gid) ? gid : stats.st_gid,
+ mode != MODE_INVALID ? mode & 0777 : stats.st_mode & 0777);
+
+ r = chmod_and_chown(devnode, mode, uid, gid);
+ if (r < 0)
+ log_device_warning_errno(dev, r, "Failed to set owner/mode of %s to uid=" UID_FMT ", gid=" GID_FMT ", mode=%#o: %m",
+ devnode,
+ uid_is_valid(uid) ? uid : stats.st_uid,
+ gid_is_valid(gid) ? gid : stats.st_gid,
+ mode != MODE_INVALID ? mode & 0777 : stats.st_mode & 0777);
} else
- log_debug("Preserve permissions of %s, %#o, uid=%u, gid=%u", devnode, mode, uid, gid);
+ log_device_debug(dev, "Preserve permissions of %s, uid=" UID_FMT ", gid=" GID_FMT ", mode=%#o",
+ devnode,
+ uid_is_valid(uid) ? uid : stats.st_uid,
+ gid_is_valid(gid) ? gid : stats.st_gid,
+ mode != MODE_INVALID ? mode & 0777 : stats.st_mode & 0777);
/* apply SECLABEL{$module}=$label */
- udev_list_entry_foreach(entry, udev_list_get_entry(seclabel_list)) {
- const char *name, *label;
+ ORDERED_HASHMAP_FOREACH_KEY(label, name, seclabel_list, i) {
int q;
- name = udev_list_entry_get_name(entry);
- label = udev_list_entry_get_value(entry);
-
if (streq(name, "selinux")) {
selinux = true;
q = mac_selinux_apply(devnode, label);
if (q < 0)
- log_error_errno(q, "SECLABEL: failed to set SELinux label '%s': %m", label);
+ log_device_error_errno(dev, q, "SECLABEL: failed to set SELinux label '%s': %m", label);
else
- log_debug("SECLABEL: set SELinux label '%s'", label);
+ log_device_debug(dev, "SECLABEL: set SELinux label '%s'", label);
} else if (streq(name, "smack")) {
smack = true;
q = mac_smack_apply(devnode, SMACK_ATTR_ACCESS, label);
if (q < 0)
- log_error_errno(q, "SECLABEL: failed to set SMACK label '%s': %m", label);
+ log_device_error_errno(dev, q, "SECLABEL: failed to set SMACK label '%s': %m", label);
else
- log_debug("SECLABEL: set SMACK label '%s'", label);
+ log_device_debug(dev, "SECLABEL: set SMACK label '%s'", label);
} else
- log_error("SECLABEL: unknown subsystem, ignoring '%s'='%s'", name, label);
+ log_device_error(dev, "SECLABEL: unknown subsystem, ignoring '%s'='%s'", name, label);
}
/* set the defaults */
int udev_node_add(sd_device *dev, bool apply,
mode_t mode, uid_t uid, gid_t gid,
- struct udev_list *seclabel_list) {
+ OrderedHashmap *seclabel_list) {
const char *devnode, *devlink;
_cleanup_free_ char *filename = NULL;
int r;
r = sd_device_get_devname(dev, &devnode);
if (r < 0)
- return log_debug_errno(r, "Failed to get devnode: %m");
+ return log_device_debug_errno(dev, r, "Failed to get devnode: %m");
if (DEBUG_LOGGING) {
const char *id_filename = NULL;
(void) device_get_id_filename(dev, &id_filename);
- log_debug("Handling device node '%s', devnum=%s, mode=%#o, uid="UID_FMT", gid="GID_FMT,
- devnode, strnull(id_filename), mode, uid, gid);
+ log_device_debug(dev, "Handling device node '%s', devnum=%s", devnode, strnull(id_filename));
}
r = node_permissions_apply(dev, apply, mode, uid, gid, seclabel_list);
r = xsprintf_dev_num_path_from_sd_device(dev, &filename);
if (r < 0)
- return log_debug_errno(r, "Failed to get device path: %m");
+ return log_device_debug_errno(dev, r, "Failed to get device path: %m");
/* always add /dev/{block,char}/$major:$minor */
(void) node_symlink(dev, devnode, filename);
r = xsprintf_dev_num_path_from_sd_device(dev, &filename);
if (r < 0)
- return log_debug_errno(r, "Failed to get device path: %m");
+ return log_device_debug_errno(dev, r, "Failed to get device path: %m");
/* remove /dev/{block,char}/$major:$minor */
(void) unlink(filename);
projects / thirdparty / systemd.git / blobdiff