]> git.ipfire.org Git - thirdparty/systemd.git/commit - TODO
coredump,catalog: give better notice when a core file is truncated 4225/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 27 Sep 2016 10:40:54 +0000 (12:40 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 28 Sep 2016 21:50:29 +0000 (23:50 +0200)
commit73a99163a721d9e96bf7006ecbfb1aefce228c99
tree4f2f223326259394c5550febfe5662f419f1881c
parent6e9ef6038f3971ae42657b98d952ed4c1318b4d7
coredump,catalog: give better notice when a core file is truncated

coredump had code to check if copy_bytes() hit the max_bytes limit,
and refuse further processing in that case.
But in 84ee0960443, the return convention for copy_bytes() was changed
from -EFBIG to 1 for the case when the limit is hit, so the condition
check in coredump couldn't ever trigger.
But it seems that *do* want to process such truncated cores [1].
So change the code to detect truncation properly, but instead of
returning an error, give a nice log entry.

[1] https://github.com/systemd/systemd/issues/3883#issuecomment-239106337

Should fix (or at least alleviate) #3883.
TODO
catalog/systemd.catalog.in
src/coredump/coredump.c
src/systemd/sd-messages.h