]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/basic/socket-util.c
socket-util: socket_address_parse() should not log errors on its own
authorLennart Poettering <lennart@poettering.net>
Fri, 15 May 2015 18:15:59 +0000 (20:15 +0200)
committerLennart Poettering <lennart@poettering.net>
Fri, 15 May 2015 18:15:59 +0000 (20:15 +0200)
commit7693146dee53a2b0f524e977188347166bf454ca
treeb483b3d9573350fe1fbb92de9193f9542fe7d4f8
parent35b1078e1c375df244e19961792aeb78ca34bb54
socket-util: socket_address_parse() should not log errors on its own

Given that socket_address_parse() is mostly a "library" call it
shouldn't log on its own, but leave that to its caller.

This patch removes logging from the call in case IPv6 is not available
but and IPv6 address shall be parsed. Instead a new call
socket_address_parse_and_warn() is introduced which first invokes
socket_address_parse() and then logs if necessary.

This should fix "make check" on ipv6-less kernels:

http://lists.freedesktop.org/archives/systemd-devel/2015-April/031385.html
src/core/load-fragment.c
src/shared/socket-util.c
src/shared/socket-util.h