]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/firstboot/firstboot.c
tree-wide: be more careful with the type of array sizes
authorLennart Poettering <lennart@poettering.net>
Fri, 27 Apr 2018 12:09:31 +0000 (14:09 +0200)
committerLennart Poettering <lennart@poettering.net>
Fri, 27 Apr 2018 12:29:06 +0000 (14:29 +0200)
commitda6053d0a7c16795e7fac1f9ba6694863918a597
tree0bf9555c57e4770f9ac3c189fbfdddc8265432d7
parent545673d4b0c1bc4d8cdbe4f326442435af86265a
tree-wide: be more careful with the type of array sizes

Previously we were a bit sloppy with the index and size types of arrays,
we'd regularly use unsigned. While I don't think this ever resulted in
real issues I think we should be more careful there and follow a
stricter regime: unless there's a strong reason not to use size_t for
array sizes and indexes, size_t it should be. Any allocations we do
ultimately will use size_t anyway, and converting forth and back between
unsigned and size_t will always be a source of problems.

Note that on 32bit machines "unsigned" and "size_t" are equivalent, and
on 64bit machines our arrays shouldn't grow that large anyway, and if
they do we have a problem, however that kind of overly large allocation
we have protections for usually, but for overflows we do not have that
so much, hence let's add it.

So yeah, it's a story of the current code being already "good enough",
but I think some extra type hygiene is better.

This patch tries to be comprehensive, but it probably isn't and I missed
a few cases. But I guess we can cover that later as we notice it. Among
smaller fixes, this changes:

1. strv_length()' return type becomes size_t

2. the unit file changes array size becomes size_t

3. DNS answer and query array sizes become size_t

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=76745
57 files changed:
src/activate/activate.c
src/basic/calendarspec.c
src/basic/conf-files.c
src/basic/env-util.c
src/basic/env-util.h
src/basic/escape.c
src/basic/fd-util.c
src/basic/fd-util.h
src/basic/io-util.h
src/basic/locale-util.c
src/basic/log.c
src/basic/mempool.c
src/basic/process-util.c
src/basic/process-util.h
src/basic/random-util.c
src/basic/string-util.h
src/basic/strv.c
src/basic/strv.h
src/basic/time-util.c
src/core/dbus-manager.c
src/core/execute.c
src/core/execute.h
src/core/manager.c
src/core/namespace.c
src/core/namespace.h
src/core/service.c
src/core/service.h
src/core/socket.c
src/core/socket.h
src/firstboot/firstboot.c
src/journal/journald-server.c
src/libsystemd-network/network-internal.c
src/libsystemd-network/sd-dhcp-lease.c
src/libsystemd/sd-bus/bus-internal.h
src/libsystemd/sd-bus/bus-message.c
src/libsystemd/sd-bus/bus-message.h
src/libsystemd/sd-login/sd-login.c
src/libsystemd/sd-network/sd-network.c
src/machine/machinectl.c
src/resolve/resolvectl.c
src/resolve/resolved-dns-answer.c
src/resolve/resolved-dns-answer.h
src/resolve/resolved-dns-question.c
src/resolve/resolved-dns-question.h
src/resolve/resolved-mdns.c
src/shared/base-filesystem.c
src/shared/bootspec.c
src/shared/bus-unit-util.c
src/shared/bus-unit-util.h
src/shared/fdset.c
src/shared/fdset.h
src/shared/install.c
src/shared/install.h
src/shared/path-lookup.c
src/systemctl/systemctl.c
src/test/test-install-root.c
src/test/test-install.c