]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/firstboot/firstboot.c
log: minimize includes in log.h
authorLennart Poettering <lennart@poettering.net>
Wed, 10 Jan 2018 23:39:12 +0000 (00:39 +0100)
committerLennart Poettering <lennart@poettering.net>
Thu, 11 Jan 2018 13:44:31 +0000 (14:44 +0100)
commitdccca82b1a28c861a466a0905faee19ee009429a
treee6933b1f4ba8b9cd2c076c98c55e08f5ac72a1db
parent1a86b085138234c9166614adc5ad399a19dae84b
log: minimize includes in log.h

log.h really should only include the bare minimum of other headers, as
it is really pulled into pretty much everything else and already in
itself one of the most basic pieces of code we have.

Let's hence drop inclusion of:

1. sd-id128.h because it's entirely unneeded in current log.h
2. errno.h, dito.
3. sys/signalfd.h which we can replace by a simple struct forward
   declaration
4. process-util.h which was needed for getpid_cached() which we now hide
   in a funciton log_emergency_level() instead, which nicely abstracts
   the details away.
5. sys/socket.h which was needed for struct iovec, but a simple struct
   forward declaration suffices for that too.

Ultimately this actually makes our source tree larger (since users of
the functionality above must now include it themselves, log.h won't do
that for them), but I think it helps to untangle our web of includes a
tiny bit.

(Background: I'd like to isolate the generic bits of src/basic/ enough
so that we can do a git submodule import into casync for it)
82 files changed:
src/basic/af-list.h
src/basic/calendarspec.c
src/basic/errno-list.c
src/basic/ether-addr-util.c
src/basic/fs-util.c
src/basic/gunicode.c
src/basic/hash-funcs.c
src/basic/hostname-util.h
src/basic/journal-importer.c
src/basic/log.c
src/basic/log.h
src/basic/process-util.h
src/basic/random-util.c
src/basic/securebits-util.c
src/basic/socket-util.c
src/basic/stat-util.c
src/basic/time-util.c
src/basic/verbs.c
src/boot/bootctl.c
src/core/dbus.c
src/core/locale-setup.c
src/core/umount.c
src/firstboot/firstboot.c
src/import/export.c
src/import/import-common.c
src/import/import.c
src/import/pull.c
src/initctl/initctl.c
src/journal-remote/journal-remote.c
src/journal-remote/journal-upload.c
src/journal/journald.c
src/journal/sd-journal.c
src/journal/test-compress-benchmark.c
src/libsystemd-network/network-internal.c
src/libsystemd-network/sd-dhcp-server.c
src/libsystemd-network/sd-ipv4ll.c
src/libsystemd-network/test-lldp.c
src/libsystemd/sd-bus/bus-control.c
src/libsystemd/sd-bus/bus-gvariant.c
src/libsystemd/sd-bus/bus-signature.c
src/libsystemd/sd-bus/bus-socket.c
src/libsystemd/sd-bus/bus-type.c
src/libsystemd/sd-bus/bus-type.h
src/libsystemd/sd-bus/sd-bus.c
src/libsystemd/sd-bus/test-bus-track.c
src/libsystemd/sd-daemon/sd-daemon.c
src/libsystemd/sd-event/test-event.c
src/libsystemd/sd-id128/id128-util.c
src/libsystemd/sd-netlink/sd-netlink.c
src/libsystemd/sd-resolve/sd-resolve.c
src/login/logind-core.c
src/login/logind.c
src/network/netdev/tuntap.c
src/network/netdev/veth.c
src/network/netdev/vlan.c
src/nspawn/nspawn-settings.h
src/nspawn/nspawn-setuid.c
src/partition/makefs.c
src/resolve/dns-type.c
src/resolve/test-dns-packet.c
src/shared/bootspec.c
src/shared/dissect-image.c
src/shared/dissect-image.h
src/shared/loop-util.c
src/shared/test-tables.h
src/shared/volatile-util.c
src/test/test-cgroup.c
src/test/test-extract-word.c
src/test/test-hash.c
src/test/test-hexdecoct.c
src/test/test-log.c
src/test/test-ns.c
src/test/test-parse-util.c
src/test/test-signal-util.c
src/test/test-sizeof.c
src/test/test-socket-util.c
src/test/test-tmpfiles.c
src/test/test-util.c
src/test/test-watchdog.c
src/udev/udevadm-control.c
src/veritysetup/veritysetup-generator.c
src/veritysetup/veritysetup.c