]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/login/logind-session.c
logind: avoid creating stale session state files
authorFedora systemd team <systemd-maint@redhat.com>
Wed, 10 Apr 2013 07:49:24 +0000 (09:49 +0200)
committerMichal Schmidt <mschmidt@redhat.com>
Wed, 10 Apr 2013 09:36:59 +0000 (11:36 +0200)
commit50fb97935d689a520251b2d543599be14bdfd0ed
tree11e5fa30d1d35461fb1ddc37fd2c587784487705
parentb8b4d3dddc7611dce3bf28004b0375d661120c62
logind: avoid creating stale session state files

There were old session state files accumulating in /run/systemd/session.
They confused e.g. "reboot", which thought there were still users logged
in. The files got created like this:

session_stop(Session *s) ->
        ...
        unlink(s->state_file);
        ...
        seat_set_active(s->seat, NULL) ->
                session_save(...);  /* re-creates the state file we just
                                       unlinked */

Fix it simply by clearing the s->started flag earlier to prevent
any further writes of the state file (session_save() checks the flag).
src/login/logind-session.c