]> git.ipfire.org Git - thirdparty/systemd.git/commit - src/resolve/resolved-dns-scope.h
dns-domain: simplify dns_name_is_root() and dns_name_is_single_label()
authorLennart Poettering <lennart@poettering.net>
Wed, 25 Nov 2015 20:07:17 +0000 (21:07 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 25 Nov 2015 21:00:07 +0000 (22:00 +0100)
commitdc477e7385e8ab29efb8fadb72ec994077a105c6
tree04590e41525b1b60c969cd8c3cc5be9a90fe271e
parent801ad6a6a9cd8fbd58b9f9c27f20dbb3c87d47dd
dns-domain: simplify dns_name_is_root() and dns_name_is_single_label()

Let's change the return value to bool. If we encounter an error while
parsing, return "false" instead of the actual parsing error, after all
the specified hostname does not qualify for what the function is
supposed to test.

Dealing with the additional error codes was always cumbersome, and
easily misused, like for example in the DHCP code.

Let's also rename the functions from dns_name_root() to
dns_name_is_root(), to indicate that this function checks something and
returns a bool. Similar for dns_name_is_signal_label().
src/libsystemd-network/sd-dhcp-client.c
src/resolve/resolved-dns-rr.c
src/resolve/resolved-dns-scope.c
src/resolve/resolved-dns-scope.h
src/resolve/resolved-dns-search-domain.c
src/shared/dns-domain.c
src/shared/dns-domain.h
src/test/test-dns-domain.c