]> git.ipfire.org Git - thirdparty/systemd.git/commit
Revert "tree-wide: use pid_is_valid() at more places"
authorAlan Jenkins <alan.christopher.jenkins@gmail.com>
Tue, 3 Oct 2017 11:05:24 +0000 (12:05 +0100)
committerAlan Jenkins <alan.christopher.jenkins@gmail.com>
Tue, 3 Oct 2017 11:43:24 +0000 (12:43 +0100)
commit07b38ba51e1b84c560cb745f93c1d3bb91d1d066
tree080cf99c8120360d2bc7a99906e3247d599a4384
parentb139c95bc42dd67e4b8f804fd8f3e248e5127600
Revert "tree-wide: use pid_is_valid() at more places"

This reverts commit ee043777be58251e7441b4f04594e9e3792d7fb2.

It broke almost everywhere it touched.  The places that
handn't been converted, were mostly followed by special
handling for the invalid PID `0`.  That explains why they
tested for `pid < 0` instead of `pid <= 0`.

I think that one was the first commit I reviewed, heh.
src/basic/process-util.c
src/core/dbus-manager.c
src/login/logind-dbus.c
src/machine/machined-dbus.c
src/systemctl/systemctl.c