]> git.ipfire.org Git - thirdparty/systemd.git/commit
core: still make progress when throttling the manager loop 1783/head
authorVito Caputo <vito.caputo@coreos.com>
Thu, 5 Nov 2015 01:32:16 +0000 (17:32 -0800)
committerVito Caputo <vito.caputo@coreos.com>
Thu, 5 Nov 2015 01:32:16 +0000 (17:32 -0800)
commitad231c7787f6f74c10b81faf7a6896f2c214a3ee
treecdf5ebf34466bc411f542993ce32f432779f7aa0
parenta6bff4a7428b9539d85618e3c91fcb60be93f3fa
core: still make progress when throttling the manager loop

Don't simply continue after sleeping, it potentially puts us in a state
of spinning doing nothing slowly, if the ratelimit_test() keeps
detecting the need for limiting.

Observed in vms after the host had been suspended for a while, on resume
systemd entered a loop of making zero progress spamming the console
with:
[431942.850090] systemd[1]: Looping too fast. Throttling execution a
little.

I see no reason to have a continue here, the intention should be to
throttle execution, not circumvent it altogether.
src/core/manager.c