journal-cat: don't allocate memory for the syslog identifier

Fixes: #2490

diff --git a/src/journal/cat.c b/src/journal/cat.c
index 7fd4198df88b16efb46a0f24e59c8ba7a89fd599..07c3df522cb6ebe093e28496b2c94e81fe9516e2 100644 (file)
--- a/src/journal/cat.c
+++ b/src/journal/cat.c
@@ -34,7 +34,7 @@
 #include "syslog-util.h"
 #include "util.h"
 
-static char *arg_identifier = NULL;
+static const char *arg_identifier = NULL;
 static int arg_priority = LOG_INFO;
 static bool arg_level_prefix = true;
 
@@ -82,14 +82,10 @@ static int parse_argv(int argc, char *argv[]) {
                         return version();
 
                 case 't':
-                        free(arg_identifier);
                         if (isempty(optarg))
                                 arg_identifier = NULL;
-                        else {
-                                arg_identifier = strdup(optarg);
-                                if (!arg_identifier)
-                                        return log_oom();
-                        }
+                        else
+                                arg_identifier = optarg;
                         break;
 
                 case 'p':