]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: bump the TEST-47 sleeps once again
authorFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 8 Jul 2020 12:42:43 +0000 (14:42 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 8 Jul 2020 20:09:55 +0000 (22:09 +0200)
Several recent failed runs show that the test is still racy in two ways:

1) Sometimes it takes a while before the PID file is created, leading
   to:

```
[   10.950540] testsuite-47.sh[308]: ++ cat /leakedtestpid
[   10.959712] testsuite-47.sh[308]: cat: /leakedtestpid: No such file or directory
[   10.959824] testsuite-47.sh[298]: + leaked_pid=
```

2) Again, sometimes we check the leaked PID before the unit is actually
   stopped, leading to a false negative:

```
[   18.099599] testsuite-47.sh[346]: ++ cat /leakedtestpid
[   18.116462] testsuite-47.sh[333]: + leaked_pid=342
[   18.117101] testsuite-47.sh[333]: + systemctl stop testsuite-47-repro
...
[   20.033907] testsuite-47.sh[333]: + ps -p 342
[   20.080050] testsuite-47.sh[351]:     PID TTY          TIME CMD
[   20.080050] testsuite-47.sh[351]:     342 ?        00:00:00 sleep
[   20.082040] testsuite-47.sh[333]: + exit 42
```

test/units/testsuite-47.sh

index 97f86140f11832b28d89ca9051c21d15732b9490..50034cf3d9a5e9af2c6ccfd1cfbcf60a79d21ebc 100755 (executable)
@@ -6,13 +6,13 @@ systemd-analyze log-level debug
 systemd-analyze log-target console
 
 systemctl start testsuite-47-repro
-sleep 1
+sleep 4
 systemctl status testsuite-47-repro
 
 leaked_pid=$(cat /leakedtestpid)
 
 systemctl stop testsuite-47-repro
-sleep 1
+sleep 4
 
 # Leaked PID will still be around if we're buggy.
 # I personally prefer to see 42.