]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
networkd: Use NLM_F_ACK on the netlink message to add a neighbor.
authorYmrDtnJu <YmrDtnJu@users.noreply.github.com>
Sun, 19 Jul 2020 15:04:46 +0000 (17:04 +0200)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 20 Jul 2020 02:30:35 +0000 (11:30 +0900)
sd_netlink_message_set_flags is called without NLM_F_ACK which results in
a timeout while networkd is waiting for an ACK that the kernel will never send.

src/network/networkd-neighbor.c

index 1c901138564dd39d9960069e56c8fd7db2a98bc5..0e97b225c4547ddff63dd5e2864db39a26767fe7 100644 (file)
@@ -132,7 +132,7 @@ int neighbor_configure(Neighbor *neighbor, Link *link, link_netlink_message_hand
         if (r < 0)
                 return log_link_error_errno(link, r, "Could not set state: %m");
 
-        r = sd_netlink_message_set_flags(req, NLM_F_REQUEST | NLM_F_CREATE | NLM_F_REPLACE);
+        r = sd_netlink_message_set_flags(req, NLM_F_REQUEST | NLM_F_ACK | NLM_F_CREATE | NLM_F_REPLACE);
         if (r < 0)
                 return log_link_error_errno(link, r, "Could not set flags: %m");