]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
core: initalize buffer 7738/head
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sat, 20 Jan 2018 00:06:34 +0000 (11:06 +1100)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 25 Jan 2018 15:59:23 +0000 (00:59 +0900)
src/core/manager.c

index 25933cc889bf3d029e915deb37ffe89c7ea6e2d0..bed52aa42e253f2a24e7b33f17bbd884b8bfe435 100644 (file)
@@ -3209,9 +3209,10 @@ static void manager_notify_finished(Manager *m) {
 
         if (MANAGER_IS_SYSTEM(m) && detect_container() <= 0) {
                 char ts[FORMAT_TIMESPAN_MAX];
-                char buf[FORMAT_TIMESPAN_MAX + STRLEN(" (firmware) + ") + FORMAT_TIMESPAN_MAX + STRLEN(" (loader) + ")];
-                char *p;
-                size_t size;
+                char buf[FORMAT_TIMESPAN_MAX + STRLEN(" (firmware) + ") + FORMAT_TIMESPAN_MAX + STRLEN(" (loader) + ")]
+                        = {};
+                char *p = buf;
+                size_t size = sizeof buf;
 
                 /* Note that MANAGER_TIMESTAMP_KERNEL's monotonic value is always at 0, and
                  * MANAGER_TIMESTAMP_FIRMWARE's and MANAGER_TIMESTAMP_LOADER's monotonic value should be considered
@@ -3222,9 +3223,6 @@ static void manager_notify_finished(Manager *m) {
                 userspace_usec = m->timestamps[MANAGER_TIMESTAMP_FINISH].monotonic - m->timestamps[MANAGER_TIMESTAMP_USERSPACE].monotonic;
                 total_usec = m->timestamps[MANAGER_TIMESTAMP_FIRMWARE].monotonic + m->timestamps[MANAGER_TIMESTAMP_FINISH].monotonic;
 
-                p = buf;
-                size = sizeof(buf);
-
                 if (firmware_usec > 0)
                         size = strpcpyf(&p, size, "%s (firmware) + ", format_timespan(ts, sizeof(ts), firmware_usec, USEC_PER_MSEC));
                 if (loader_usec > 0)