From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 20 Jun 2018 20:22:03 +0000 (+0200)
Subject: analyze: use log_unit_error_errno()'s return value where we can
X-Git-Tag: v239~10^2~2
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fsystemd.git;a=commitdiff_plain;h=4d2a7ffd5ba47da26dde13a537fd0d3adc6e126e

analyze: use log_unit_error_errno()'s return value where we can
---

diff --git a/src/analyze/analyze-verify.c b/src/analyze/analyze-verify.c
index 1f33e560acf..7f606ee24b9 100644
--- a/src/analyze/analyze-verify.c
+++ b/src/analyze/analyze-verify.c
@@ -108,10 +108,8 @@ static int verify_socket(Unit *u) {
 
         /* This makes sure instance is created if necessary. */
         r = socket_instantiate_service(SOCKET(u));
-        if (r < 0) {
-                log_unit_error_errno(u, r, "Socket cannot be started, failed to create instance: %m");
-                return r;
-        }
+        if (r < 0)
+                return log_unit_error_errno(u, r, "Socket cannot be started, failed to create instance: %m");
 
         /* This checks both type of sockets */
         if (UNIT_ISSET(SOCKET(u)->service)) {