From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 30 May 2019 18:36:54 +0000 (+0200)
Subject: shared/varlink: add missing va_end()
X-Git-Tag: v243-rc1~335^2~3
X-Git-Url: http://git.ipfire.org/?p=thirdparty%2Fsystemd.git;a=commitdiff_plain;h=e7b93f97ed65878772132bf16f33720cdddfb51d

shared/varlink: add missing va_end()

Coverity CID#1401347.
---

diff --git a/src/shared/varlink.c b/src/shared/varlink.c
index 48e18b09870..dea8e4363f2 100644
--- a/src/shared/varlink.c
+++ b/src/shared/varlink.c
@@ -2304,7 +2304,7 @@ int varlink_server_bind_method(VarlinkServer *s, const char *method, VarlinkMeth
 
 int varlink_server_bind_method_many_internal(VarlinkServer *s, ...) {
         va_list ap;
-        int r;
+        int r = 0;
 
         assert_return(s, -EINVAL);
 
@@ -2321,10 +2321,11 @@ int varlink_server_bind_method_many_internal(VarlinkServer *s, ...) {
 
                 r = varlink_server_bind_method(s, method, callback);
                 if (r < 0)
-                        return r;
+                        break;
         }
+        va_end(ap);
 
-        return 0;
+        return r;
 }
 
 int varlink_server_bind_connect(VarlinkServer *s, VarlinkConnect callback) {