]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
5 years agotravis: make the directory with coverity tools available in a container
Evgeny Vereshchagin [Wed, 7 Nov 2018 03:36:57 +0000 (04:36 +0100)] 
travis: make the directory with coverity tools available in a container

Otherwise `coverity.sh build` will fail with
```
find: '/var/tmp/coverity-scan-analysis': No such file or directory
```

See https://travis-ci.org/systemd/systemd/jobs/451683385.

5 years agohwdb: IdeaPad Miix 310 with another bios version (#10661)
imayoda [Wed, 7 Nov 2018 03:59:24 +0000 (04:59 +0100)] 
hwdb: IdeaPad Miix 310 with another bios version (#10661)

another bios version for same model with portrait screen.

5 years agoMerge pull request #10644 from mrc0mmand/travis-fix
Evgeny Vereshchagin [Wed, 7 Nov 2018 02:11:02 +0000 (05:11 +0300)] 
Merge pull request #10644 from mrc0mmand/travis-fix

Fix & re-enable Travis CI

5 years agotravis: overwrite test-capability with a simple script that is just skipped 10644/head
Evgeny Vereshchagin [Wed, 7 Nov 2018 01:25:52 +0000 (02:25 +0100)] 
travis: overwrite test-capability with a simple script that is just skipped

so that it will be possible to work on the test failure and try to make
Travis CI work at the same time.

5 years agoMerge pull request #10640 from evverx/networkd-fuzzers
Yu Watanabe [Tue, 6 Nov 2018 23:50:25 +0000 (08:50 +0900)] 
Merge pull request #10640 from evverx/networkd-fuzzers

Add a couple of fuzzers for network_load_one and netdev_load_one

5 years agotravis: workaround for dnf upgrade
Frantisek Sumsal [Tue, 6 Nov 2018 19:55:07 +0000 (20:55 +0100)] 
travis: workaround for dnf upgrade

dnf upgrade on Fedora Rawhide pulls in unwanted selinux-policy
packages which breaks the system in several ways (and usually
ends up with crashed systemd)

5 years agooss-fuzz.sh: copy dictionaries along with "options" files 10640/head
Evgeny Vereshchagin [Tue, 6 Nov 2018 18:51:45 +0000 (19:51 +0100)] 
oss-fuzz.sh: copy dictionaries along with "options" files

We currently don't have any upstream but it doesn't mean that
it should be impossible to experiment with local ones :-)

5 years agotests: add a couple of files containing all the sections and directives
Evgeny Vereshchagin [Tue, 6 Nov 2018 18:42:29 +0000 (19:42 +0100)] 
tests: add a couple of files containing all the sections and directives

This should help the fuzzers to discover code paths faster.

In case anyone is interested, they were generated with the following script
```
perl -aF'/[\s,]+/' -ne '
if (my ($s, $d) = ($F[0] =~ /^([^\s\.]+)\.([^\s\.]+)$/)) { $d{$s}{$d} = 1; }
END { while (my ($key, $value) = each %d) {
    printf "[%s]\n%s\n", $key, join("\n", keys(%$value))
}}'
```
by passing src/network/networkd-network-gperf.gperf and
src/network/netdev/netdev-gperf.gperf to it.

5 years agotests: replace AdActorSysPrio with AdActorSystemPriority
Evgeny Vereshchagin [Tue, 6 Nov 2018 18:36:40 +0000 (19:36 +0100)] 
tests: replace AdActorSysPrio with AdActorSystemPriority

This is a follow-up to https://github.com/systemd/systemd/pull/10653.

5 years agotests: add a reporoducer for https://github.com/systemd/systemd/issues/10639
Evgeny Vereshchagin [Sun, 4 Nov 2018 23:39:47 +0000 (00:39 +0100)] 
tests: add a reporoducer for https://github.com/systemd/systemd/issues/10639

5 years agotests: add some data that can be fed to fuzz-network-parser
Evgeny Vereshchagin [Sun, 4 Nov 2018 22:04:43 +0000 (23:04 +0100)] 
tests: add some data that can be fed to fuzz-network-parser

5 years agotests: add a reproducer for https://github.com/systemd/systemd/issues/10629
Evgeny Vereshchagin [Sun, 4 Nov 2018 22:01:46 +0000 (23:01 +0100)] 
tests: add a reproducer for https://github.com/systemd/systemd/issues/10629

5 years agonetworkd: make network_load_one "public" and add a fuzzer for it
Evgeny Vereshchagin [Sun, 4 Nov 2018 21:27:07 +0000 (22:27 +0100)] 
networkd: make network_load_one "public" and add a fuzzer for it

5 years agonetworkd: make netdev_load_one "public" and add a fuzzer for it
Evgeny Vereshchagin [Sun, 4 Nov 2018 21:06:03 +0000 (22:06 +0100)] 
networkd: make netdev_load_one "public" and add a fuzzer for it

5 years agonetworkd: remove a weird assertion from network_load_one
Evgeny Vereshchagin [Sun, 4 Nov 2018 20:49:09 +0000 (21:49 +0100)] 
networkd: remove a weird assertion from network_load_one

The assertion was added in dbffab87f1504abc9f but I'm not exactly sure
why. Now it just crashes a fuzzer I wrote. I, of course, could fix the fuzzer
so that it would generate names ending in ".network" if anyone would tell
me why the assertion should be kept here.

5 years agoutil: initialize _argtypes in VA_FORMAT_ADVANCE when systemd is built with MSan
Evgeny Vereshchagin [Sun, 4 Nov 2018 20:43:08 +0000 (21:43 +0100)] 
util: initialize _argtypes in VA_FORMAT_ADVANCE when systemd is built with MSan

This gets around https://github.com/google/sanitizers/issues/992.

5 years agoMerge pull request #10654 from poettering/srand-rdrand
Yu Watanabe [Tue, 6 Nov 2018 17:03:09 +0000 (02:03 +0900)] 
Merge pull request #10654 from poettering/srand-rdrand

random-util.c mini-fixes

5 years agologin: Don't mark framebuffer devices as master-of-seat devices
Marco Trevisan (Treviño) [Thu, 1 Nov 2018 02:04:50 +0000 (03:04 +0100)] 
login: Don't mark framebuffer devices as master-of-seat devices

Currently we consider any framebuffer device as enough to have a
valid graphical session, but this might lead to many false postives
like in the case of framebuffer devices that have a linked drm card
which is still in the process of being added, or for vesa fb, and
so it doesn't ensure us that we can have a proper graphical session.

Since these days we normally don't consider anything without a DRM
card able to provide a full graphical session, let's not set this
at this level.
Drivers which can provide a graphical session with the sole fb are
still free to mark any device as `master-of-seat`

Fixes #10435

5 years agoMerge pull request #10658 from yuwata/udevd-worker-performance
Lennart Poettering [Tue, 6 Nov 2018 17:01:37 +0000 (20:01 +0300)] 
Merge pull request #10658 from yuwata/udevd-worker-performance

udev: improve performance

5 years agoMerge pull request #10602 from yuwata/sd-device-logs
Lennart Poettering [Tue, 6 Nov 2018 16:33:51 +0000 (19:33 +0300)] 
Merge pull request #10602 from yuwata/sd-device-logs

update log messages

5 years agoMerge pull request #10633 from yuwata/sd-resolve-destroy
Lennart Poettering [Tue, 6 Nov 2018 16:30:59 +0000 (19:30 +0300)] 
Merge pull request #10633 from yuwata/sd-resolve-destroy

Another solution to fix wireguard issues

5 years agotime-util: make parse_sec() not accept "12.34.56"
Yu Watanabe [Tue, 6 Nov 2018 03:36:54 +0000 (12:36 +0900)] 
time-util: make parse_sec() not accept "12.34.56"

This also changes the rational number treatment.
So, the limitations introduced by 8079c90333422bbc008b68a9b7cefbdb8a15a4e9
and f6a178e91dd5fccf43f659eca887788fd5dcdccf are relaxed.

Fixes #10619.

5 years agotravis: drop the unnecessary /etc/machine-id magic
Frantisek Sumsal [Tue, 6 Nov 2018 16:16:45 +0000 (17:16 +0100)] 
travis: drop the unnecessary /etc/machine-id magic

5 years agotravis: run Coverity on a more stable Fedora release
Frantisek Sumsal [Tue, 6 Nov 2018 14:59:34 +0000 (15:59 +0100)] 
travis: run Coverity on a more stable Fedora release

5 years agoudevd: increase default number of workers 10658/head
Yu Watanabe [Thu, 1 Nov 2018 07:54:10 +0000 (16:54 +0900)] 
udevd: increase default number of workers

The uevent handling in udevd is not cpu hungry.
So, let's increase the default number of workers per cpu.
This decrease the number of queued uevents.

Without this commit (children_max is 16 on my laptop)
```
$ journalctl -b -u systemd-udevd.service | grep reached | wc -l
1544
```
With this commit (children_max is 30 on my laptop)
```
$ journalctl -b -u systemd-udevd.service | grep reached | wc -l
7
```

5 years agoudevd: wait 3 seconds before killing worker processes
Yu Watanabe [Thu, 1 Nov 2018 01:37:51 +0000 (10:37 +0900)] 
udevd: wait 3 seconds before killing worker processes

During boot process, many worker processes are forked and killed.
To decrease cycles of forking and killing worker, let's wait
3 seconds before killing workers. If new uevent or inotify event
comes within the delay, the killing porcess will be cancelled.

5 years agotravis: move Docker setup to a separate script
Frantisek Sumsal [Tue, 6 Nov 2018 08:04:10 +0000 (09:04 +0100)] 
travis: move Docker setup to a separate script

This should make debugging somewhat easier

5 years agoudevd: drop redundant logic of receiving uevent
Yu Watanabe [Tue, 6 Nov 2018 08:46:00 +0000 (17:46 +0900)] 
udevd: drop redundant logic of receiving uevent

If there exists pending uevents, then sd-event invokes uevent handler.
So, it is not necessary to receive the next uevent in inotify event.

5 years agoudevd: decrease indentation
Yu Watanabe [Tue, 6 Nov 2018 06:58:41 +0000 (15:58 +0900)] 
udevd: decrease indentation

5 years agoMerge pull request #10597 from toanju/fix-networkd-l3-loss
Lennart Poettering [Tue, 6 Nov 2018 14:44:24 +0000 (17:44 +0300)] 
Merge pull request #10597 from toanju/fix-networkd-l3-loss

networkd: don't remove ip address or route

5 years agoudevd: merge conditions to decrease indentation
Yu Watanabe [Tue, 6 Nov 2018 06:55:09 +0000 (15:55 +0900)] 
udevd: merge conditions to decrease indentation

5 years agoMerge pull request #10650 from yuwata/udevadm-trigger-use-write-string-file
Lennart Poettering [Tue, 6 Nov 2018 13:46:25 +0000 (16:46 +0300)] 
Merge pull request #10650 from yuwata/udevadm-trigger-use-write-string-file

udevadm: use write_string_file() helper function

5 years agonetworkd: cleanup for #10542
Tobias Jungel [Tue, 6 Nov 2018 08:55:35 +0000 (09:55 +0100)] 
networkd: cleanup for #10542

fixes: 53b1f7d

5 years agoMerge pull request #10652 from yuwata/lldp-ndisc-string-table
Lennart Poettering [Tue, 6 Nov 2018 13:41:48 +0000 (16:41 +0300)] 
Merge pull request #10652 from yuwata/lldp-ndisc-string-table

lldp,ndisc: update debug logs

5 years agocore, sysctl: skip ENOENT for /proc/sys/net/unix/max_dgram_qlen
Giuseppe Scrivano [Mon, 5 Nov 2018 22:06:14 +0000 (23:06 +0100)] 
core, sysctl: skip ENOENT for /proc/sys/net/unix/max_dgram_qlen

sysctl is disabled for /proc mounted from an user namespace thus entries like
/proc/sys/net/unix/max_dgram_qlen do not exist.  In this case, skip the error
and do not try to change the default for the AF_UNIX datagram queue length.

5 years agoask-password: fix minor memory leak on error path
Lennart Poettering [Tue, 6 Nov 2018 11:34:01 +0000 (12:34 +0100)] 
ask-password: fix minor memory leak on error path

CID 1396557

5 years agonetworkd: don't remove route 10597/head
Tobias Jungel [Tue, 6 Nov 2018 12:28:12 +0000 (13:28 +0100)] 
networkd: don't remove route

In case networkd is restarted this prevents a removal of an already existing
route that would be configured using networkd. With the proposed changes the
route will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.

5 years agonetworkd: don't remove ip address
Tobias Jungel [Wed, 31 Oct 2018 12:33:54 +0000 (13:33 +0100)] 
networkd: don't remove ip address

In case networkd is restarted this prevents a removal of an already existing IP
address that would be configured using networkd. With the proposed changes the
IP address will be kept on the interface without removing. This happens only on
physical hosts or VMs since networkd handles interface configuration slightly
different in containers.

5 years agosd-device: use write_string_file() helper to write sysattr 10650/head
Yu Watanabe [Tue, 6 Nov 2018 12:23:52 +0000 (21:23 +0900)] 
sd-device: use write_string_file() helper to write sysattr

5 years agofileio: introduce WRITE_STRING_FILE_NOFOLLOW flag for write_string_file() and friends
Yu Watanabe [Tue, 6 Nov 2018 12:23:03 +0000 (21:23 +0900)] 
fileio: introduce WRITE_STRING_FILE_NOFOLLOW flag for write_string_file() and friends

5 years agotree-wide: set WRITE_STRING_FILE_DISABLE_BUFFER flag when we write files under /proc...
Yu Watanabe [Tue, 6 Nov 2018 12:00:07 +0000 (21:00 +0900)] 
tree-wide: set WRITE_STRING_FILE_DISABLE_BUFFER flag when we write files under /proc or /sys

5 years agoudevd: use set_oom_score_adjust() to set OOM score
Yu Watanabe [Tue, 6 Nov 2018 11:28:25 +0000 (20:28 +0900)] 
udevd: use set_oom_score_adjust() to set OOM score

5 years agoudevadm: use write_string_file() helper function
Yu Watanabe [Tue, 6 Nov 2018 03:58:29 +0000 (12:58 +0900)] 
udevadm: use write_string_file() helper function

5 years agotest: add tests for string tables for lldp and ndisc events 10652/head
Yu Watanabe [Tue, 6 Nov 2018 05:15:33 +0000 (14:15 +0900)] 
test: add tests for string tables for lldp and ndisc events

5 years agondisc: improve debug log message
Yu Watanabe [Tue, 6 Nov 2018 05:07:19 +0000 (14:07 +0900)] 
ndisc: improve debug log message

5 years agolldp: improve debug log message
Yu Watanabe [Tue, 6 Nov 2018 04:59:48 +0000 (13:59 +0900)] 
lldp: improve debug log message

5 years agorandom-util: initialize srand() from RDRAND 10654/head
Lennart Poettering [Tue, 6 Nov 2018 11:08:26 +0000 (12:08 +0100)] 
random-util: initialize srand() from RDRAND

It's cheap to get RDRAND and given that srand() is anyway not really
useful for trusted randomness let's use RDRAND for it, after all we have
all the hard work for that already in place.

5 years agorandom-util: we don't intend to write to auxv, hence make it const
Lennart Poettering [Tue, 6 Nov 2018 11:08:07 +0000 (12:08 +0100)] 
random-util: we don't intend to write to auxv, hence make it const

5 years agoMerge pull request #10611 from yuwata/udev-watch-log
Lennart Poettering [Tue, 6 Nov 2018 09:28:00 +0000 (12:28 +0300)] 
Merge pull request #10611 from yuwata/udev-watch-log

udev-watch: update log levels and messages

5 years agoudev-node: add one more debug log when failed to create symlink 10602/head
Yu Watanabe [Tue, 30 Oct 2018 04:29:44 +0000 (13:29 +0900)] 
udev-node: add one more debug log when failed to create symlink

5 years agoudev-node: drop redundant log message
Yu Watanabe [Tue, 30 Oct 2018 04:24:57 +0000 (13:24 +0900)] 
udev-node: drop redundant log message

As node_symlink() logs almost same message.

5 years agoudev: setting the same log level to SYSTEMD realm
Yu Watanabe [Fri, 26 Oct 2018 00:45:35 +0000 (09:45 +0900)] 
udev: setting the same log level to SYSTEMD realm

Otherwise, many debug logs from libsystemd are dropped.

5 years agotest: check returned value of sd_device_get_usec_since_initialized()
Yu Watanabe [Wed, 31 Oct 2018 05:47:50 +0000 (14:47 +0900)] 
test: check returned value of sd_device_get_usec_since_initialized()

5 years agotest: show is_initialized flag in log message of test-sd-device
Yu Watanabe [Wed, 31 Oct 2018 01:01:45 +0000 (10:01 +0900)] 
test: show is_initialized flag in log message of test-sd-device

And drop devpath, as it is redundant for most cases.

5 years agotest: show name of testing functions in test-sd-device
Yu Watanabe [Wed, 31 Oct 2018 01:01:11 +0000 (10:01 +0900)] 
test: show name of testing functions in test-sd-device

5 years agosd-device: normalize debug messages
Yu Watanabe [Thu, 1 Nov 2018 07:15:50 +0000 (16:15 +0900)] 
sd-device: normalize debug messages

5 years agosd-device: drop subsystem from log_device_*()
Yu Watanabe [Thu, 1 Nov 2018 07:12:46 +0000 (16:12 +0900)] 
sd-device: drop subsystem from log_device_*()

The sd_device object always has syspath and sysname, but subsytem may not.
Also, it may take some costs to get subsystem.
So, let's drop subsystem from logs.

5 years agoudev-watch: adjust level of log messages 10611/head
Yu Watanabe [Fri, 26 Oct 2018 23:24:25 +0000 (08:24 +0900)] 
udev-watch: adjust level of log messages

5 years agoudev-watch: make udev_watch_lookup() return 1 when device found
Yu Watanabe [Fri, 26 Oct 2018 23:19:51 +0000 (08:19 +0900)] 
udev-watch: make udev_watch_lookup() return 1 when device found

5 years agoudev: drop redundant log message and fix returned error code
Yu Watanabe [Fri, 26 Oct 2018 23:06:40 +0000 (08:06 +0900)] 
udev: drop redundant log message and fix returned error code

5 years agotravis: rewrite .travis.yml and re-enable Travis CI for Fedora
Frantisek Sumsal [Sun, 4 Nov 2018 17:23:30 +0000 (18:23 +0100)] 
travis: rewrite .travis.yml and re-enable Travis CI for Fedora

5 years agoMerge pull request #10606 from yuwata/udev-tests
Lennart Poettering [Mon, 5 Nov 2018 20:14:42 +0000 (23:14 +0300)] 
Merge pull request #10606 from yuwata/udev-tests

test: mask hwdb-update.services in most tests

5 years agoMerge pull request #10618 from yuwata/fix-10615
Lennart Poettering [Mon, 5 Nov 2018 14:37:25 +0000 (17:37 +0300)] 
Merge pull request #10618 from yuwata/fix-10615

network: fix several issues in config parser

5 years agoMerge pull request #10641 from yuwata/fix-10639
Lennart Poettering [Mon, 5 Nov 2018 13:11:50 +0000 (16:11 +0300)] 
Merge pull request #10641 from yuwata/fix-10639

network: check the value of prefix length

5 years agotest: add tests for config_parse_address() 10641/head
Yu Watanabe [Mon, 5 Nov 2018 06:38:46 +0000 (15:38 +0900)] 
test: add tests for config_parse_address()

5 years agonetwork: use in_addr_default_prefix_from_string_auto() in config_parse_address()
Yu Watanabe [Mon, 5 Nov 2018 07:21:38 +0000 (16:21 +0900)] 
network: use in_addr_default_prefix_from_string_auto() in config_parse_address()

5 years agotest: add tests for in_addr_default_prefix_from_string() or friend
Yu Watanabe [Mon, 5 Nov 2018 07:20:08 +0000 (16:20 +0900)] 
test: add tests for in_addr_default_prefix_from_string() or friend

5 years agoutil: introduce in_addr_default_prefix_from_string() and friends
Yu Watanabe [Mon, 5 Nov 2018 07:18:17 +0000 (16:18 +0900)] 
util: introduce in_addr_default_prefix_from_string() and friends

It is similar to in_addr_prefix_from_string() but it determines
the prefix length from address if it is not specified.

5 years agoutil: use strndup() instead of strndupa()
Yu Watanabe [Mon, 5 Nov 2018 06:55:45 +0000 (15:55 +0900)] 
util: use strndup() instead of strndupa()

As the input string may be comes from command line or config files.

5 years agonetwork: sort headers in wireguard.h 10633/head
Yu Watanabe [Sat, 3 Nov 2018 18:19:57 +0000 (03:19 +0900)] 
network: sort headers in wireguard.h

5 years agonetwork: use structured initializers in wireguard.c
Yu Watanabe [Sat, 3 Nov 2018 12:57:06 +0000 (21:57 +0900)] 
network: use structured initializers in wireguard.c

5 years agonetwork: fix crash in wireguard_done()
Yu Watanabe [Sat, 3 Nov 2018 07:45:17 +0000 (16:45 +0900)] 
network: fix crash in wireguard_done()

Fixes another issue in #10629.

5 years agonetwork: use destroy callback to unref netdev attached to event source
Yu Watanabe [Sat, 3 Nov 2018 16:59:46 +0000 (01:59 +0900)] 
network: use destroy callback to unref netdev attached to event source

5 years agonetwork: use destroy callback to clear resolved wireguard endpoints
Yu Watanabe [Sun, 4 Nov 2018 11:42:14 +0000 (20:42 +0900)] 
network: use destroy callback to clear resolved wireguard endpoints

5 years agonetwork: link_drop() and netdev_drop() remove reference from manager
Yu Watanabe [Sun, 4 Nov 2018 11:36:13 +0000 (20:36 +0900)] 
network: link_drop() and netdev_drop() remove reference from manager

5 years agosd-event: add sd_event_source_{get,set}_floating()
Yu Watanabe [Sat, 3 Nov 2018 16:55:28 +0000 (01:55 +0900)] 
sd-event: add sd_event_source_{get,set}_floating()

5 years agosd-resolve: introduce sd_resolve_query_{get,set}_floating()
Yu Watanabe [Sat, 3 Nov 2018 16:05:16 +0000 (01:05 +0900)] 
sd-resolve: introduce sd_resolve_query_{get,set}_floating()

5 years agosd-resolve: introduce sd_resolve_query_{get,set}_destroy_callback()
Yu Watanabe [Sat, 3 Nov 2018 15:56:58 +0000 (00:56 +0900)] 
sd-resolve: introduce sd_resolve_query_{get,set}_destroy_callback()

5 years agotests: also use lsmod to check whether modules are available (#10634)
Evgeny Vereshchagin [Mon, 5 Nov 2018 03:47:38 +0000 (06:47 +0300)] 
tests: also use lsmod to check whether modules are available (#10634)

It's not entirely impossible to screw something up playing with
kernel modules on a Saturday evening :-) This PR fixes a scenario
where a module has been loaded into the kernel but the module itself
has been removed from the disk.

```
$ lsmod | grep wireg
wireguard             225280  0
ip6_udp_tunnel         16384  1 wireguard
udp_tunnel             16384  1 wireguard

$ modprobe wireguard
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64

$ sudo ./systemd-networkd-tests.py NetworkdNetDevTests.test_wireguard
...
modprobe: FATAL: Module wireguard not found in directory /lib/modules/4.18.16-200.fc28.x86_64
test_wireguard (__main__.NetworkdNetDevTests) ... unexpected success

----------------------------------------------------------------------
Ran 1 test in 5.152s

FAILED (unexpected successes=1)
```

This is a follow-up to https://github.com/systemd/systemd/pull/10625.

5 years agoman: locale.conf: fix file name (#10637)
Lucas Werkmeister [Mon, 5 Nov 2018 03:47:09 +0000 (04:47 +0100)] 
man: locale.conf: fix file name (#10637)

A simple copy+paste mistake, since the reference to
systemd-localed.service was added to both locale.conf(5) and
vconsole.conf(5) in the same commit (8968e36f21).

5 years agotests: add a basic test for wireguard (#10631)
Evgeny Vereshchagin [Sat, 3 Nov 2018 17:03:43 +0000 (20:03 +0300)] 
tests: add a basic test for wireguard (#10631)

5 years agovlan-util: add assertions to parse_vlanid() 10618/head
Yu Watanabe [Sat, 3 Nov 2018 07:30:32 +0000 (16:30 +0900)] 
vlan-util: add assertions to parse_vlanid()

5 years agonetwork: add missing .sections element for vcan and vrf
Yu Watanabe [Sat, 3 Nov 2018 07:29:49 +0000 (16:29 +0900)] 
network: add missing .sections element for vcan and vrf

Fixes #10629.

5 years agonetwork: fix memleak abot Address.label
Yu Watanabe [Sat, 3 Nov 2018 06:44:34 +0000 (15:44 +0900)] 
network: fix memleak abot Address.label

Also fix possible memleak about Address.section.
Fixes #10628.

5 years agotest: UseRoutes= and UseTimezone= need to be in [DHCP] section
Yu Watanabe [Fri, 2 Nov 2018 09:13:14 +0000 (18:13 +0900)] 
test: UseRoutes= and UseTimezone= need to be in [DHCP] section

5 years agotest-network: wait after removing links
Yu Watanabe [Fri, 2 Nov 2018 08:48:44 +0000 (17:48 +0900)] 
test-network: wait after removing links

After ec6a47044a2ab321ae6427ce0d9fa3f6a17544a8, networkd starts
soon after removing links used by previous test. That causes
some racy situation of removing links and detecting links by networkd.

5 years agonetwork: drop error cause in log message
Yu Watanabe [Fri, 2 Nov 2018 08:36:50 +0000 (17:36 +0900)] 
network: drop error cause in log message

Fixes for 21486d9e99463b0dc1f3ff9b9f3846aa67ffca6d.

5 years agonetwork: fix memleak in static prefix
Yu Watanabe [Fri, 2 Nov 2018 08:14:05 +0000 (17:14 +0900)] 
network: fix memleak in static prefix

The fix by 744faf5e4e64e26181f03d1d9fa292ce6fb1456a is not perfect,
as the section leaks if `hashmap_put()` in `prefix_new_static()` fails.

5 years agonetdev: also support GENEVE.UDP6ZeroChecksum{Tx,Rx}=
Yu Watanabe [Fri, 2 Nov 2018 07:59:06 +0000 (16:59 +0900)] 
netdev: also support GENEVE.UDP6ZeroChecksum{Tx,Rx}=

After 53c06862c12918ec717ea70918039765212eee95, we prefer Checksum
instead of CheckSum. Let's do so for GENEVE netdev.

5 years agoman: drop duplicated line in systemd.netdev(5)
Yu Watanabe [Fri, 2 Nov 2018 07:38:17 +0000 (16:38 +0900)] 
man: drop duplicated line in systemd.netdev(5)

5 years agonetwork: fix worng offset for .network parser
Yu Watanabe [Fri, 2 Nov 2018 07:20:54 +0000 (16:20 +0900)] 
network: fix worng offset for .network parser

5 years agonetwork: fix memleak in config_parse_hwaddr()
Yu Watanabe [Thu, 1 Nov 2018 18:25:22 +0000 (03:25 +0900)] 
network: fix memleak in config_parse_hwaddr()

Fixes #10615.

5 years agonetwork: improve readability of config_parse_ifalias()
Yu Watanabe [Thu, 1 Nov 2018 18:24:57 +0000 (03:24 +0900)] 
network: improve readability of config_parse_ifalias()

5 years agonetwork: fix possible memleak caused by multiple setting of Bridge=, Bond= or VRF=
Yu Watanabe [Thu, 1 Nov 2018 18:17:55 +0000 (03:17 +0900)] 
network: fix possible memleak caused by multiple setting of Bridge=, Bond= or VRF=

5 years agotest: add test for radv_prefix_delegation_{from,to}_string()
Yu Watanabe [Thu, 1 Nov 2018 18:15:54 +0000 (03:15 +0900)] 
test: add test for radv_prefix_delegation_{from,to}_string()

5 years agonetwork: introduce radv_prefix_delegation_{from,to}_string()
Yu Watanabe [Thu, 1 Nov 2018 18:15:25 +0000 (03:15 +0900)] 
network: introduce radv_prefix_delegation_{from,to}_string()

5 years agonetwork: fix indentation
Yu Watanabe [Thu, 1 Nov 2018 18:14:07 +0000 (03:14 +0900)] 
network: fix indentation

5 years agonetwork: invert the order in comparison
Yu Watanabe [Thu, 1 Nov 2018 18:13:03 +0000 (03:13 +0900)] 
network: invert the order in comparison

5 years agonetwork: shorten code a bit
Yu Watanabe [Thu, 1 Nov 2018 18:12:02 +0000 (03:12 +0900)] 
network: shorten code a bit

5 years agotest: drop 'After=multi-user.target' from most of testsuite.service 10606/head
Yu Watanabe [Fri, 2 Nov 2018 01:27:56 +0000 (10:27 +0900)] 
test: drop 'After=multi-user.target' from most of testsuite.service