]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
6 years agosd-bus: do not try to close already closed fd (#8392)
Yu Watanabe [Thu, 8 Mar 2018 13:19:35 +0000 (22:19 +0900)] 
sd-bus: do not try to close already closed fd (#8392)

Fixes #8376, which is introduced by 2b33ab0957f453a06b58e4bee482f2c2d4e100c1.

6 years agoIntroduce suspend-to-hibernate (#8274)
Mario Limonciello [Thu, 8 Mar 2018 13:17:33 +0000 (21:17 +0800)] 
Introduce suspend-to-hibernate (#8274)

Suspend to Hibernate is a new sleep method that invokes suspend
for a predefined period of time before automatically waking up
and hibernating the system.

It's similar to HybridSleep however there isn't a performance
impact on every suspend cycle.

It's intended to use with systems that may have a higher power
drain in their supported suspend states to prevent battery and
data loss over an extended suspend cycle.

Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
6 years agohwdb: add accelerometer mount matrix for Eve V (#8382)
Daniel Lin [Thu, 8 Mar 2018 07:44:11 +0000 (02:44 -0500)] 
hwdb: add accelerometer mount matrix for Eve V (#8382)

6 years agohwdb: add Dell Inspiron 3537 axis overrides (#8388)
Peter Hutterer [Thu, 8 Mar 2018 07:41:33 +0000 (17:41 +1000)] 
hwdb: add Dell Inspiron 3537 axis overrides (#8388)

PS/2 and RMI4 entries

https://bugs.freedesktop.org/show_bug.cgi?id=105370

6 years agoRevert "core: don't setup init.scope in test mode (#8380)" (#8390)
Yu Watanabe [Thu, 8 Mar 2018 06:29:19 +0000 (15:29 +0900)] 
Revert "core: don't setup init.scope in test mode (#8380)" (#8390)

This reverts commit a9e8ecf0374c675831208559ba37749a8f9719ef,
as it breaks test-path.

Fixes #8389.

6 years agotest-cgroup-util: bail out when running under mock (#8365)
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 21:41:25 +0000 (22:41 +0100)] 
test-cgroup-util: bail out when running under mock (#8365)

The builds were failing in Fedora koji, where something strange is mounted
on /sys/fs/cgroup.

Also closes https://github.com/systemd/systemd/issues/8383.

6 years agocore: don't setup init.scope in test mode (#8380)
Michal Sekletar [Wed, 7 Mar 2018 15:41:41 +0000 (16:41 +0100)] 
core: don't setup init.scope in test mode (#8380)

Reproducer:

$ meson build && cd build
$ ninja
$ sudo useradd test
$ sudo su test
$ ./systemd --system --test
...
Failed to create /user.slice/user-1000.slice/session-6.scope/init.scope control group: Permission denied
Failed to allocate manager object: Permission denied

Above error message is caused by the fact that user test didn't have its
own session and we tried to set up init.scope already running as user
test in the directory owned by different user.

Let's skip setting up init.scope altogether since we won't be launching
processes anyway.

6 years agoMerge pull request #8378 from evverx/get-around-freopen
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 10:35:35 +0000 (11:35 +0100)] 
Merge pull request #8378 from evverx/get-around-freopen

tests: stop using `freopen` in `test-fileio`

6 years agoMerge pull request #8086 from hdante/sdboot-setmode-v2
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 09:41:44 +0000 (10:41 +0100)] 
Merge pull request #8086 from hdante/sdboot-setmode-v2

6 years agoMerge pull request #7817 from medhefgo/systemd-boot
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 09:14:41 +0000 (10:14 +0100)] 
Merge pull request #7817 from medhefgo/systemd-boot

systemd-boot improvements

6 years agosystemd-boot: fix off-by-one buffer overrun 7817/head
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 07:51:09 +0000 (08:51 +0100)] 
systemd-boot: fix off-by-one buffer overrun

We'd allocate a buffer of some size and then write zero to the byte one after.

6 years agosystemd-boot: reduce indentation in config_entry_add_linux()
Zbigniew Jędrzejewski-Szmek [Wed, 7 Mar 2018 07:55:04 +0000 (08:55 +0100)] 
systemd-boot: reduce indentation in config_entry_add_linux()

No functional change.

6 years agosystemd-boot: Try harder not to add ourselves to the list
Jan Janssen [Sat, 6 Jan 2018 18:21:48 +0000 (19:21 +0100)] 
systemd-boot: Try harder not to add ourselves to the list

We don't need to check if we are adding ourselves to the list
if we know that it's the windows or EFI shell loaders.

If we are adding the EFI default loader, additionally try to
see if we can find the systemd-boot magic string and skip
this entry if we do.

6 years agoNEWS: fix typos in v238 section (#8369)
Tomasz Torcz [Tue, 6 Mar 2018 08:35:47 +0000 (09:35 +0100)] 
NEWS: fix typos in v238 section (#8369)

6 years agorpm: add missing '-p <lua>' in trigger script (#8367)
Yu Watanabe [Tue, 6 Mar 2018 07:02:44 +0000 (16:02 +0900)] 
rpm: add missing '-p <lua>' in trigger script (#8367)

Follow-up for 32a00a9c097cf04ec2b0fcbf9b73eba188318424 (#8090).

6 years agotests: close a leftover file descriptor in `test-fileio` 8378/head
Evegeny Vereshchagin [Mon, 5 Mar 2018 22:05:46 +0000 (22:05 +0000)] 
tests: close a leftover file descriptor in `test-fileio`

This should make it a bit easier to search for real file descriptor leaks.

```
$ valgrind --leak-check=full --track-fds=yes ./build/test-fileio
...
==29457==
==29457== FILE DESCRIPTORS: 4 open at exit.
==29457== Open file descriptor 3: /tmp/test-systemd_writing_tmpfile.lyV5Rc
==29457==    at 0x4B9AD9E: open (open.c:43)
==29457==    by 0x4B19B24: __gen_tempname (tempname.c:261)
==29457==    by 0x4BA5CC3: mkostemp64 (mkostemp64.c:32)
==29457==    by 0x48F739B: mkostemp_safe (fileio.c:1206)
==29457==    by 0x10D968: test_writing_tmpfile (test-fileio.c:620)
==29457==    by 0x10E930: main (test-fileio.c:767)
==29457==
```

6 years agoMerge pull request #8362 from keszybz/release-238 v238
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 22:16:37 +0000 (23:16 +0100)] 
Merge pull request #8362 from keszybz/release-238

Release 238

6 years agoMerge pull request #8358 from fbuihuu/tmpfiles-dont-resolve-pathnames-when-traversing...
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 22:15:56 +0000 (23:15 +0100)] 
Merge pull request #8358 from fbuihuu/tmpfiles-dont-resolve-pathnames-when-traversing-recursively

Tmpfiles dont resolve pathnames when traversing recursively

6 years agotests: stop using `freopen` in `test-fileio`
Evegeny Vereshchagin [Mon, 5 Mar 2018 21:23:33 +0000 (21:23 +0000)] 
tests: stop using `freopen` in `test-fileio`

This helps get around a bug confusing `glibc` and making the test bail
out with the following error under `asan` on `x86`:

Fatal error: glibc detected an invalid stdio handle
Aborted (core dumped)

The bug has been reported in https://github.com/google/sanitizers/issues/778,
but it is unlikely to be fixed anytime soon.

6 years agotest: add tests for systemd-tmpfiles 8358/head
Franck Bui [Mon, 5 Mar 2018 11:32:18 +0000 (12:32 +0100)] 
test: add tests for systemd-tmpfiles

6 years agotest: fix setup_suse() to make it work with an already populated root
Franck Bui [Mon, 5 Mar 2018 18:02:25 +0000 (19:02 +0100)] 
test: fix setup_suse() to make it work with an already populated root

6 years agotmpfiles: don't resolve pathnames when traversing recursively through directory trees
Franck Bui [Fri, 2 Mar 2018 16:19:32 +0000 (17:19 +0100)] 
tmpfiles: don't resolve pathnames when traversing recursively through directory trees

Otherwise we can be fooled if one path component is replaced underneath us.

The patch achieves that by always operating at file descriptor level (by using
*at() helpers) and by making sure we do not any path resolution when traversing
direcotry trees.

However this is not always possible, for instance when listing the content of a
directory or some operations don't provide the *at() helpers or others (such as
fchmodat()) don't have the AT_EMPTY_PATH flag. In such cases we operate on
/proc/self/fd/%i pseudo-symlink instead, which works the same for all kinds of
objects and requires no checking of type beforehand.

Also O_PATH flag is used when opening file objects in order to prevent
undesired behaviors: device nodes from reacting, automounts from
triggering, etc...

Fixes: #7986
Fixes: CVE-2018-6954
6 years agotmpfiles: fstat() works with fd opened with O_PATH since Linux 3.6
Franck Bui [Fri, 2 Mar 2018 15:25:56 +0000 (16:25 +0100)] 
tmpfiles: fstat() works with fd opened with O_PATH since Linux 3.6

6 years agotmpfiles: make hardlink_vulnerable() argument constant
Franck Bui [Fri, 2 Mar 2018 15:13:07 +0000 (16:13 +0100)] 
tmpfiles: make hardlink_vulnerable() argument constant

6 years agoMerge pull request #8341 from yuwata/test-execute-ambient
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:45:28 +0000 (17:45 +0100)] 
Merge pull request #8341 from yuwata/test-execute-ambient

test-execute: check capabilities before runnig tests

6 years agoNEWS: bump version and add contributors 8362/head
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:13:38 +0000 (17:13 +0100)] 
NEWS: bump version and add contributors

6 years agomeson: bump so revision and systemd version in preparation for v238
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:12:48 +0000 (17:12 +0100)] 
meson: bump so revision and systemd version in preparation for v238

6 years agomailmap: one more person
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:08:01 +0000 (17:08 +0100)] 
mailmap: one more person

6 years agoMerge pull request #8345 from sourcejedi/logind_restart_is_sorely_lacking_in_testing
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:18:47 +0000 (17:18 +0100)] 
Merge pull request #8345 from sourcejedi/logind_restart_is_sorely_lacking_in_testing

login: fix for #8343

6 years agoMerge pull request #8354 from keszybz/new-NEWS
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 16:16:04 +0000 (17:16 +0100)] 
Merge pull request #8354 from keszybz/new-NEWS

NEWS for v238

6 years agomkosi: use locale that supports UTF-8, detect one that is available (#8340)
Filipe Brandenburger [Mon, 5 Mar 2018 16:03:52 +0000 (08:03 -0800)] 
mkosi: use locale that supports UTF-8, detect one that is available (#8340)

Using C.UTF-8 (as was done before #7244) breaks Arch Linux, but using
en_US.UTF-8 (after #7244) breaks Debian in our .mkosi/mkosi.debian.

So try to detect which one is available and works, first checking
whether we're already running under a valid UTF-8 locale, then trying
C.UTF-8 and finally en_US.UTF-8.

If we fail to find a valid UTF-8 locale, then fail early, instead of
letting the whole build complete only for Mesos to fail midway through
the `ninja test` step.

Tested on all of mkosi.fedora, mkosi.debian and mkosi.arch.

Fixes: #7238
6 years agoAdd accel matrix for iOTA 360 (#8342)
Marco Gulino [Mon, 5 Mar 2018 15:47:28 +0000 (15:47 +0000)] 
Add accel matrix for iOTA 360 (#8342)

6 years agoNEWS: update for v238 8354/head
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 09:25:17 +0000 (10:25 +0100)] 
NEWS: update for v238

6 years agoman: just use unicode for an mdash
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 08:31:17 +0000 (09:31 +0100)] 
man: just use unicode for an mdash

6 years agobasic/glob-util: do not use names with "_" prefix
Zbigniew Jędrzejewski-Szmek [Mon, 5 Mar 2018 08:04:39 +0000 (09:04 +0100)] 
basic/glob-util: do not use names with "_" prefix

Names starting with _ or __ are reserved by the standard, better to
avoid them.

6 years agocoredump: do not leak memory (#8352)
Yu Watanabe [Mon, 5 Mar 2018 07:39:52 +0000 (16:39 +0900)] 
coredump: do not leak memory (#8352)

Fixes #8351.

6 years agotest-execute: use CAP_CHOWN instead of CAP_NET_ADMIN 8341/head
Yu Watanabe [Sun, 4 Mar 2018 15:02:22 +0000 (00:02 +0900)] 
test-execute: use CAP_CHOWN instead of CAP_NET_ADMIN

CAP_NET_ADMIN is somtrimes dropped by container runtime.
This changes to use CAP_CHOWN instead of CAP_NET_ADMIN, as it is
less likely to be dropped.

6 years agotest-execute: check capabilities before running tests
Yu Watanabe [Sun, 4 Mar 2018 15:00:35 +0000 (00:00 +0900)] 
test-execute: check capabilities before running tests

Fixes #8193.

6 years agopo: Updated Indonesian translation (#8348)
Andika Triwidada [Sun, 4 Mar 2018 12:15:21 +0000 (19:15 +0700)] 
po: Updated Indonesian translation (#8348)

6 years agofixed 3 occurences of 'Failed top open' (#8349)
SjonHortensius [Sun, 4 Mar 2018 12:12:45 +0000 (13:12 +0100)] 
fixed 3 occurences of 'Failed top open' (#8349)

6 years agotest-execute: change log level from error to notice
Yu Watanabe [Sun, 4 Mar 2018 07:53:50 +0000 (16:53 +0900)] 
test-execute: change log level from error to notice

Skipping some tests due to the missing e.g., capsh binary
or kernel support, are not error.
This changes the log level for such messages.

6 years agotest-execute: rename tests for AmbientCapabilities=
Yu Watanabe [Sat, 3 Mar 2018 13:15:36 +0000 (22:15 +0900)] 
test-execute: rename tests for AmbientCapabilities=

The unit files for test-execute are named like
`exec-(setting-name-in-lower-character)-(optional-text).service`.
However, test units for AmbientCapabilities= are not following this.
So, let's rename them for the consistency.
This does not change anything in the functionality of the test.

6 years agohwdb: add axis range corrections for the Lenovo ThinkPad Edge 13 (02173BG) (#8253)
snorreflorre [Sun, 4 Mar 2018 07:18:46 +0000 (08:18 +0100)] 
hwdb: add axis range corrections for the Lenovo ThinkPad Edge 13 (02173BG) (#8253)

6 years agologin: remember that fds received from PID1 need to be removed eventually 8345/head
Alan Jenkins [Sat, 3 Mar 2018 18:44:39 +0000 (18:44 +0000)] 
login: remember that fds received from PID1 need to be removed eventually

Remember to set sd->pushed_fd when we receive an fd from PID1 on startup,
the same as we set it when we send an fd to PID1.

6 years agologin: fix FDNAME in call to sd_pid_notify_with_fds()
Alan Jenkins [Sat, 3 Mar 2018 18:37:50 +0000 (18:37 +0000)] 
login: fix FDNAME in call to sd_pid_notify_with_fds()

$ git grep FDNAME
logind-session-device.c: ... "FDNAME=session-", sd->session->id);
logind-session-device.c: ... "FDNAME=session", sd->session->id);

Oops.

Fixes #8343.  Or at least a more minimal reproducer.  Xorg still
dies when logind is restarted, but the Xorg message says this
is entirely deliberate.

(This could also be the reason I hit #8035, instead of the race
condition I originally suggested).

6 years agoupdate TODO
Lennart Poettering [Fri, 2 Mar 2018 15:25:27 +0000 (16:25 +0100)] 
update TODO

6 years agoMerge pull request #8314 from poettering/rearrange-stdio
Lennart Poettering [Fri, 2 Mar 2018 14:42:03 +0000 (15:42 +0100)] 
Merge pull request #8314 from poettering/rearrange-stdio

refactor how we rearrange fds for stdin/stdout/stderr

6 years agounits: use SuccessAction=reboot where appropriate (#8335)
Lennart Poettering [Fri, 2 Mar 2018 14:41:36 +0000 (15:41 +0100)] 
units: use SuccessAction=reboot where appropriate (#8335)

We should really use our own native concepts for rebooting.

6 years agoMerge pull request #8336 from poettering/coccinelle-reallocarray
Lennart Poettering [Fri, 2 Mar 2018 14:40:52 +0000 (15:40 +0100)] 
Merge pull request #8336 from poettering/coccinelle-reallocarray

reallocarray() coccinellization

6 years agoMerge pull request #8333 from keszybz/hwdb-update
Lennart Poettering [Fri, 2 Mar 2018 14:40:21 +0000 (15:40 +0100)] 
Merge pull request #8333 from keszybz/hwdb-update

Hwdb update

6 years agoMerge pull request #8337 from poettering/resolve-fixes
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 12:33:54 +0000 (13:33 +0100)] 
Merge pull request #8337 from poettering/resolve-fixes

various resolve-tool fixes

6 years agoman: there's no point in referenceing systemd.unit(5) from itself (#8338)
Lennart Poettering [Fri, 2 Mar 2018 12:33:30 +0000 (13:33 +0100)] 
man: there's no point in referenceing systemd.unit(5) from itself (#8338)

6 years agoMerge pull request #8323 from xyproto/ok_color
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 12:00:07 +0000 (13:00 +0100)] 
Merge pull request #8323 from xyproto/ok_color

Make the color of the status OK configurable at build-time

6 years agosysusers: support `u username -:300` style syntax (#8325)
Michael Vogt [Fri, 2 Mar 2018 11:56:44 +0000 (12:56 +0100)] 
sysusers: support `u username -:300` style syntax (#8325)

This PR implements the first part of RFE #8046. I.e. this allows to
write:
```
u username -:300
```
Where the uid is chosen automatically but the gid is fixed.

6 years agoMerge pull request #8332 from poettering/logind-open-if-needed
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 11:56:04 +0000 (12:56 +0100)] 
Merge pull request #8332 from poettering/logind-open-if-needed

logind device resume fix

6 years agomount-setup: change bpf mount mode to 0700 (#8334)
Lennart Poettering [Fri, 2 Mar 2018 11:55:24 +0000 (12:55 +0100)] 
mount-setup: change bpf mount mode to 0700 (#8334)

After discussing with the kernel folks, we agreed to default to 0700 for
this. Better safe than sorry.

6 years agoMerge pull request #8303 from yuwata/fix-8276
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 11:53:11 +0000 (12:53 +0100)] 
Merge pull request #8303 from yuwata/fix-8276

test: use synthesize_nobody() in test-execute

6 years agosystemctl: document telinit/init matching a bit (#8339)
Lennart Poettering [Fri, 2 Mar 2018 11:51:57 +0000 (12:51 +0100)] 
systemctl: document telinit/init matching a bit (#8339)

See: #8305

6 years agoresolved: debug log about resolv.conf lines we don't grok 8337/head
Lennart Poettering [Tue, 27 Feb 2018 16:47:00 +0000 (17:47 +0100)] 
resolved: debug log about resolv.conf lines we don't grok

6 years agoman: extend synopsys to recently added commands
Lennart Poettering [Wed, 28 Feb 2018 09:53:27 +0000 (10:53 +0100)] 
man: extend synopsys to recently added commands

6 years agoresolve-tool: propagate sensible errors from due to dns_name_is_valid() check failures
Lennart Poettering [Tue, 27 Feb 2018 16:46:00 +0000 (17:46 +0100)] 
resolve-tool: propagate sensible errors from due to dns_name_is_valid() check failures

6 years agoresolve-tool: trivial coding style improvements
Lennart Poettering [Tue, 27 Feb 2018 16:45:04 +0000 (17:45 +0100)] 
resolve-tool: trivial coding style improvements

6 years agococcinelle: similar to reallocarray() let's also systematically use malloc_multiply() 8336/head
Lennart Poettering [Tue, 27 Feb 2018 18:16:47 +0000 (19:16 +0100)] 
coccinelle: similar to reallocarray() let's also systematically use malloc_multiply()

6 years agococcinelle: add reallocarray() coccinelle script
Lennart Poettering [Tue, 27 Feb 2018 18:09:22 +0000 (19:09 +0100)] 
coccinelle: add reallocarray() coccinelle script

Let's systematically make use of reallocarray() whereever we invoke
realloc() with a product of two values.

6 years agoresolve-tool: use reallocarray() where appropriate
Lennart Poettering [Tue, 27 Feb 2018 16:45:30 +0000 (17:45 +0100)] 
resolve-tool: use reallocarray() where appropriate

6 years agohwdb: update 8333/head
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 11:12:04 +0000 (12:12 +0100)] 
hwdb: update

usb.ids are not updated, because linux-usb.org is down.

It seems that the updates are corrections and new entries, to major
removal of existing entries.

6 years agohwdb: add accelerometer mount matrix for Asus TP300LD (#8327)
futpib [Fri, 2 Mar 2018 11:11:28 +0000 (14:11 +0300)] 
hwdb: add accelerometer mount matrix for Asus TP300LD (#8327)

6 years agoMerge pull request #8237 from sourcejedi/timer_suspend
Lennart Poettering [Fri, 2 Mar 2018 11:11:06 +0000 (12:11 +0100)] 
Merge pull request #8237 from sourcejedi/timer_suspend

core: let OnCalendar= timer units expire during suspend (#8231)

6 years agohwdb: ignore whitespace in downloaded files
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 11:09:52 +0000 (12:09 +0100)] 
hwdb: ignore whitespace in downloaded files

6 years agotools/hwdb-update: allow downloads to fail
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 11:06:32 +0000 (12:06 +0100)] 
tools/hwdb-update: allow downloads to fail

sf.net is down, and linux-usb.org which is hosted there also fails.
That's not nice, but there's not we can do about it now.

6 years agologind: fix typo in comment 8332/head
Lennart Poettering [Fri, 2 Mar 2018 10:56:15 +0000 (11:56 +0100)] 
logind: fix typo in comment

6 years agologind: open device if needed
Lennart Poettering [Fri, 2 Mar 2018 10:55:51 +0000 (11:55 +0100)] 
logind: open device if needed

Fixes: #8291
6 years agologind: cast away return value we don't care about
Lennart Poettering [Fri, 2 Mar 2018 10:55:33 +0000 (11:55 +0100)] 
logind: cast away return value we don't care about

6 years agologind: voidify a function we never check the return value of
Lennart Poettering [Fri, 2 Mar 2018 10:55:16 +0000 (11:55 +0100)] 
logind: voidify a function we never check the return value of

6 years agotools/hwdb-update: print what is being executed
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 10:50:43 +0000 (11:50 +0100)] 
tools/hwdb-update: print what is being executed

6 years agofd-util: drop stdio_unset_cloexec(), it's not used anymore 8314/head
Lennart Poettering [Wed, 28 Feb 2018 22:24:50 +0000 (23:24 +0100)] 
fd-util: drop stdio_unset_cloexec(), it's not used anymore

6 years agosd-bus: let's better not invade stdio territory when duplicating fds
Lennart Poettering [Wed, 28 Feb 2018 22:36:33 +0000 (23:36 +0100)] 
sd-bus: let's better not invade stdio territory when duplicating fds

6 years agotree-wide: port various places over to use new rearrange_stdio()
Lennart Poettering [Wed, 28 Feb 2018 22:32:49 +0000 (23:32 +0100)] 
tree-wide: port various places over to use new rearrange_stdio()

6 years agoterminal-util: port some generic code over to rearrange_stdio()
Lennart Poettering [Wed, 28 Feb 2018 20:21:33 +0000 (21:21 +0100)] 
terminal-util: port some generic code over to rearrange_stdio()

6 years agofd-util: add new call rearrange_stdio()
Lennart Poettering [Wed, 28 Feb 2018 09:00:26 +0000 (10:00 +0100)] 
fd-util: add new call rearrange_stdio()

Quite often we need to set up a number of fds as stdin/stdout/stderr of
a process we are about to start. Add a generic implementation for a
routine doing that that takes care to do so properly:

1. Can handle the case where stdin/stdout/stderr where previously
   closed, and the fds to set as stdin/stdout/stderr hence likely in the
   0..2 range.  handling this properly is nasty, since we need to first
   move the fds out of this range in order to later move them back in, to
   make things fully robust.

2. Can optionally open /dev/null in case for one or more of the fds, in
   a smart way, sharing the open file if possible between multiple of
   the fds.

3. Guarantees that O_CLOEXEC is not set on the three fds, even if the fds
   already were in the 0..2 range and hence possibly weren't moved.

6 years agoMerge pull request #8316 from yuwata/fix-8315
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 10:32:25 +0000 (11:32 +0100)] 
Merge pull request #8316 from yuwata/fix-8315

sysusers: do not create duplicated groups when create users

6 years agoMerge pull request #8330 from filbranden/masked1
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 10:24:31 +0000 (11:24 +0100)] 
Merge pull request #8330 from filbranden/masked1

Detect masked unit with drop-ins

6 years agomeson: use dashes in colour names 8323/head
Zbigniew Jędrzejewski-Szmek [Fri, 2 Mar 2018 08:09:29 +0000 (09:09 +0100)] 
meson: use dashes in colour names

6 years agoAdd build-time option to change the color of the "OK" status text
Alexander F Rødseth [Thu, 1 Mar 2018 12:12:02 +0000 (13:12 +0100)] 
Add build-time option to change the color of the "OK" status text

6 years agoOrganize the ANSI codes and add missing colors
Alexander F Rødseth [Thu, 1 Mar 2018 17:23:05 +0000 (18:23 +0100)] 
Organize the ANSI codes and add missing colors

For consistency.

6 years agotest-execute: add tests with user/group daemon 8303/head
Yu Watanabe [Fri, 2 Mar 2018 06:55:02 +0000 (15:55 +0900)] 
test-execute: add tests with user/group daemon

The nobody user/group may not synthesized by systemd.
To run tests the functionalities in such situation, this adds tests
by user/group by daemon, as it is expected to exists all environments.

6 years agotest: masked unit with drop-ins 8330/head
Filipe Brandenburger [Fri, 2 Mar 2018 05:07:27 +0000 (21:07 -0800)] 
test: masked unit with drop-ins

6 years agoinstall: detect masked unit with drop-ins
Filipe Brandenburger [Fri, 2 Mar 2018 01:48:15 +0000 (17:48 -0800)] 
install: detect masked unit with drop-ins

Before this fix, a unit with drop-ins will not be reported as masked by
`systemctl is-enabled` or `systemctl list-unit-files`.

6 years agosysusers: do not implicitly create group by 'm' if 'u' with the same name exists 8316/head
Yu Watanabe [Thu, 1 Mar 2018 22:38:28 +0000 (07:38 +0900)] 
sysusers: do not implicitly create group by 'm' if 'u' with the same name exists

The commit e2c2060f7b3b11fa3cca8899d80963b7a05cc4ab makes 'm' lines
disturb 'u' lines.
This fixes the disturbance.

6 years agotest: add a test for sysusers
Yu Watanabe [Thu, 1 Mar 2018 05:52:28 +0000 (14:52 +0900)] 
test: add a test for sysusers

The test cases for sysusers did not cover the situation reported in
issue #8315. Let's add one more test case.

6 years agosysusers: do not create duplicated groups when create users
Yu Watanabe [Thu, 1 Mar 2018 18:27:34 +0000 (03:27 +0900)] 
sysusers: do not create duplicated groups when create users

The commit e2c2060f7b3b11fa3cca8899d80963b7a05cc4ab introduces
the issue #8315.

Fixes #8315.

6 years agoRemove /sbin from paths if split-bin is false (#8324)
Zbigniew Jędrzejewski-Szmek [Thu, 1 Mar 2018 20:48:36 +0000 (21:48 +0100)] 
Remove /sbin from paths if split-bin is false (#8324)

Follow-up for 157baa87e4.

6 years agoupdate TODO
Lennart Poettering [Wed, 28 Feb 2018 19:21:57 +0000 (20:21 +0100)] 
update TODO

6 years agoMerge pull request #8319 from keszybz/yet-another-symlink-installation-tweak
Lennart Poettering [Thu, 1 Mar 2018 14:06:02 +0000 (15:06 +0100)] 
Merge pull request #8319 from keszybz/yet-another-symlink-installation-tweak

meson: fix symlink creation when sbin is symlink to bin

6 years agoMerge pull request #8293 from dobyrch/master
Lennart Poettering [Thu, 1 Mar 2018 14:03:19 +0000 (15:03 +0100)] 
Merge pull request #8293 from dobyrch/master

tree-wide: fix inconsistencies in option parsing

6 years agoMerge pull request #8322 from keszybz/doc-tweak
Lennart Poettering [Thu, 1 Mar 2018 13:58:12 +0000 (14:58 +0100)] 
Merge pull request #8322 from keszybz/doc-tweak

man: document that link-ed files must be on /

6 years agoudevadm: prevent segfault in blkid builtin when offset not specified 8293/head
Douglas Christman [Wed, 28 Feb 2018 01:35:58 +0000 (20:35 -0500)] 
udevadm: prevent segfault in blkid builtin when offset not specified

"--offset" takes an optional argument; if none is specified,
stroull() will attempt to parse a NULL pointer. For example:

$ udevadm test-builtin 'blkid --offset' /sys/dev/block/8:1

Update "--offset" to require an argument; also verify that the
offset is not negative.

6 years agoanalyze: fix typo in error message
Douglas Christman [Thu, 1 Mar 2018 00:31:32 +0000 (08:31 +0800)] 
analyze: fix typo in error message

6 years agotest-libudev: make "-m" equivalent to "--monitor"
Douglas Christman [Wed, 28 Feb 2018 01:28:50 +0000 (20:28 -0500)] 
test-libudev: make "-m" equivalent to "--monitor"

"-m" is specified as a short form of "--monitor" in the option struct,
but not included in getopt_long's optstring.  Update the optstring
to be consistent with the option struct.

6 years agosystemctl: remove redundant option parsing code
Douglas Christman [Wed, 28 Feb 2018 01:19:55 +0000 (20:19 -0500)] 
systemctl: remove redundant option parsing code

"-f" used to be overloaded to mean both "--force" and "--follow";
aae9a96d removed "--follow", leaving behind some duplicate code.