]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
8 years agoMerge pull request #2115 from dvdhrm/rbtree
Tom Gundersen [Tue, 8 Dec 2015 16:31:09 +0000 (17:31 +0100)] 
Merge pull request #2115 from dvdhrm/rbtree

basic: add RB-Tree implementation

8 years agoMerge pull request #2122 from zonque/resolved-mdns-1
Tom Gundersen [Tue, 8 Dec 2015 16:24:09 +0000 (17:24 +0100)] 
Merge pull request #2122 from zonque/resolved-mdns-1

resolved: more mDNS specific bits

8 years agoresolved: add dns_cache_export_to_packet() 2122/head
Daniel Mack [Mon, 30 Nov 2015 23:53:42 +0000 (00:53 +0100)] 
resolved: add dns_cache_export_to_packet()

This new functions exports cached records of type PTR, SRV and TXT into
an existing DnsPacket. This is used in order to fill in known records
to mDNS queries, for known answer supression.

8 years agoresolved: implement query coalescing
Daniel Mack [Mon, 30 Nov 2015 11:47:11 +0000 (12:47 +0100)] 
resolved: implement query coalescing

Implement dns_transaction_make_packet_mdns(), a special version of
dns_transaction_make_packet() for mDNS which differs in many ways:

a) We coalesce queries of currently active transaction on the scope.
   This is possible because mDNS actually allows many questions in a
   to be sent in a single packet and it takes some burden from the
   network.

b) Both A and AAAA query keys are broadcast on both IPv4 and IPv6
   scopes, because other hosts might only respond on one of their
   addresses but resolve both types.

c) We discard previously sent packages (t->sent) so we can start over
   and coalesce pending transactions again.

8 years agoresolved: add 'next_attempt_after' field to DnsTransaction
Daniel Mack [Mon, 30 Nov 2015 21:35:51 +0000 (22:35 +0100)] 
resolved: add 'next_attempt_after' field to DnsTransaction

For each transaction, record when the earliest point in time when the
query packet may hit the wire. This is the same time stamp for which
the timer is scheduled in retries, except for the initial query packets
which are delayed by a random jitter. In this case, we denote that the
packet may actually be sent at the nominal time, without the jitter.

Transactions that share the same timestamp will also have identical
values in this field. It is used to coalesce pending queries in a later
patch.

8 years agoresolved: split dns_transaction_go()
Daniel Mack [Mon, 30 Nov 2015 18:06:36 +0000 (19:06 +0100)] 
resolved: split dns_transaction_go()

Split some code out of dns_transaction_go() so we can re-use it later from
different context. The new function dns_transaction_prepare_next_attempt()
takes care of preparing everything so that a new packet can conditionally
be formulated for a transaction.

This patch shouldn't cause any functional change.

8 years agoresolved: handle more mDNS protocol details
Daniel Mack [Thu, 3 Sep 2015 10:09:11 +0000 (12:09 +0200)] 
resolved: handle more mDNS protocol details

8 years agoresolved: fix debug message
Daniel Mack [Thu, 3 Sep 2015 10:04:31 +0000 (12:04 +0200)] 
resolved: fix debug message

8 years agoresolved: add mDNS packet dispatcher
Daniel Mack [Sat, 11 Jul 2015 00:44:59 +0000 (20:44 -0400)] 
resolved: add mDNS packet dispatcher

Add the packet dispatching routine for mDNS.

It differs to what LLMNR and DNS dispatchers do in the way it matches
incoming packets. In mDNS, we actually handle all incoming packets,
regardless whether we asked for them earlier or not.

8 years agoresolved: allow name compression in NSEC records
Daniel Mack [Tue, 1 Sep 2015 15:17:27 +0000 (17:17 +0200)] 
resolved: allow name compression in NSEC records

8 years agoresolved: handle mDNS timeouts per transaction
Daniel Mack [Fri, 28 Aug 2015 14:48:37 +0000 (16:48 +0200)] 
resolved: handle mDNS timeouts per transaction

mDNS packet timeouts need to be handled per transaction, not per link.
Re-use the n_attempts field for this purpose, as packets timeouts should be
determined by starting at 1 second, and doubling the value on each try.

8 years agoresolved: short-cut jitter callbacks for LLMNR and mDNS
Daniel Mack [Tue, 25 Aug 2015 15:57:58 +0000 (17:57 +0200)] 
resolved: short-cut jitter callbacks for LLMNR and mDNS

When a jitter callback is issued instead of sending a DNS packet directly,
on_transaction_timeout() is invoked to 'retry' the transaction. However,
this function has side effects. For once, it increases the packet loss
counter on the scope, and it also unrefs/refs the server instances.

Fix this by tracking the jitter with two bool variables. One saying that
the initial jitter has been scheduled in the first place, and one that
tells us the delay packet has been sent.

8 years agoresolved: flush keys when DNS_RESOURCE_KEY_CACHE_FLUSH is set
Daniel Mack [Tue, 4 Aug 2015 12:12:46 +0000 (14:12 +0200)] 
resolved: flush keys when DNS_RESOURCE_KEY_CACHE_FLUSH is set

In mDNS, DNS_RESOURCE_KEY_CACHE_FLUSH denotes whether other records with the
same key should be flushed from the cache.

8 years agoresolved: add cache flush flag to DnsResourceKey
Daniel Mack [Tue, 24 Nov 2015 14:45:15 +0000 (15:45 +0100)] 
resolved: add cache flush flag to DnsResourceKey

MDNS has a 'key cache flush' flag for records which must be masked out for
the parsers to do our right thing. We will also use that flag later (in a
different patch) in order to alter the cache behavior.

8 years agoresolved: add mDNS initial jitter
Daniel Mack [Tue, 25 Aug 2015 12:08:29 +0000 (14:08 +0200)] 
resolved: add mDNS initial jitter

The logic is to kick off mDNS packets in a delayed way is mostly identical
to what LLMNR needs, except that the constants are different.

8 years agoresolved: create dns scopes for mDNS
Daniel Mack [Sat, 11 Jul 2015 17:17:51 +0000 (13:17 -0400)] 
resolved: create dns scopes for mDNS

Follow what LLMNR does, and create per-link DnsScope objects.

8 years agoresolved: add code to join/leave mDNS multicast groups
Daniel Mack [Sat, 11 Jul 2015 18:33:58 +0000 (14:33 -0400)] 
resolved: add code to join/leave mDNS multicast groups

Per link, join the mDNS multicast groups when the scope is created, and
leave it again when the scope goes away.

8 years agoresolved: add packet header details for mDNS
Daniel Mack [Sat, 11 Jul 2015 00:44:46 +0000 (20:44 -0400)] 
resolved: add packet header details for mDNS

Validate mDNS queries and responses by looking at some header fields,
add mDNS flags.

8 years agoresolved: add infrastructure for mDNS related sockets
Daniel Mack [Fri, 10 Jul 2015 19:48:13 +0000 (15:48 -0400)] 
resolved: add infrastructure for mDNS related sockets

Just hook up mDNS listeners with an empty packet dispather function,
introduce a config directive, man page updates etc.

8 years agoMerge pull request #2104 from evverx/rlimit-util-test
Zbigniew Jędrzejewski-Szmek [Tue, 8 Dec 2015 04:47:45 +0000 (23:47 -0500)] 
Merge pull request #2104 from evverx/rlimit-util-test

tests: add test-rlimit-util

8 years agoMerge pull request #2117 from evverx/remove-dist-check-python
Zbigniew Jędrzejewski-Szmek [Tue, 8 Dec 2015 04:35:19 +0000 (23:35 -0500)] 
Merge pull request #2117 from evverx/remove-dist-check-python

build-sys: remove dist-check-python

8 years agobuild-sys: remove dist-check-python 2117/head
Evgeny Vereshchagin [Tue, 8 Dec 2015 02:33:52 +0000 (02:33 +0000)] 
build-sys: remove dist-check-python

added: 279419b379
obsoleted: 2c8849add4

8 years agoMerge pull request #2111 from evverx/remove-unnecessary-checking
Filipe Brandenburger [Mon, 7 Dec 2015 21:53:02 +0000 (13:53 -0800)] 
Merge pull request #2111 from evverx/remove-unnecessary-checking

build-sys: remove unnecessary check

8 years agobasic: add RB-Tree implementation 2115/head
David Herrmann [Mon, 7 Dec 2015 17:34:05 +0000 (18:34 +0100)] 
basic: add RB-Tree implementation

This adds an self-standing RB-Tree implementation to src/basic/. This
will be needed for NSEC RR lookups, since we need "close lookups", which
hashmaps (not even ordered-hashmaps) can give us in reasonable time.

8 years agoMerge pull request #2109 from keszybz/udev-null-deref
Martin Pitt [Mon, 7 Dec 2015 16:35:32 +0000 (17:35 +0100)] 
Merge pull request #2109 from keszybz/udev-null-deref

Udev null deref

8 years agotests: disable hard errors 2104/head
Evgeny Vereshchagin [Mon, 7 Dec 2015 09:43:43 +0000 (09:43 +0000)] 
tests: disable hard errors

we don't use it
https://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites

8 years agotests: add test-rlimit-util
Evgeny Vereshchagin [Sun, 6 Dec 2015 02:04:08 +0000 (02:04 +0000)] 
tests: add test-rlimit-util

8 years agobuild-sys: remove unnecessary check 2111/head
Evgeny Vereshchagin [Mon, 7 Dec 2015 07:02:37 +0000 (07:02 +0000)] 
build-sys: remove unnecessary check

added: 65adc982d
obsoleted: 2c8849add

8 years agoudev: fix NULL deref when executing rules 2109/head
Zbigniew Jędrzejewski-Szmek [Mon, 7 Dec 2015 05:10:15 +0000 (00:10 -0500)] 
udev: fix NULL deref when executing rules

We quite obviously check whether event->dev_db is nonnull, and
right after that call a function which asserts the same. Move
the call under the same if.

https://bugzilla.redhat.com/show_bug.cgi?id=1283971

8 years agolibudev: simplify udev_device_ensure_usec_initialized a bit
Zbigniew Jędrzejewski-Szmek [Mon, 7 Dec 2015 05:09:12 +0000 (00:09 -0500)] 
libudev: simplify udev_device_ensure_usec_initialized a bit

8 years agoMerge pull request #2095 from evverx/fix-distcheck-for-disable-timesync
Lennart Poettering [Sun, 6 Dec 2015 19:58:11 +0000 (20:58 +0100)] 
Merge pull request #2095 from evverx/fix-distcheck-for-disable-timesync

build-sys: move "dist" parts out of conditional

8 years agoMerge pull request #2100 from msekletar/nologin-label
Lennart Poettering [Sun, 6 Dec 2015 19:57:33 +0000 (20:57 +0100)] 
Merge pull request #2100 from msekletar/nologin-label

user-sessions: make sure /run/nologin has correct SELinux label

8 years agoMerge pull request #2107 from phomes/misc
Lennart Poettering [Sun, 6 Dec 2015 19:49:12 +0000 (20:49 +0100)] 
Merge pull request #2107 from phomes/misc

Misc cleanups

8 years agoMerge pull request #2097 from kinvolk/alban/TasksMax
Lennart Poettering [Sun, 6 Dec 2015 19:48:02 +0000 (20:48 +0100)] 
Merge pull request #2097 from kinvolk/alban/TasksMax

nspawn: set TasksMax in machined instead of nspawn

8 years agoresolve: remove unused variable 2107/head
Thomas Hindoe Paaboel Andersen [Sun, 6 Dec 2015 11:31:18 +0000 (12:31 +0100)] 
resolve: remove unused variable

8 years agoshared: include what we use
Thomas Hindoe Paaboel Andersen [Thu, 3 Dec 2015 20:13:37 +0000 (21:13 +0100)] 
shared: include what we use

The next step of a general cleanup of our includes. This one mostly
adds missing includes but there are a few removals as well.

8 years agonspawn: set TasksMax in machined instead of nspawn 2097/head
Alban Crequy [Tue, 24 Nov 2015 17:14:01 +0000 (18:14 +0100)] 
nspawn: set TasksMax in machined instead of nspawn

https://github.com/systemd/systemd/issues/2016

8 years agologin: make sure /run/nologin has correct SELinux label 2100/head
Michal Sekletar [Fri, 4 Dec 2015 21:29:38 +0000 (22:29 +0100)] 
login: make sure /run/nologin has correct SELinux label

8 years agouser-sessions: make sure /run/nologin has correct SELinux label
Michal Sekletar [Fri, 4 Dec 2015 20:33:42 +0000 (21:33 +0100)] 
user-sessions: make sure /run/nologin has correct SELinux label

8 years agoMerge pull request #2092 from poettering/dnssec2
Tom Gundersen [Fri, 4 Dec 2015 13:22:29 +0000 (14:22 +0100)] 
Merge pull request #2092 from poettering/dnssec2

Second DNSSEC patch set

8 years agobuild-sys: move "dist" parts out of conditional 2095/head
Evgeny Vereshchagin [Fri, 4 Dec 2015 05:48:09 +0000 (05:48 +0000)] 
build-sys: move "dist" parts out of conditional

Fixes:
$ ./autogen.sh
$ ./configure ... --disable-timesyncd
$ make distcheck
...
make[1]: *** No rule to make target 'src/timesync/timesyncd-gperf.gperf', needed by 'src/timesync/timesyncd-gperf.c'.  Stop.

8 years agoMerge pull request #2093 from evverx/add-test-dnssec-to-gitignore
Zbigniew Jędrzejewski-Szmek [Fri, 4 Dec 2015 02:41:53 +0000 (21:41 -0500)] 
Merge pull request #2093 from evverx/add-test-dnssec-to-gitignore

.gitignore: add test-dnssec

8 years ago.gitignore: add test-dnssec 2093/head
Evgeny Vereshchagin [Fri, 4 Dec 2015 01:32:15 +0000 (01:32 +0000)] 
.gitignore: add test-dnssec

This is a follow-up for 2b442ac87838be7c326

8 years agoresolved: update DNSSEC TODO list a bit 2092/head
Lennart Poettering [Thu, 3 Dec 2015 20:16:07 +0000 (21:16 +0100)] 
resolved: update DNSSEC TODO list a bit

8 years agoresolved: add a concept of "authenticated" responses
Lennart Poettering [Thu, 3 Dec 2015 20:04:52 +0000 (21:04 +0100)] 
resolved: add a concept of "authenticated" responses

This adds a new SD_RESOLVED_AUTHENTICATED flag for responses we return
on the bus. When set, then the data has been authenticated. For now this
mostly reflects the DNSSEC AD bit, if DNSSEC=trust is set. As soon as
the client-side validation is complete it will be hooked up to this flag
too.

We also set this bit whenver we generated the data ourselves, for
example, because it originates in our local LLMNR zone, or from the
built-in trust anchor database.

The "systemd-resolve-host" tool has been updated to show the flag state
for the data it shows.

8 years agoresolved: when synthesizing NODATA from cached NSEC bitmaps, honour CNAME/DNAME
Lennart Poettering [Thu, 3 Dec 2015 20:03:00 +0000 (21:03 +0100)] 
resolved: when synthesizing NODATA from cached NSEC bitmaps, honour CNAME/DNAME

When an RR type is not set in an NSEC, then the CNAME/DNAME types might
still be, hence check them too.

Otherwise we might end up refusing resolving of CNAME'd RRs if we cached
an NSEC before.

8 years agoresolved: maintain a short TODO list for DNSSEC support in the dnssec C files for now
Lennart Poettering [Thu, 3 Dec 2015 18:53:13 +0000 (19:53 +0100)] 
resolved: maintain a short TODO list for DNSSEC support in the dnssec C files for now

8 years agoresolved: introduce a dnssec_mode setting per scope
Lennart Poettering [Thu, 3 Dec 2015 18:51:04 +0000 (19:51 +0100)] 
resolved: introduce a dnssec_mode setting per scope

The setting controls which kind of DNSSEC validation is done: none at
all, trusting the AD bit, or client-side validation.

For now, no validation is implemented, hence the setting doesn't do much
yet, except of toggling the CD bit in the generated messages if full
client-side validation is requested.

8 years agoresolved: add a limit on the max DNSSEC RRSIG expiry skew we allow
Lennart Poettering [Thu, 3 Dec 2015 18:03:21 +0000 (19:03 +0100)] 
resolved: add a limit on the max DNSSEC RRSIG expiry skew we allow

8 years agoresolved: add a simple trust anchor database as additional RR source
Lennart Poettering [Thu, 3 Dec 2015 17:31:24 +0000 (18:31 +0100)] 
resolved: add a simple trust anchor database as additional RR source

When doing DNSSEC lookups we need to know one or more DS or DNSKEY RRs
as trust anchors to validate lookups. With this change we add a
compiled-in trust anchor database, serving the root DS key as of today,
retrieved from:

https://data.iana.org/root-anchors/root-anchors.xml

The interface is kept generic, so that additional DS or DNSKEY RRs may
be served via the same interface, for example by provisioning them
locally in external files to support "islands" of security.

The trust anchor database becomes the fourth source of RRs we maintain,
besides, the network, the local cache, and the local zone.

8 years agoresolved: rework how we allow allow queries to be dispatched to scopes
Lennart Poettering [Thu, 3 Dec 2015 17:26:12 +0000 (18:26 +0100)] 
resolved: rework how we allow allow queries to be dispatched to scopes

Previously, we'd never do any single-label or root domain lookups via
DNS, thus leaving single-label lookups to LLMNR and the search path
logic in order that single-label names don't leak too easily onto the
internet. With this change we open things up a bit, and only prohibit
A/AAAA lookups of single-label/root domains, but allow all other
lookups. This should provide similar protection, but allow us to resolve
DNSKEY+DS RRs for the top-level and root domains.

(This also simplifies handling of the search domain detection, and gets
rid of dns_scope_has_search_domains() in favour of
dns_scope_get_search_domains()).

8 years agoresolved: don't bother with picking a search domain when searching is disabled
Lennart Poettering [Thu, 3 Dec 2015 17:20:56 +0000 (18:20 +0100)] 
resolved: don't bother with picking a search domain when searching is disabled

8 years agoresolved: optionally, allocate DnsResourceKey objects on the stack
Lennart Poettering [Thu, 3 Dec 2015 16:27:13 +0000 (17:27 +0100)] 
resolved: optionally, allocate DnsResourceKey objects on the stack

Sometimes when looking up entries in hashmaps indexed by a
DnsResourceKey it is helpful not having to allocate a full
DnsResourceKey dynamically just to use it as search key. Instead,
optionally allow allocation of a DnsResourceKey on the stack. Resource
keys allocated like that of course are subject to other lifetime cycles
than the usual Resource keys, hence initialize the reference counter to
to (unsigned) -1.

While we are at it, remove the prototype for
dns_resource_key_new_dname() which was never implemented.

8 years agoresolved: make expiration error recognizable
Lennart Poettering [Thu, 3 Dec 2015 16:22:17 +0000 (17:22 +0100)] 
resolved: make expiration error recognizable

8 years agoresolved: refuse resolving of a number of domains listed in RFC6303
Lennart Poettering [Thu, 3 Dec 2015 16:20:47 +0000 (17:20 +0100)] 
resolved: refuse resolving of a number of domains listed in RFC6303

We already blacklisted a few domains, add more.

8 years agoMerge pull request #1934 from martinpitt/master
Tom Gundersen [Thu, 3 Dec 2015 17:22:06 +0000 (18:22 +0100)] 
Merge pull request #1934 from martinpitt/master

tests: add networkd integration test

8 years agoMerge pull request #2089 from keszybz/journal-fixes-2
Tom Gundersen [Thu, 3 Dec 2015 17:12:10 +0000 (18:12 +0100)] 
Merge pull request #2089 from keszybz/journal-fixes-2

Journal fixes

8 years agojournal: silently skip failing large messages if journald is missing 2089/head
Zbigniew Jędrzejewski-Szmek [Thu, 3 Dec 2015 07:44:50 +0000 (02:44 -0500)] 
journal: silently skip failing large messages if journald is missing

We treated -ENOENT errors with silent failure, for small messages.
Do the same for large messages.

8 years agojournal: unbreak sd_journal_sendv
Zbigniew Jędrzejewski-Szmek [Thu, 3 Dec 2015 07:20:39 +0000 (02:20 -0500)] 
journal: unbreak sd_journal_sendv

Borked since
commit 3ee897d6c2401effbc82f5eef35fce405781d6c8
Author: Lennart Poettering <lennart@poettering.net>
Date:   Wed Sep 23 01:00:04 2015 +0200

    tree-wide: port more code to use send_one_fd() and receive_one_fd()

because here our fd is not connected and we need to specify
the address.

8 years agotest-journal-send: add tests for sendv
Zbigniew Jędrzejewski-Szmek [Thu, 3 Dec 2015 05:45:59 +0000 (00:45 -0500)] 
test-journal-send: add tests for sendv

Also, check the return value of all calls.
They are documented to return 0, even if journald is not listening.

8 years agojournal: addition and multiplication do not commute
Zbigniew Jędrzejewski-Szmek [Thu, 3 Dec 2015 05:27:22 +0000 (00:27 -0500)] 
journal: addition and multiplication do not commute

8 years agotest-journal-send: no need to set log level
Zbigniew Jędrzejewski-Szmek [Thu, 3 Dec 2015 03:42:49 +0000 (22:42 -0500)] 
test-journal-send: no need to set log level

We only use the public api here, so don't include
log.h.

8 years agoMerge pull request #2087 from poettering/dnssec
Tom Gundersen [Thu, 3 Dec 2015 00:52:01 +0000 (01:52 +0100)] 
Merge pull request #2087 from poettering/dnssec

Basic DNSSEC support, and unrelated fixes

8 years agoresolved: support the RSASHA1_NSEC3_SHA1 pseudo-algorithm 2087/head
Lennart Poettering [Wed, 2 Dec 2015 23:39:44 +0000 (00:39 +0100)] 
resolved: support the RSASHA1_NSEC3_SHA1 pseudo-algorithm

RSASHA1_NSEC3_SHA1 is an alias for RSASHA1, used to do NSEC3 feature
negotiation. While verifying RRsets there's no difference, hence support
it here.

8 years agoresolved: synthesize NODATA cache results when we find matching NSEC RRs
Lennart Poettering [Wed, 2 Dec 2015 22:59:19 +0000 (23:59 +0100)] 
resolved: synthesize NODATA cache results when we find matching NSEC RRs

If we have a precisely matching NSEC RR for a name, we can use its type
bit field to synthesize NODATA cache lookup results for all types not
mentioned in there.

This is useful for mDNS where NSEC RRs are used to indicate missing RRs
for a specific type, but is beneficial in other cases too.

To test this, consider these two lines:

systemd-resolve-host -t NSEC nasa.gov
systemd-resolve-host -t SRV nasa.gov

The second line will not result in traffic as the first line already
cached the NSEC field.

8 years agoresolved: move algorithm/digest definitions into resolved-dns-rr.h
Lennart Poettering [Wed, 2 Dec 2015 21:56:04 +0000 (22:56 +0100)] 
resolved: move algorithm/digest definitions into resolved-dns-rr.h

After all, they are for flags and parameters of RRs and already relevant
when dealing with RRs outside of the serialization concept.

8 years agoresolved: don't accept expired RRSIGs
Lennart Poettering [Wed, 2 Dec 2015 21:47:28 +0000 (22:47 +0100)] 
resolved: don't accept expired RRSIGs

8 years agoresolved: add basic DNSSEC support
Lennart Poettering [Wed, 2 Dec 2015 20:20:37 +0000 (21:20 +0100)] 
resolved: add basic DNSSEC support

This adds most basic operation for doing DNSSEC validation on the
client side. However, it does not actually add the verification logic to
the resolver. Specifically, this patch only includes:

- Verifying DNSKEY RRs against a DS RRs
- Verifying RRSets against a combination of RRSIG and DNSKEY RRs
- Matching up RRSIG RRs and DNSKEY RRs
- Matching up RR keys and RRSIG RRs
- Calculating the DNSSEC key tag from a DNSKEY RR

All currently used DNSSEC combinations of SHA and RSA are implemented. Support
for MD5 hashing and DSA or EC cyphers are not. MD5 and DSA are probably
obsolete, and shouldn't be added. EC should probably be added
eventually, if it actually is deployed on the Internet.

8 years agoresolved: port ResolveRecord() bus call implementation to dns_resource_record_to_wire...
Lennart Poettering [Wed, 2 Dec 2015 20:05:21 +0000 (21:05 +0100)] 
resolved: port ResolveRecord() bus call implementation to dns_resource_record_to_wire_format()

Now that we have dns_resource_record_to_wire_format() we can generate
the RR serialization we return to bus clients in ResolveRecord() with
it. We pass the RR data along in the original form, not the DNSSEC
canonical form, since that would mean we'd lose RR name casing, which is
however important to keep for DNS-SD services and similar.

8 years agoresolved: add code to generate the wire format for a single RR
Lennart Poettering [Wed, 2 Dec 2015 19:58:51 +0000 (20:58 +0100)] 
resolved: add code to generate the wire format for a single RR

This adds dns_resource_record_to_wire_format() that generates the raw
wire-format of a single DnsResourceRecord object, and caches it in the
object, optionally in DNSSEC canonical form. This call is used later to
generate the RR serialization of RRs to verify.

This adds four new fields to DnsResourceRecord objects:

- wire_format points to the buffer with the wire-format version of the
  RR
- wire_format_size stores the size of that buffer
- wire_format_rdata_offset specifies the index into the buffer where the
  RDATA of the RR begins (i.e. the size of the key part of the RR).
- wire_format_canonical is a boolean that stores whether the cached wire
  format is in DNSSEC canonical form or not.

Note that this patch adds a mode where a DnsPacket is allocated on the
stack (instead of on the heap), so that it is cheaper to reuse the
DnsPacket object for generating this wire format. After all we reuse the
DnsPacket object for this, since it comes with all the dynamic memory
management, and serialization calls we need anyway.

8 years agoresolved: add code to map DNSSEC digest types to strings and back
Lennart Poettering [Wed, 2 Dec 2015 19:56:55 +0000 (20:56 +0100)] 
resolved: add code to map DNSSEC digest types to strings and back

8 years agoresolved: store DNSKEY fields flags+protocol as-is
Lennart Poettering [Wed, 2 Dec 2015 19:53:10 +0000 (20:53 +0100)] 
resolved: store DNSKEY fields flags+protocol as-is

When verifying signatures we need to be able to verify the original
data we got for an RR set, and that means we cannot simply drop flags
bits or consider RRs invalid too eagerly. Hence, instead of parsing the
DNSKEY flags store them as-is. Similar, accept the protocol field as it
is, and don't consider it a parsing error if it is not 3.

Of course, this means that the DNSKEY handling code later on needs to
check explicit for protocol != 3.

8 years agoresolved: add RFC 5702 defined DNSSEC algorithms to table
Lennart Poettering [Wed, 2 Dec 2015 19:51:07 +0000 (20:51 +0100)] 
resolved: add RFC 5702 defined DNSSEC algorithms to table

8 years agoutil-lib: update dns_name_to_wire_format() to optionally generate DNSSEC canonical...
Lennart Poettering [Wed, 2 Dec 2015 19:47:11 +0000 (20:47 +0100)] 
util-lib: update dns_name_to_wire_format() to optionally generate DNSSEC canonical names

We'll need this later when putting together RR serializations to
checksum.

8 years agoresolved: make sure DNS_ANSWER_FOREACH() can be nested
Lennart Poettering [Wed, 2 Dec 2015 19:43:11 +0000 (20:43 +0100)] 
resolved: make sure DNS_ANSWER_FOREACH() can be nested

Change the iterator counter so that a different varable is used for each
invocation of the macro, so that it may be nested.

8 years agoresolved: simplify dns_packet_append_string()
Lennart Poettering [Wed, 2 Dec 2015 19:35:02 +0000 (20:35 +0100)] 
resolved: simplify dns_packet_append_string()

It essentially does the same as dns_packet_append_raw_string(), hence
make it a wrapper around it.

8 years agohostnamed: SMBIOS 3.0 knows the "tablet" form factor, add support for it
Lennart Poettering [Wed, 2 Dec 2015 19:32:58 +0000 (20:32 +0100)] 
hostnamed: SMBIOS 3.0 knows the "tablet" form factor, add support for it

8 years agoMerge pull request #2073 from poettering/dns-label-fixes
Lennart Poettering [Wed, 2 Dec 2015 19:16:23 +0000 (20:16 +0100)] 
Merge pull request #2073 from poettering/dns-label-fixes

Dns label fixes + unrelated selinux clean-up

8 years agoMerge pull request #2084 from keszybz/ppc64-fixes-2
Lennart Poettering [Wed, 2 Dec 2015 19:15:34 +0000 (20:15 +0100)] 
Merge pull request #2084 from keszybz/ppc64-fixes-2

Test fixes to run in ppc64 mock

8 years agolz4: fix size check which had no chance of working on big-endian 2084/head
Zbigniew Jędrzejewski-Szmek [Wed, 2 Dec 2015 03:53:23 +0000 (22:53 -0500)] 
lz4: fix size check which had no chance of working on big-endian

8 years agotests: fix newlines in skip message
Zbigniew Jędrzejewski-Szmek [Wed, 2 Dec 2015 04:44:27 +0000 (23:44 -0500)] 
tests: fix newlines in skip message

8 years agotests: turn check if manager cannot be intialized into macro
Zbigniew Jędrzejewski-Szmek [Wed, 2 Dec 2015 03:35:16 +0000 (22:35 -0500)] 
tests: turn check if manager cannot be intialized into macro

We need to check the same thing in multiple tests. Use a shared
macro to make it easier to update the list of errnos.

Change the errno code for "unitialized cgroup fs" for ENOMEDIUM.
Exec format error looks like something more serious.

This fixes test-execute invocation in mock.

8 years agobasic/virt: add missing includes to compile on ppc64
Zbigniew Jędrzejewski-Szmek [Wed, 2 Dec 2015 03:54:26 +0000 (22:54 -0500)] 
basic/virt: add missing includes to compile on ppc64

8 years agoMerge pull request #2082 from phomes/basic-sort-includes
Tom Gundersen [Tue, 1 Dec 2015 23:27:02 +0000 (00:27 +0100)] 
Merge pull request #2082 from phomes/basic-sort-includes

basic: re-sort includes

8 years agobasic: re-sort includes 2082/head
Thomas Hindoe Paaboel Andersen [Tue, 1 Dec 2015 22:22:03 +0000 (23:22 +0100)] 
basic: re-sort includes

My previous patch to only include what we use accidentially placed
the added inlcudes in non-sorted order.

8 years agoMerge pull request #2074 from keszybz/test-acl-util-fix
Tom Gundersen [Mon, 30 Nov 2015 23:25:47 +0000 (00:25 +0100)] 
Merge pull request #2074 from keszybz/test-acl-util-fix

test-acl-util: fix two issues from review

8 years agoMerge pull request #2075 from phomes/includes-cleanup-basic
Tom Gundersen [Mon, 30 Nov 2015 23:25:07 +0000 (00:25 +0100)] 
Merge pull request #2075 from phomes/includes-cleanup-basic

basic: include only what we use

8 years agobasic: include only what we use 2075/head
Thomas Hindoe Paaboel Andersen [Mon, 30 Nov 2015 20:43:37 +0000 (21:43 +0100)] 
basic: include only what we use

This is a cleaned up result of running iwyu but without forward
declarations on src/basic.

8 years agotest-acl-util: fix two issues from review 2074/head
Zbigniew Jędrzejewski-Szmek [Mon, 30 Nov 2015 20:45:39 +0000 (15:45 -0500)] 
test-acl-util: fix two issues from review

https://github.com/systemd/systemd/pull/2063

8 years agocore: simplify selinux AVC initialization 2073/head
Lennart Poettering [Mon, 30 Nov 2015 19:26:03 +0000 (20:26 +0100)] 
core: simplify selinux AVC initialization

Let's merge access_init() and mac_selinux_access_init(), and only call
mac_selinux_use() once, inside the merged function, instead of multiple
times, including in the caller.

See comments on:

https://github.com/systemd/systemd/pull/2053

8 years agodns-domain: change error codes when dealing with too short buffers to ENOBUFS
Lennart Poettering [Mon, 30 Nov 2015 18:40:20 +0000 (19:40 +0100)] 
dns-domain: change error codes when dealing with too short buffers to ENOBUFS

Some calls used ENOBUFS to indicate too-short result buffers, others
used ENOSPC. Let's unify this on ENOBUFS.

8 years agodns-domain: check resulting domain name length in dns_name_to_wire_format()
Lennart Poettering [Mon, 30 Nov 2015 18:39:19 +0000 (19:39 +0100)] 
dns-domain: check resulting domain name length in dns_name_to_wire_format()

Let's better be safe than sorry.

8 years agodns-domain: make sure dns_name_to_wire_format() may properly encode the root domain
Lennart Poettering [Sun, 29 Nov 2015 13:29:31 +0000 (14:29 +0100)] 
dns-domain: make sure dns_name_to_wire_format() may properly encode the root domain

The root domain consists of zero labels, and we should be able to encode
that.

8 years agodns-domain: don't accept overly long hostnames
Lennart Poettering [Sun, 29 Nov 2015 13:27:28 +0000 (14:27 +0100)] 
dns-domain: don't accept overly long hostnames

Make sure dns_name_normalize(), dns_name_concat(), dns_name_is_valid()
do not accept/generate invalidly long hostnames, i.e. longer than 253
characters.

8 years agodns-domain: be more strict when encoding/decoding labels
Lennart Poettering [Sun, 29 Nov 2015 13:12:05 +0000 (14:12 +0100)] 
dns-domain: be more strict when encoding/decoding labels

Labels of zero length are not OK, refuse them early on. The concept of a
"zero-length label" doesn't exist, a zero-length full domain name
however does (representing the root domain). See RFC 2181, Section 11.

8 years agoMerge pull request #2068 from grawity/cgls-error-v2
Lennart Poettering [Mon, 30 Nov 2015 18:32:19 +0000 (19:32 +0100)] 
Merge pull request #2068 from grawity/cgls-error-v2

cgls: add a better error message for missing cgroupfs [v2]

8 years agoMerge pull request #2053 from poettering/selinux-fix
David Herrmann [Mon, 30 Nov 2015 18:30:03 +0000 (19:30 +0100)] 
Merge pull request #2053 from poettering/selinux-fix

Two unrelated fixes

8 years agocgls: add a better error message for missing cgroupfs 2068/head
Mantas Mikulėnas [Mon, 30 Nov 2015 06:48:29 +0000 (08:48 +0200)] 
cgls: add a better error message for missing cgroupfs

8 years agoMerge pull request #2063 from keszybz/issue-1977-2
Lennart Poettering [Mon, 30 Nov 2015 16:53:39 +0000 (17:53 +0100)] 
Merge pull request #2063 from keszybz/issue-1977-2

journal: clean up permission setting and acl adjustements on user journals

8 years agotmpfiles: set acls on system.journal explicitly 2063/head
Zbigniew Jędrzejewski-Szmek [Sun, 29 Nov 2015 23:48:40 +0000 (18:48 -0500)] 
tmpfiles: set acls on system.journal explicitly

https://github.com/systemd/systemd/issues/1397