]> git.ipfire.org Git - thirdparty/systemd.git/log
thirdparty/systemd.git
4 years agoman: re-indent systemd.netdev.xml 12690/head
Yu Watanabe [Wed, 29 May 2019 08:17:08 +0000 (17:17 +0900)] 
man: re-indent systemd.netdev.xml

4 years agotest-network: drop 25-nlmon.network
Yu Watanabe [Wed, 29 May 2019 07:38:08 +0000 (16:38 +0900)] 
test-network: drop 25-nlmon.network

4 years agoman: add vrf section
Franz Pletz [Thu, 23 May 2019 14:14:10 +0000 (16:14 +0200)] 
man: add vrf section

4 years agoMerge pull request #12687 from yuwata/parse_ifindex_or_ifname
Yu Watanabe [Wed, 29 May 2019 05:20:36 +0000 (14:20 +0900)] 
Merge pull request #12687 from yuwata/parse_ifindex_or_ifname

util: introduce parse_ifindex_or_ifname() and use it in networkctl and resolvectl

4 years agonetworkctl: use parse_ifindex_or_ifname() 12687/head
Yu Watanabe [Wed, 29 May 2019 02:02:09 +0000 (11:02 +0900)] 
networkctl: use parse_ifindex_or_ifname()

4 years agoresolvectl: use parse_ifindex_or_ifname()
Yu Watanabe [Wed, 29 May 2019 01:56:55 +0000 (10:56 +0900)] 
resolvectl: use parse_ifindex_or_ifname()

4 years agoutil: add assertions
Yu Watanabe [Wed, 29 May 2019 04:21:43 +0000 (13:21 +0900)] 
util: add assertions

4 years agoutil: introduce parse_ifindex_or_ifname()
Yu Watanabe [Wed, 29 May 2019 01:43:12 +0000 (10:43 +0900)] 
util: introduce parse_ifindex_or_ifname()

4 years agonetworkctl: add support to delete virtual netdevs
Susant Sahani [Wed, 22 May 2019 09:46:41 +0000 (15:16 +0530)] 
networkctl: add support to delete virtual netdevs

We now don't have the support to delete netdevs and dependent
upon iproute to delete. With this we can delete via networkctl
and use in our test cases too.

Note that it supports deleting multiple links at once.

```
 sudo ./networkctl delete test1 test2 test3 test4
```

4 years agoMerge pull request #12635 from yuwata/nlmon-support
Yu Watanabe [Wed, 29 May 2019 01:22:09 +0000 (10:22 +0900)] 
Merge pull request #12635 from yuwata/nlmon-support

network: add nlmon support

4 years agoMerge pull request #12573 from yuwata/network-dhcp-issue-12490
Yu Watanabe [Wed, 29 May 2019 01:21:31 +0000 (10:21 +0900)] 
Merge pull request #12573 from yuwata/network-dhcp-issue-12490

network: set preferred source in removing route entry on address lost

4 years agosystemd-sleep: replace rtc wakealarm with CLOCK_BOOTTIME_ALARM s2h
Zach Smith [Thu, 16 May 2019 16:12:41 +0000 (11:12 -0500)] 
systemd-sleep: replace rtc wakealarm with CLOCK_BOOTTIME_ALARM s2h

refactor to use timerfd in place of rtc wakealarm

confirm CLOCK_BOOTTIME_ALARM support in can_s2h

Remove CLOCK_BOOTTIME_ALARM task from TODO

remove unnecessary check on clock_supported return

4 years agoseccomp: add new 5.1 syscall pidfd_send_signal() to filter set list
Lennart Poettering [Tue, 28 May 2019 13:06:49 +0000 (15:06 +0200)] 
seccomp: add new 5.1 syscall pidfd_send_signal() to filter set list

4 years agotest: exit cleanly on success
Lennart Poettering [Fri, 24 May 2019 19:09:07 +0000 (21:09 +0200)] 
test: exit cleanly on success

4 years agotest-network: add a basic test for nlmon 12635/head
Yu Watanabe [Thu, 23 May 2019 02:37:53 +0000 (11:37 +0900)] 
test-network: add a basic test for nlmon

4 years agonetwork: add nlmon support
Yu Watanabe [Thu, 23 May 2019 02:36:25 +0000 (11:36 +0900)] 
network: add nlmon support

nlmon is a Netlink monitor device.

4 years agonetwork: add NetDevVTable::generate_mac flag
Yu Watanabe [Thu, 23 May 2019 02:27:12 +0000 (11:27 +0900)] 
network: add NetDevVTable::generate_mac flag

4 years agonetwork: do not send DHCPRELEASE when CriticalConnection= is enabled 12573/head
Yu Watanabe [Mon, 27 May 2019 20:45:10 +0000 (05:45 +0900)] 
network: do not send DHCPRELEASE when CriticalConnection= is enabled

4 years agotest-network: use wait_online() in NetworkdDHCPServerTests or friends
Yu Watanabe [Fri, 24 May 2019 06:43:14 +0000 (15:43 +0900)] 
test-network: use wait_online() in NetworkdDHCPServerTests or friends

4 years agotest-network: move test_domain() to NetworkdNetworkTests class
Yu Watanabe [Fri, 24 May 2019 06:34:19 +0000 (15:34 +0900)] 
test-network: move test_domain() to NetworkdNetworkTests class

4 years agotest-network: rename needlessly long class names
Yu Watanabe [Fri, 24 May 2019 06:17:41 +0000 (15:17 +0900)] 
test-network: rename needlessly long class names

4 years agotest-network: use wait_online() instead of waiting for 10 seconds
Yu Watanabe [Fri, 24 May 2019 04:59:34 +0000 (13:59 +0900)] 
test-network: use wait_online() instead of waiting for 10 seconds

But some tests requires both IPv4 and IPv6 addresses are configured.
Only in that case wait for addresses to be configured.

4 years agotest-network: drop unused link
Yu Watanabe [Fri, 24 May 2019 05:03:07 +0000 (14:03 +0900)] 
test-network: drop unused link

4 years agotest-network: rename link_remove() to remove_links()
Yu Watanabe [Fri, 24 May 2019 04:50:51 +0000 (13:50 +0900)] 
test-network: rename link_remove() to remove_links()

4 years agotest-network: remove routes even on failure
Yu Watanabe [Fri, 24 May 2019 04:49:51 +0000 (13:49 +0900)] 
test-network: remove routes even on failure

4 years agotest-network: use setUp() and tearDown() to delete routing policy rule tables
Yu Watanabe [Fri, 24 May 2019 04:44:49 +0000 (13:44 +0900)] 
test-network: use setUp() and tearDown() to delete routing policy rule tables

4 years agotest-network: remove fou ports on failure
Yu Watanabe [Fri, 24 May 2019 04:39:50 +0000 (13:39 +0900)] 
test-network: remove fou ports on failure

4 years agotest-network: stop dnsmasq before removing links
Yu Watanabe [Fri, 24 May 2019 04:38:08 +0000 (13:38 +0900)] 
test-network: stop dnsmasq before removing links

4 years agotest-network: warn when firewalld.service is running
Yu Watanabe [Fri, 24 May 2019 03:04:59 +0000 (12:04 +0900)] 
test-network: warn when firewalld.service is running

4 years agotest-network: add tests for issue #12490
Yu Watanabe [Fri, 24 May 2019 02:39:26 +0000 (11:39 +0900)] 
test-network: add tests for issue #12490

4 years agonetwork: lower log level about critical connection
Yu Watanabe [Fri, 24 May 2019 05:14:12 +0000 (14:14 +0900)] 
network: lower log level about critical connection

4 years agonetwork: split dhcp_lease_lost() into small pieces
Yu Watanabe [Fri, 24 May 2019 07:47:47 +0000 (16:47 +0900)] 
network: split dhcp_lease_lost() into small pieces

4 years agonetwork: set dhcp4_configured flag false before configuring address
Yu Watanabe [Tue, 28 May 2019 13:14:13 +0000 (22:14 +0900)] 
network: set dhcp4_configured flag false before configuring address

Otherwise, even if dhcp_lease_acquired() fails, the flag is still on.

4 years agonetwork: reset Link::dhcp4_configured flag earlier
Yu Watanabe [Tue, 28 May 2019 13:13:01 +0000 (22:13 +0900)] 
network: reset Link::dhcp4_configured flag earlier

4 years agonetwork: set preferred source in removing route entry on address lost
Yu Watanabe [Wed, 15 May 2019 05:55:31 +0000 (14:55 +0900)] 
network: set preferred source in removing route entry on address lost

Closes #12490.

4 years agoMerge pull request #12437 from poettering/chmod-and-chown-rewrite
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 13:12:20 +0000 (15:12 +0200)] 
Merge pull request #12437 from poettering/chmod-and-chown-rewrite

chmod_and_chown() rewrite

4 years agoMerge pull request #12390 from poettering/string-file-mkdir
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 12:42:55 +0000 (14:42 +0200)] 
Merge pull request #12390 from poettering/string-file-mkdir

fileio: add a WRITE_STRING_FILE_MKDIR_0755 flag to write_string_file() that creates parent directories if needed

4 years agoMerge pull request #12392 from poettering/firstboot-salt
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 12:36:54 +0000 (14:36 +0200)] 
Merge pull request #12392 from poettering/firstboot-salt

generalize crypt_r() salt generation code

4 years agoMerge pull request #12597 from keszybz/analyze-timestamp
Lennart Poettering [Tue, 28 May 2019 12:34:53 +0000 (14:34 +0200)] 
Merge pull request #12597 from keszybz/analyze-timestamp

Analyze timestamps

4 years agoMerge pull request #12682 from keszybz/pull-in-user-targets
Lennart Poettering [Tue, 28 May 2019 12:28:59 +0000 (14:28 +0200)] 
Merge pull request #12682 from keszybz/pull-in-user-targets

rules: enable hardware-related targets also for user instances

4 years agoNEWS: add some entries
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 10:36:34 +0000 (12:36 +0200)] 
NEWS: add some entries

For #12680, #12571.

4 years agocapability-util: be more careful with types
Lennart Poettering [Wed, 24 Apr 2019 16:41:25 +0000 (18:41 +0200)] 
capability-util: be more careful with types

4 years agoMerge pull request #12679 from yuwata/journal-issue-12400
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 12:20:34 +0000 (14:20 +0200)] 
Merge pull request #12679 from yuwata/journal-issue-12400

journal: do not trigger assertion when journal_file_close() get NULL

4 years agorules: enable hardware-related targets also for user instances 12682/head
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 12:10:44 +0000 (14:10 +0200)] 
rules: enable hardware-related targets also for user instances

> the odd thing is that these units are also defined for the systemd user
> instance. However, because these are bound to SYSTEMD_USER_WANTS rather than
> SYSTEMD_WANTS they are effectively useless unless some other software
> installs the corresponding udev rules first.

This adds the rules and starts those targets also for user instances.
Fixes #12330.

4 years agojournal: use cleanup attribute at one more place 12679/head
Yu Watanabe [Tue, 28 May 2019 09:07:01 +0000 (18:07 +0900)] 
journal: use cleanup attribute at one more place

4 years agojournal: do not trigger assertion when journal_file_close() get NULL
Yu Watanabe [Tue, 28 May 2019 03:40:17 +0000 (12:40 +0900)] 
journal: do not trigger assertion when journal_file_close() get NULL

We generally expect destructors to not complain if a NULL argument is passed.

Closes #12400.

4 years agoudev: fix error message
Yu Watanabe [Wed, 22 May 2019 16:30:02 +0000 (01:30 +0900)] 
udev: fix error message

4 years agoMerge pull request #12653 from yuwata/test-network-improvements-2
Zbigniew Jędrzejewski-Szmek [Tue, 28 May 2019 08:27:58 +0000 (10:27 +0200)] 
Merge pull request #12653 from yuwata/test-network-improvements-2

network: fix configuring vxcan devices and several test-network follow-ups

4 years agozsh-completion: fix completion for systemd-inhibit --what
Douglas Christman [Sat, 25 May 2019 07:50:49 +0000 (15:50 +0800)] 
zsh-completion: fix completion for systemd-inhibit --what

4 years agoudev: suppress warning when interface matches 99-default.link
Yu Watanabe [Sat, 25 May 2019 22:21:00 +0000 (07:21 +0900)] 
udev: suppress warning when interface matches 99-default.link

This suppress the following warning:
```
systemd-udevd[437]: Config file /usr/lib/systemd/network/99-default.link
applies to device based on potentially unpredictable interface name 'wlan0'
```

Follow-up for 84ea567eb4326eb970a33188649fde6bea2a0d4e.

4 years agobash-completion: update options for bootctl
Yu Watanabe [Sun, 26 May 2019 19:58:30 +0000 (04:58 +0900)] 
bash-completion: update options for bootctl

4 years agocoredumpctl: fix --debugger option
Yu Watanabe [Tue, 28 May 2019 01:52:55 +0000 (10:52 +0900)] 
coredumpctl: fix --debugger option

Closes #12660.

4 years agotest: correctly fail when system is borked
Frantisek Sumsal [Mon, 27 May 2019 17:59:26 +0000 (19:59 +0200)] 
test: correctly fail when system is borked

In certain situations, the systemctl commands may fail (e.g. due to
missing shared libraries), but the 'script' continues and creates a
/testok file, marking the test incorrectly as passed. Let's fix this and
bail out immediately when a command exits with a non-zero exit code.

4 years agoMerge pull request #12663 from mrc0mmand/clang-asan-improvements
Evgeny Vereshchagin [Mon, 27 May 2019 16:59:53 +0000 (19:59 +0300)] 
Merge pull request #12663 from mrc0mmand/clang-asan-improvements

test: improve handling of ASan under clang

4 years agodocs: add documentation for sanitizers 12663/head
Frantisek Sumsal [Mon, 27 May 2019 12:14:26 +0000 (14:14 +0200)] 
docs: add documentation for sanitizers

4 years agotest: improve handling of ASan under clang
Frantisek Sumsal [Fri, 24 May 2019 20:35:52 +0000 (22:35 +0200)] 
test: improve handling of ASan under clang

Running integration tests with ASan is somewhat tricky to begin with, as
we need to pre-load the ASan runtime DSO for certain services (like
dbus), otherwise they won't start or behave as expected. In case of gcc
this is pretty easy, as we need the runtime DSO during compilation, so
it's already present on the host system. For clang things get more
complicated, as ASan is compiled in statically by default, thus to
enable the necessary dynamic-ish behavior one needs to compile with
-shared-libasan and then correctly set LD_PRELOAD_PATH, as the runtime
libraries are not in a standard library path.

4 years ago--bind-device does not take a bool
Oliver Harley [Sun, 26 May 2019 05:31:29 +0000 (07:31 +0200)] 
--bind-device does not take a bool

See https://github.com/systemd/systemd/blob/e95be7def26c6c5feaf08a4135aa4f50c53263a8/src/mount/mount-tool.c#L164
Also makes the man page consistent with the `--help` option

4 years agohwdb: Add support for Linx 12V64 (#12665)
Jack [Sat, 25 May 2019 20:42:00 +0000 (21:42 +0100)] 
hwdb: Add support for Linx 12V64 (#12665)

This fixes the accelerometer for the Linx 12V64.
Note that even though the configuration for both models is the same, the 12V64 and 12X64 are different models.

4 years agotran: update Chinese (Traditional) translation to the latest. (#12662)
pan93412 [Sat, 25 May 2019 13:40:43 +0000 (21:40 +0800)] 
tran: update Chinese (Traditional) translation to the latest. (#12662)

l10n: update Chinese (Traditional) translation

4 years agomeson: let's make unified cgroupsv2 the default
Lennart Poettering [Tue, 25 Sep 2018 12:09:54 +0000 (14:09 +0200)] 
meson: let's make unified cgroupsv2 the default

Prompted by @evverx' comments:

https://github.com/systemd/systemd/pull/10161#pullrequestreview-158327715

4 years agotest-fs-util: don't validate mode of symlinks 12437/head
Lennart Poettering [Tue, 30 Apr 2019 17:32:31 +0000 (19:32 +0200)] 
test-fs-util: don't validate mode of symlinks

Some file systems refuse changing the mode, and the mode has zero effect
anyway, hence let's no test for this.

4 years agoterminal-util: reset access mode in vt_restore(), too
Lennart Poettering [Tue, 30 Apr 2019 17:26:14 +0000 (19:26 +0200)] 
terminal-util: reset access mode in vt_restore(), too

Only changing ownership back to root is not enough we also need to
change the access mode, otherwise the user might have set 666 first, and
thus allow everyone access before and after the chown().

4 years agotree-wide: port various places over to use chmod_and_chown()
Lennart Poettering [Tue, 30 Apr 2019 17:25:29 +0000 (19:25 +0200)] 
tree-wide: port various places over to use chmod_and_chown()

Doing this properly is hard, hence let's unify the code.

4 years agotmpfile-util: simplify umask reset declaration
Lennart Poettering [Tue, 30 Apr 2019 07:28:10 +0000 (09:28 +0200)] 
tmpfile-util: simplify umask reset declaration

4 years agotests: add simple test case for chmod_and_chown()
Lennart Poettering [Mon, 29 Apr 2019 18:18:21 +0000 (20:18 +0200)] 
tests: add simple test case for chmod_and_chown()

4 years agofs-util: rewrite chmod_and_chown()
Lennart Poettering [Mon, 29 Apr 2019 18:15:06 +0000 (20:15 +0200)] 
fs-util: rewrite chmod_and_chown()

Inspired by #12431 let's also rework chmod_and_chown() and make sure we
never add more rights to a file not owned by the right user.

Also, let's make chmod_and_chown() just a wrapper arond
fchmod_and_chown().

let's also change strategy: instead of chown()ing first and stating
after on failure and supressing errors, let's avoid the chown in the
firts place, in the interest on keeping things minimal.

4 years agomachine-image: openat() doesn't operate on the cwd if the first argument is specified
Lennart Poettering [Fri, 24 May 2019 08:54:09 +0000 (10:54 +0200)] 
machine-image: openat() doesn't operate on the cwd if the first argument is specified

A fix-up for bcb846f30f9ca8f42e79d109706aee9f2032261b.

4 years agoMerge pull request #12430 from poettering/seccomp-kill-process
Zbigniew Jędrzejewski-Szmek [Fri, 24 May 2019 10:17:53 +0000 (12:17 +0200)] 
Merge pull request #12430 from poettering/seccomp-kill-process

use SCMP_ACT_KILL_PROCESS for SystemCallFilters=

4 years agotest-execute: turn off coredump generation in test services 12430/head
Lennart Poettering [Mon, 29 Apr 2019 11:02:32 +0000 (13:02 +0200)] 
test-execute: turn off coredump generation in test services

These services are likely to coredump, and we expect that but aren't
interested in the coredump. Hence let's turn off processing by setting
RLIMIT_CORE to 0/0.

4 years agotest-execute: let's ignore the difference between CLD_KILLED and CLD_DUMPED
Lennart Poettering [Mon, 29 Apr 2019 10:58:55 +0000 (12:58 +0200)] 
test-execute: let's ignore the difference between CLD_KILLED and CLD_DUMPED

Depending on system configuration and whether SCMP_ACT_KILL_PROCESS or
SCMP_ACT_KILL_THREAD is available/used processes might coredump on
specific coredumps or are just plain killed. For our test case the
difference doesn't really matter, hence let's hide it away.

4 years agotest-execute: check exit code before exit status
Lennart Poettering [Mon, 29 Apr 2019 10:54:26 +0000 (12:54 +0200)] 
test-execute: check exit code before exit status

The meaning of the status changes depending on the code, hence let's
always compare the code first, status second.

4 years agoservice: tweak capitalization of unit description
Lennart Poettering [Mon, 29 Apr 2019 10:05:33 +0000 (12:05 +0200)] 
service: tweak capitalization of unit description

4 years agoNEWS: document the new SystemCallFilter= behaviour
Lennart Poettering [Mon, 29 Apr 2019 10:05:16 +0000 (12:05 +0200)] 
NEWS: document the new SystemCallFilter= behaviour

4 years agonspawn: expose the new seccomp actions in the OCI logic
Lennart Poettering [Mon, 29 Apr 2019 10:04:55 +0000 (12:04 +0200)] 
nspawn: expose the new seccomp actions in the OCI logic

4 years agotest: use the new action in our tests
Lennart Poettering [Mon, 29 Apr 2019 10:04:34 +0000 (12:04 +0200)] 
test: use the new action in our tests

This way, we know that it works as intended.

4 years agocore: prefer SCMP_ACT_KILL_PROCESS for SystemCallFilter= behaviour
Lennart Poettering [Mon, 29 Apr 2019 10:03:58 +0000 (12:03 +0200)] 
core: prefer SCMP_ACT_KILL_PROCESS for SystemCallFilter= behaviour

If we have it, use it. It makes a ton more sense.

Fixes: #11967
4 years agoseccomp: add scmp_act_kill_process() helper that returns SCMP_ACT_KILL_PROCESS if...
Lennart Poettering [Mon, 29 Apr 2019 09:54:00 +0000 (11:54 +0200)] 
seccomp: add scmp_act_kill_process() helper that returns SCMP_ACT_KILL_PROCESS if supported

4 years agoMerge pull request #12601 from keszybz/two-log-color-adjustments
Lennart Poettering [Fri, 24 May 2019 08:43:07 +0000 (10:43 +0200)] 
Merge pull request #12601 from keszybz/two-log-color-adjustments

Two log color adjustments

4 years agoMerge pull request #12590 from keszybz/unicode-cmdlines
Lennart Poettering [Fri, 24 May 2019 08:41:30 +0000 (10:41 +0200)] 
Merge pull request #12590 from keszybz/unicode-cmdlines

Use unicode for cmdline printing

4 years agotest-network: add basic tests for vxcan device 12653/head
Yu Watanabe [Thu, 23 May 2019 15:51:22 +0000 (00:51 +0900)] 
test-network: add basic tests for vxcan device

4 years agonetwork: make VXCAN devices go through LINK_STATE_CONFIGURING
Yu Watanabe [Thu, 23 May 2019 15:51:00 +0000 (00:51 +0900)] 
network: make VXCAN devices go through LINK_STATE_CONFIGURING

4 years agotest-network: add more tests for LinkLocalAddressing=yes on various netdevs
Yu Watanabe [Thu, 23 May 2019 15:09:55 +0000 (00:09 +0900)] 
test-network: add more tests for LinkLocalAddressing=yes on various netdevs

4 years agotest-network: drop pure test for dummy device
Yu Watanabe [Thu, 23 May 2019 14:55:54 +0000 (23:55 +0900)] 
test-network: drop pure test for dummy device

The dummy device is well used in test-network. So, the dropped test
is completely redundant.

4 years agotest-network: drop redundant check_link_exists()
Yu Watanabe [Thu, 23 May 2019 14:45:49 +0000 (23:45 +0900)] 
test-network: drop redundant check_link_exists()

When wait_online() passes, then the link must exist.

4 years agoDrop support for /usr/sbin/halt.local
Michael Biebl [Tue, 14 May 2019 15:40:45 +0000 (17:40 +0200)] 
Drop support for /usr/sbin/halt.local

/usr/sbin/halt.local is a Fedora/Red Hat anachronism from pre-systemd
times.

4 years agomkosi: update to Fedora30 (#12642)
Jóhann B. Guðmundsson [Thu, 23 May 2019 07:39:07 +0000 (07:39 +0000)] 
mkosi: update to Fedora30 (#12642)

4 years agoMerge pull request #12645 from poettering/journal-mmap-einval
Zbigniew Jędrzejewski-Szmek [Thu, 23 May 2019 07:37:54 +0000 (09:37 +0200)] 
Merge pull request #12645 from poettering/journal-mmap-einval

journald: output a proper error message when the journal is used on f…

4 years agoshared/machine-image: avoid passing NULL to log_debug_errno
Mike Gilbert [Wed, 22 May 2019 14:31:01 +0000 (10:31 -0400)] 
shared/machine-image: avoid passing NULL to log_debug_errno

Fixes: https://github.com/systemd/systemd/issues/12534
4 years agoMerge pull request #12618 from yuwata/test-network-improvements
Yu Watanabe [Thu, 23 May 2019 02:17:33 +0000 (11:17 +0900)] 
Merge pull request #12618 from yuwata/test-network-improvements

network: several cleanups

4 years agologin: fixup button_open() fd
root [Wed, 22 May 2019 23:10:23 +0000 (02:10 +0300)] 
login: fixup button_open() fd

4 years agoMerge pull request #12647 from cdown/dup
Chris Down [Wed, 22 May 2019 20:44:30 +0000 (16:44 -0400)] 
Merge pull request #12647 from cdown/dup

test: Remove superfluous error check

4 years agotest: Remove superfluous error check 12647/head
Chris Down [Wed, 22 May 2019 19:26:20 +0000 (15:26 -0400)] 
test: Remove superfluous error check

This is already checked above before we set any manager attributes,
immediately after manager_new().

4 years agoMerge pull request #12631 from keszybz/doc-and-error-message-tweaks
Lennart Poettering [Wed, 22 May 2019 17:00:10 +0000 (19:00 +0200)] 
Merge pull request #12631 from keszybz/doc-and-error-message-tweaks

Doc and error message tweaks

4 years agojournald: output a proper error message when the journal is used on fs that doesn... 12645/head
Lennart Poettering [Wed, 22 May 2019 16:48:02 +0000 (18:48 +0200)] 
journald: output a proper error message when the journal is used on fs that doesn't do mmap() properly

Prompted by:

https://lists.freedesktop.org/archives/systemd-devel/2019-May/042708.html

4 years agoMerge pull request #12431 from poettering/tmpfiles-chmod-chown-order
Zbigniew Jędrzejewski-Szmek [Wed, 22 May 2019 15:23:28 +0000 (17:23 +0200)] 
Merge pull request #12431 from poettering/tmpfiles-chmod-chown-order

tmpfiles: run chown() before chmod()

4 years agoman: reword systemd.socket(5) description to avoid "file" when talking about services 12631/head
Zbigniew Jędrzejewski-Szmek [Wed, 22 May 2019 09:09:36 +0000 (11:09 +0200)] 
man: reword systemd.socket(5) description to avoid "file" when talking about services

This text was written a long time ago, when we mostly talked about "service
files".  Strictly speaking, we don't need a "file", because the service might
be just an instance of a template, or an alias to another service. So let's use
the more modern parlance of "service units".

https://bugzilla.redhat.com/show_bug.cgi?id=1623781#c21

4 years agopid1: improve message when setting up namespace fails
Zbigniew Jędrzejewski-Szmek [Tue, 21 May 2019 18:02:34 +0000 (20:02 +0200)] 
pid1: improve message when setting up namespace fails

I covered the most obvious paths: those where there's a clear problem
with a path specified by the user.

Prints something like this (at error level):
May 21 20:00:01.040418 systemd[125871]: bad-workdir.service: Failed to set up mount namespacing: /run/systemd/unit-root/etc/tomcat9/Catalina: No such file or directory
May 21 20:00:01.040456 systemd[125871]: bad-workdir.service: Failed at step NAMESPACE spawning /bin/true: No such file or directory

Fixes #10972.

4 years agoman: tweak description of #12247 a bit
Zbigniew Jędrzejewski-Szmek [Tue, 21 May 2019 17:38:19 +0000 (19:38 +0200)] 
man: tweak description of #12247 a bit

It wasn't really wrong, but maybe we can make it a bit clearer.

Fixes #12247.

4 years agoman: add note that %h/%u/%U are mostly useless
Zbigniew Jędrzejewski-Szmek [Tue, 21 May 2019 17:31:49 +0000 (19:31 +0200)] 
man: add note that %h/%u/%U are mostly useless

Fixes #12389.

4 years agocore: unset HOME=/ that the kernel gives us
Zbigniew Jędrzejewski-Szmek [Tue, 21 May 2019 17:26:12 +0000 (19:26 +0200)] 
core: unset HOME=/ that the kernel gives us

Partially fixes #12389.

%h would return "/" in a machine, but "/root" in a container. Let's fix
this by resetting $HOME to the expected value.