thirdparty/systemd.git
2 years agoshell-completion: replace "gdb" verb with "debug" for coredumpctl
Jan Pokorný [Thu, 16 Aug 2018 16:23:16 +0000 (18:23 +0200)] 
shell-completion: replace "gdb" verb with "debug" for coredumpctl

Also offer --debugger option.  Both to reflect changes in v239.

2 years agoRevert "sysctl.d: request ECN on both in and outgoing connections"
Thomas Hindoe Paaboel Andersen [Fri, 17 Aug 2018 19:31:05 +0000 (21:31 +0200)] 
Revert "sysctl.d: request ECN on both in and outgoing connections"

Turning on ECN still causes slow or broken network on linux. Our tcp
is not yet ready for wide spread use of ECN.

This reverts commit 919472741dba6ad0a3f6c2b76d390a02d0e2fdc3.

2 years agoMerge pull request #9879 from evverx/get-rid-of-workaround
Yu Watanabe [Fri, 17 Aug 2018 15:11:58 +0000 (00:11 +0900)] 
Merge pull request #9879 from evverx/get-rid-of-workaround

 oss-fuzz.sh: just install the shared library

2 years agoresolvectl: free the block of memory 'hashed' points to before reusing it 9879/head
Evgeny Vereshchagin [Thu, 16 Aug 2018 06:48:06 +0000 (06:48 +0000)] 
resolvectl: free the block of memory 'hashed' points to before reusing it

This fixes a memory leak:
```
d5070e2f67ededca022f81f2941900606b16f3196b2268e856295f59._openpgpkey.gmail.com: resolve call failed: 'd5070e2f67ededca022f81f2941900606b16f3196b2268e856295f59._openpgpkey.gmail.com' not found

=================================================================
==224==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 65 byte(s) in 1 object(s) allocated from:
    #0 0x7f71b0878850 in malloc (/usr/lib64/libasan.so.4+0xde850)
    #1 0x7f71afaf69b0 in malloc_multiply ../src/basic/alloc-util.h:63
    #2 0x7f71afaf6c95 in hexmem ../src/basic/hexdecoct.c:62
    #3 0x7f71afbb574b in string_hashsum ../src/basic/gcrypt-util.c:45
    #4 0x56201333e0b9 in string_hashsum_sha256 ../src/basic/gcrypt-util.h:30
    #5 0x562013347b63 in resolve_openpgp ../src/resolve/resolvectl.c:908
    #6 0x562013348b9f in verb_openpgp ../src/resolve/resolvectl.c:944
    #7 0x7f71afbae0b0 in dispatch_verb ../src/basic/verbs.c:119
    #8 0x56201335790b in native_main ../src/resolve/resolvectl.c:2947
    #9 0x56201335880d in main ../src/resolve/resolvectl.c:3087
    #10 0x7f71ad8fcf29 in __libc_start_main (/lib64/libc.so.6+0x20f29)

SUMMARY: AddressSanitizer: 65 byte(s) leaked in 1 allocation(s).
```

2 years agooss-fuzz.sh: just install the shared library
Evgeny Vereshchagin [Thu, 16 Aug 2018 02:06:35 +0000 (02:06 +0000)] 
oss-fuzz.sh: just install the shared library

The workaround is no longer necessary, because the scripts
checking fuzzers have stopped going down to the subdirectories
of $OUT and started to look for the string "LLVMFuzzerTestOneInput"
to tell fuzzers and random binaries apart. Some more details can be
found at https://github.com/google/oss-fuzz/issues/1566.

2 years agoMerge pull request #9863 from evverx/issues-found-by-journald-fuzzer
Yu Watanabe [Mon, 13 Aug 2018 11:57:25 +0000 (20:57 +0900)] 
Merge pull request #9863 from evverx/issues-found-by-journald-fuzzer

A few fixes for several issues uncovered with a home-brew fuzzer for journald

2 years agoresolved: do not keep dns_server to dns_stream ref if tls connection failed (#9855)
Iwan Timmer [Mon, 13 Aug 2018 06:20:25 +0000 (08:20 +0200)] 
resolved: do not keep dns_server to dns_stream ref if tls connection failed (#9855)

The references to the dns_server are now setup after the tls connection is setup.
This ensures that the stream got fully stopped when the initial tls setup failed
instead of having the unref being blocked by the reference to the stream by the server.
Therefore on_stream_io would no longer be called with a half setup encrypted connection.

Fixes the issue reported in #9838.

2 years agoresolve: do not hit CNAME or DNAME entry in NODATA cache (#9836)
Yu Watanabe [Mon, 13 Aug 2018 05:32:33 +0000 (14:32 +0900)] 
resolve: do not hit CNAME or DNAME entry in NODATA cache (#9836)

Fixes #9833.

2 years agofsck: use our usual syntax for defining bit masks
Lennart Poettering [Fri, 10 Aug 2018 13:12:14 +0000 (15:12 +0200)] 
fsck: use our usual syntax for defining bit masks

2 years agoMerge pull request #9848 from yuwata/fix-9835-9844
Zbigniew Jędrzejewski-Szmek [Fri, 10 Aug 2018 13:36:34 +0000 (15:36 +0200)] 
Merge pull request #9848 from yuwata/fix-9835-9844

core: namespace fixes

2 years agojournald: take leading spaces into account in syslog_parse_identifier 9863/head
Evgeny Vereshchagin [Fri, 10 Aug 2018 12:55:09 +0000 (12:55 +0000)] 
journald: take leading spaces into account in syslog_parse_identifier

This is a kind of follow-up to e88baee88fad8bc59d3 which should finally fix
the issue which that commit was supposed to fix.

2 years agojournald: free the allocated memory before returning from dev_kmsg_record
Evgeny Vereshchagin [Fri, 10 Aug 2018 12:52:07 +0000 (12:52 +0000)] 
journald: free the allocated memory before returning from dev_kmsg_record

This fixes a minor memory leak.

2 years agojournald: make it clear that dev_kmsg_record modifies the string passed to it
Evgeny Vereshchagin [Fri, 10 Aug 2018 12:45:42 +0000 (12:45 +0000)] 
journald: make it clear that dev_kmsg_record modifies the string passed to it

The function replaces a couple commas, a semicolon and the final newline with
zero bytes in the string passed to it. The 'const' seems to have been added
by accident during a bulk edit (more specifically 3b3154df7e2773332bb814).

2 years agocore/execute: fix dump format for Limit*=
Yu Watanabe [Fri, 10 Aug 2018 04:03:02 +0000 (13:03 +0900)] 
core/execute: fix dump format for Limit*=

Fixes #9846.

2 years agojournal: do not remove multiple spaces after identifier in syslog message
Yu Watanabe [Fri, 10 Aug 2018 02:07:54 +0000 (11:07 +0900)] 
journal: do not remove multiple spaces after identifier in syslog message

Single space is used as separator.
C.f. discussions in #156.

Fixes #9839 introduced by a6aadf4ae0bae185dc4c414d492a4a781c80ffe5.

2 years agoutil: bind_remount_recursive_with_mountinfo(): ignore submounts which cannot be accessed 9848/head
Yu Watanabe [Fri, 10 Aug 2018 05:30:55 +0000 (14:30 +0900)] 
util: bind_remount_recursive_with_mountinfo(): ignore submounts which cannot be accessed

Fixes #9844.

2 years agocore/namespace: add more log messages
Yu Watanabe [Fri, 10 Aug 2018 04:50:54 +0000 (13:50 +0900)] 
core/namespace: add more log messages

Suggested by #9835.

2 years agomeson: actually honor pkgconfig*dir options (#9841)
Benedikt Morbach [Fri, 10 Aug 2018 02:59:54 +0000 (04:59 +0200)] 
meson: actually honor pkgconfig*dir options (#9841)

both were silently ignored leading to some of the pkg-config files
ending up in the wrong place

2 years agotimedate: emit property changed signal after all jobs are completed
Yu Watanabe [Thu, 26 Jul 2018 16:32:12 +0000 (01:32 +0900)] 
timedate: emit property changed signal after all jobs are completed

Follow-up for 3af0a96c0fcc623bd16649fc3640396a657cf9ef (#9684).

2 years agoMerge pull request #9827 from yuwata/fix-9795-9820
Lennart Poettering [Wed, 8 Aug 2018 12:07:40 +0000 (14:07 +0200)] 
Merge pull request #9827 from yuwata/fix-9795-9820

journal: fixes issues reported by ASan

2 years agotmpfiles: don't adjust qgroups on existing subvolumes
Franck Bui [Mon, 6 Aug 2018 10:29:54 +0000 (12:29 +0200)] 
tmpfiles: don't adjust qgroups on existing subvolumes

The qgroup logic (types 'q' and 'Q') only has an effect if there's no previous
setup at all, and any explicitly configured subvolumes with their qgroups are
left entirely unmodified.

The idea is that if users want a different logic than the one we set up by
default, then by all means they should do that before hand, and tmpfiles won't
override their logic.

2 years agoresolve: do not compress target names in SRV records
Yu Watanabe [Wed, 8 Aug 2018 05:30:40 +0000 (14:30 +0900)] 
resolve: do not compress target names in SRV records

Fixes #9793.

2 years agoMerge pull request #9830 from yuwata/journalctl-help
Lennart Poettering [Wed, 8 Aug 2018 10:23:58 +0000 (12:23 +0200)] 
Merge pull request #9830 from yuwata/journalctl-help

journal: do not hide options in help message

2 years agosyslog: fix segfault in syslog_parse_priority() 9827/head
Yu Watanabe [Wed, 8 Aug 2018 09:27:15 +0000 (18:27 +0900)] 
syslog: fix segfault in syslog_parse_priority()

2 years agokernel-install: don't try to run depmod when kernel doesn't support modules
Marc-Antoine Perennou [Tue, 7 Aug 2018 08:19:29 +0000 (10:19 +0200)] 
kernel-install: don't try to run depmod when kernel doesn't support modules

Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
2 years agojournal: fix size of buffer
Yu Watanabe [Wed, 8 Aug 2018 03:48:47 +0000 (12:48 +0900)] 
journal: fix size of buffer

2 years agoresolve: use memcmp_safe() and memcpy_safe()
Yu Watanabe [Wed, 8 Aug 2018 07:23:20 +0000 (16:23 +0900)] 
resolve: use memcmp_safe() and memcpy_safe()

As the length of salt in NSEC3 may be zero.

Fixes #9757.

2 years agoutil: introduce memcmp_safe()
Yu Watanabe [Wed, 8 Aug 2018 07:22:55 +0000 (16:22 +0900)] 
util: introduce memcmp_safe()

2 years agocore: use memcpy_safe()
Yu Watanabe [Wed, 8 Aug 2018 06:52:46 +0000 (15:52 +0900)] 
core: use memcpy_safe()

Fixes #9738.

2 years agojournal: fix syslog_parse_identifier()
Yu Watanabe [Wed, 8 Aug 2018 06:06:36 +0000 (15:06 +0900)] 
journal: fix syslog_parse_identifier()

Fixes #9829.

2 years agojournal: do not use newa() or strjoina() for message
Yu Watanabe [Wed, 8 Aug 2018 03:50:39 +0000 (12:50 +0900)] 
journal: do not use newa() or strjoina() for message

Fixes another issue reported in #9795.

2 years agojournal: do not hide options in help message 9830/head
Yu Watanabe [Wed, 8 Aug 2018 06:29:07 +0000 (15:29 +0900)] 
journal: do not hide options in help message

Even if built without gcrypt, show the relevant options in help message.
Otherwise, the help message diverges from the man page or suggestions
by the shell completion.

2 years agobash-completion: journalctl: add --grep and --case-sensitive
Yu Watanabe [Wed, 8 Aug 2018 01:47:44 +0000 (10:47 +0900)] 
bash-completion: journalctl: add --grep and --case-sensitive

2 years agojournal: do not pass a negative value to memcpy()
Yu Watanabe [Wed, 8 Aug 2018 03:40:44 +0000 (12:40 +0900)] 
journal: do not pass a negative value to memcpy()

The message may contains only whitespaces.

Fixes #9795.

2 years agolink: fix type for link-config's "features" array of tristates
Thomas Haller [Tue, 7 Aug 2018 06:55:07 +0000 (08:55 +0200)] 
link: fix type for link-config's "features" array of tristates

The "features" fields is parsed as a tristate value. The values
are thus not of type NetDevFeature enum but int. The NetDevFeature
enum is instead the index for the features array.

Adjust the type. In practice, this had no impact because NetDevFeature
enum commonly has size of int.

Also, don't use memset() 0xFF to initilize the int with -1. While
it works correctly in practice, it feels ugly.

2 years agotest: cast values in proper type to suppress warnings
Yu Watanabe [Tue, 7 Aug 2018 09:25:00 +0000 (18:25 +0900)] 
test: cast values in proper type to suppress warnings

Follow-up for #9789.

2 years agoMerge pull request #9817 from yuwata/shorten-error-logging
Lennart Poettering [Tue, 7 Aug 2018 08:44:44 +0000 (10:44 +0200)] 
Merge pull request #9817 from yuwata/shorten-error-logging

tree-wide: Shorten error logging and several code cleanups

2 years agoMerge pull request #9744 from yuwata/fix-9737
Lennart Poettering [Tue, 7 Aug 2018 07:55:07 +0000 (09:55 +0200)] 
Merge pull request #9744 from yuwata/fix-9737

Make RootImage= work with PrivateDevices=

2 years agohwdb: redefine Lenovo ThinkPad X140e touchpad dimensions (#9818)
Michael 'pbone' Pobega [Tue, 7 Aug 2018 07:41:49 +0000 (03:41 -0400)] 
hwdb: redefine Lenovo ThinkPad X140e touchpad dimensions (#9818)

The default setup for the Lenovo ThinkPad X140e is 104x104mm, and the kernel
claims that it's 64x21. The default 104x104mm dimensions causes the vertical
axis to act oddly, causing random vertical jitters and higher vertical
sensitivity.

Measuring it showed that it was 74x32, and these touchpad dimensions provide
a better (if a little bit slower) experience but a consistent sensitivity
in all directions.

These values were obtained using the `touchpad-edge-detector` tool.

2 years agoMerge pull request #9789 from filbranden/cmp1
Lennart Poettering [Tue, 7 Aug 2018 07:39:26 +0000 (09:39 +0200)] 
Merge pull request #9789 from filbranden/cmp1

Add new CMP(a, b) macro

2 years agosystemctl: add support for --wait to is-system-running
Filipe Brandenburger [Sat, 4 Aug 2018 06:10:54 +0000 (23:10 -0700)] 
systemctl: add support for --wait to is-system-running

This makes it possible to wait until boot is finished without having to poll
for this command repeatedly, instead using the syntax:

  $ systemctl is-system-running --wait

Waiting is implemented by waiting for the StartupFinished signal to be posted
on the bus.

Register the matcher before checking for the property to avoid race conditions.

Tested by artificially delaying startup with a oneshot service and calling this
command, checked that it emitted `running` and exited with a 0 return code as
soon as the delay service completed startup.

Also tested that booting to degraded state unblocks the command.

Inserted a delay between getting the property and waiting for the signal and
confirmed this seems to work free of race conditions.

Updated the --help text (under --wait) and the man page to document the new
feature.

2 years agotree-wide: use returned value from log_*_errno() 9817/head
Yu Watanabe [Tue, 7 Aug 2018 06:48:37 +0000 (15:48 +0900)] 
tree-wide: use returned value from log_*_errno()

2 years agodns-domain: use CMP() in dns_name_compare_func 9789/head
Filipe Brandenburger [Tue, 7 Aug 2018 02:23:41 +0000 (19:23 -0700)] 
dns-domain: use CMP() in dns_name_compare_func

2 years agoresolve: use CMP() in dns_resource_record_compare_func
Filipe Brandenburger [Tue, 7 Aug 2018 02:21:38 +0000 (19:21 -0700)] 
resolve: use CMP() in dns_resource_record_compare_func

This function doesn't really implement ordering, but CMP() is still fine to use
there. Keep the comment in place, just update it slightly to indicate that.

2 years agotree-wide: Convert compare_func's to use CMP() macro wherever possible.
Filipe Brandenburger [Thu, 2 Aug 2018 23:43:37 +0000 (16:43 -0700)] 
tree-wide: Convert compare_func's to use CMP() macro wherever possible.

Looked for definitions of functions using the *_compare_func() suffix.

Tested:
- Unit tests passed (ninja -C build/ test)
- Installed this build and booted with it.

2 years agonetwork: Use CMP() macro for comparison.
Filipe Brandenburger [Thu, 2 Aug 2018 23:00:53 +0000 (16:00 -0700)] 
network: Use CMP() macro for comparison.

Follow up for PRs #9764 and #9760.

2 years agomacros: add CMP(a, b) macro.
Filipe Brandenburger [Thu, 2 Aug 2018 21:37:42 +0000 (14:37 -0700)] 
macros: add CMP(a, b) macro.

Macro returns -1, 0, 1 depending on whether a < b, a == b or a > b.

It's safe to use on unsigned types.

Add tests to confirm corner cases are properly covered.

2 years agomacro: drop __extension__, reformat and reindent
Filipe Brandenburger [Tue, 7 Aug 2018 02:15:02 +0000 (19:15 -0700)] 
macro: drop __extension__, reformat and reindent

Drop __extension__, since we don't use gcc -Wpedantic or -ansi.

Reformat code for spacing. Add spaces after commas almost everywhere.
Reindent code blocks in macro definitions, for consistency.

2 years agotree-wide: shorten error logging a bit
Yu Watanabe [Tue, 7 Aug 2018 01:14:30 +0000 (10:14 +0900)] 
tree-wide: shorten error logging a bit

Continuation of 4027f96aa08c73f109aa46b89842ca0e25c9c0e9.

2 years agoresolve: use _cleanup_ attribute
Yu Watanabe [Tue, 7 Aug 2018 01:13:44 +0000 (10:13 +0900)] 
resolve: use _cleanup_ attribute

2 years agomachine: use free_and_replace() and TAKE_PTR()
Yu Watanabe [Tue, 7 Aug 2018 01:11:56 +0000 (10:11 +0900)] 
machine: use free_and_replace() and TAKE_PTR()

2 years agologin: use free_and_replace() and TAKE_PTR()
Yu Watanabe [Tue, 7 Aug 2018 01:10:12 +0000 (10:10 +0900)] 
login: use free_and_replace() and TAKE_PTR()

2 years agoinitctl: do not ignore errors in function
Yu Watanabe [Tue, 7 Aug 2018 01:06:49 +0000 (10:06 +0900)] 
initctl: do not ignore errors in function

2 years agomachinectl: shorten error logging a bit
Lennart Poettering [Mon, 6 Aug 2018 13:47:03 +0000 (15:47 +0200)] 
machinectl: shorten error logging a bit

2 years agosmack-util: use 'path' paremeter as is if it's already absolute in mac_smack_fix_at()
Franck Bui [Mon, 6 Aug 2018 09:31:04 +0000 (11:31 +0200)] 
smack-util: use 'path' paremeter as is if it's already absolute in mac_smack_fix_at()

2 years agoMerge pull request #9792 from poettering/hashmap-mempool
Zbigniew Jędrzejewski-Szmek [Mon, 6 Aug 2018 12:13:30 +0000 (14:13 +0200)] 
Merge pull request #9792 from poettering/hashmap-mempool

minor hashmap fixes

2 years agoresolve: treat some icmp errors as disconnected
Yu Watanabe [Thu, 2 Aug 2018 06:36:32 +0000 (15:36 +0900)] 
resolve: treat some icmp errors as disconnected

Fixes #9773.

2 years agoresolve: sort headers
Yu Watanabe [Thu, 2 Aug 2018 06:41:48 +0000 (15:41 +0900)] 
resolve: sort headers

2 years agoMerge pull request #9775 from yuwata/follow-up-9766
Zbigniew Jędrzejewski-Szmek [Mon, 6 Aug 2018 05:58:50 +0000 (07:58 +0200)] 
Merge pull request #9775 from yuwata/follow-up-9766

2 years agonamespace: implicitly adds DeviceAllow= when RootImage= is set 9744/head
Yu Watanabe [Mon, 6 Aug 2018 05:02:28 +0000 (14:02 +0900)] 
namespace: implicitly adds DeviceAllow= when RootImage= is set

RootImage= may require the following settings
```
DeviceAllow=/dev/loop-control rw
DeviceAllow=block-loop rwm
DeviceAllow=block-blkext rwm
```
This adds the following settings implicitly when RootImage= is
specified.

Fixes #9737.

2 years agocore: introduce cgroup_add_device_allow()
Yu Watanabe [Mon, 6 Aug 2018 04:42:14 +0000 (13:42 +0900)] 
core: introduce cgroup_add_device_allow()

2 years agocore/namespace: drop mount points outside of root even if RootDirectory= is not set
Yu Watanabe [Sat, 28 Jul 2018 15:42:41 +0000 (00:42 +0900)] 
core/namespace: drop mount points outside of root even if RootDirectory= is not set

2 years agocore/namespace: drop conditions depends on `root` is empty or not
Yu Watanabe [Sat, 28 Jul 2018 15:38:36 +0000 (00:38 +0900)] 
core/namespace: drop conditions depends on `root` is empty or not

After 0722b359342d2a9f9e0d453875624387a0ba1be2, the variable `root`
is always set.

2 years agoresolve: fix error handling of dns_name_is_valid() 9775/head
Yu Watanabe [Thu, 2 Aug 2018 07:54:27 +0000 (16:54 +0900)] 
resolve: fix error handling of dns_name_is_valid()

2 years agoman: mention that Hostname= for DHCP must be a valid DNS domain name
Yu Watanabe [Thu, 2 Aug 2018 07:32:42 +0000 (16:32 +0900)] 
man: mention that Hostname= for DHCP must be a valid DNS domain name

2 years agonetwork: DHCP: ignore error in setting hostname when it is given by uname()
Yu Watanabe [Thu, 2 Aug 2018 07:31:10 +0000 (16:31 +0900)] 
network: DHCP: ignore error in setting hostname when it is given by uname()

C.f. #9759.

2 years agonetwork: use free_and_replace()
Yu Watanabe [Thu, 2 Aug 2018 07:28:44 +0000 (16:28 +0900)] 
network: use free_and_replace()

2 years agonetwork: also check that Hostname= is a valid DNS domain name
Yu Watanabe [Thu, 2 Aug 2018 07:28:23 +0000 (16:28 +0900)] 
network: also check that Hostname= is a valid DNS domain name

2 years agoMerge pull request #8822 from fbuihuu/rfc-tmpfiles-safe-upstream
Lennart Poettering [Fri, 3 Aug 2018 16:11:36 +0000 (18:11 +0200)] 
Merge pull request #8822 from fbuihuu/rfc-tmpfiles-safe-upstream

Make tmpfiles safe

2 years agoman: include libsystemd-pkgconfig.xml in a few more man pages 9792/head
Lennart Poettering [Fri, 3 Aug 2018 15:34:40 +0000 (17:34 +0200)] 
man: include libsystemd-pkgconfig.xml in a few more man pages

for some reason this was forgotten for a couple of sd_bus man pages,
let's fix that.

2 years agotest-resolved: follow coding style, use fopen() with 'e'
Lennart Poettering [Fri, 3 Aug 2018 14:48:53 +0000 (16:48 +0200)] 
test-resolved: follow coding style, use fopen() with 'e'

2 years agohashmap: add an explicit assert() for detecting when objects migrated between threads
Lennart Poettering [Fri, 3 Aug 2018 14:46:26 +0000 (16:46 +0200)] 
hashmap: add an explicit assert() for detecting when objects migrated between threads

When clients don't follow protocol and use the same object from
different threads, then we previously would silently corrupt memory.
With this assert we'll fail with an assert(). This doesn't fix anything
but certainly makes mis-uses easier to detect and debug.

Triggered by https://bugzilla.redhat.com/show_bug.cgi?id=1609349

2 years agohashmap: add an environment variable to turn off the memory pool used by hashmaps
Lennart Poettering [Fri, 3 Aug 2018 14:45:21 +0000 (16:45 +0200)] 
hashmap: add an environment variable to turn off the memory pool used by hashmaps

Triggered by https://bugzilla.redhat.com/show_bug.cgi?id=1609349

2 years agoman: be more explicit about thread safety of sd_journal
Lennart Poettering [Fri, 3 Aug 2018 14:43:30 +0000 (16:43 +0200)] 
man: be more explicit about thread safety of sd_journal

Triggered by https://bugzilla.redhat.com/show_bug.cgi?id=1609349

This adds two generic paragaphs we include via xinclude. One is the
"strict" version, which contains wording saying that we are thread
agnostic and what that means. And the other is the "safe" version, for
the cases we provide fully safety.

Let's then change most man pages to use either of these generic
paragraphs. With one exception: man/sd_journal_get_catalog.xml contains
both kinds of function, we hence use manual wording.

2 years agoupdate TODO
Lennart Poettering [Fri, 3 Aug 2018 14:41:42 +0000 (16:41 +0200)] 
update TODO

2 years agoMerge pull request #9791 from poettering/user-runtime-dir-fixes
Zbigniew Jędrzejewski-Szmek [Fri, 3 Aug 2018 11:32:01 +0000 (13:32 +0200)] 
Merge pull request #9791 from poettering/user-runtime-dir-fixes

user-runtime-dir@.service fixes

2 years agoMerge pull request #9787 from yuwata/dns-over-tls-log
Lennart Poettering [Fri, 3 Aug 2018 11:11:18 +0000 (13:11 +0200)] 
Merge pull request #9787 from yuwata/dns-over-tls-log

DNS-over-TLS(openssl): fix error handling

2 years agounits: assign user-runtime-dir@.service to user-%i.slice 9791/head
Lennart Poettering [Fri, 3 Aug 2018 08:45:31 +0000 (10:45 +0200)] 
units: assign user-runtime-dir@.service to user-%i.slice

This service won't use much resources, but it's certainly nicer to see
it attached th the user's slice along with user@.service, so that
everything we run for a specific user is properly bound into one unit.

2 years agounits: order user-runtime-dir@.service after systemd-user-sessions.service
Lennart Poettering [Fri, 3 Aug 2018 08:42:09 +0000 (10:42 +0200)] 
units: order user-runtime-dir@.service after systemd-user-sessions.service

We use systemd-user-sessions.service as barrier when to allow login
sessions. With this patch user@.service is ordered after that too, so
that any login related code (which user-runtime-dir@.service is) is
guaranteed to run after the barrier, and never before.

2 years agounits: make sure user-runtime-dir@.service is Type=oneshot
Lennart Poettering [Thu, 2 Aug 2018 18:57:56 +0000 (20:57 +0200)] 
units: make sure user-runtime-dir@.service is Type=oneshot

We order user@.service after it, hence we need to properly know when it
finished starting up.

2 years agouser-runtime-dir: downgrade a few log messages to LOG_DEBUG that we ignore
Lennart Poettering [Thu, 2 Aug 2018 18:56:34 +0000 (20:56 +0200)] 
user-runtime-dir: downgrade a few log messages to LOG_DEBUG that we ignore

As the comments already say it might be quite likely that
$XDG_RUNTIME_DIR is not set up as mount, and we shouldn't complain about
that.

Moreover, let's make this idempotent, so that a runtime dir that is
already gone and is removed again doesn't cause failure.

2 years agoresolve: openssl: make dnstls_stream_{write,read}() may return zero 9787/head
Yu Watanabe [Thu, 2 Aug 2018 22:18:43 +0000 (07:18 +0900)] 
resolve: openssl: make dnstls_stream_{write,read}() may return zero

2 years agoresolve: fix error handling of SSL_shutdown()
Yu Watanabe [Thu, 2 Aug 2018 21:34:19 +0000 (06:34 +0900)] 
resolve: fix error handling of SSL_shutdown()

2 years agoresolve: fix typo and coding style cleanups
Yu Watanabe [Thu, 2 Aug 2018 21:29:38 +0000 (06:29 +0900)] 
resolve: fix typo and coding style cleanups

2 years agoresolve: clear error queue before calling SSL_*()
Yu Watanabe [Thu, 2 Aug 2018 21:26:58 +0000 (06:26 +0900)] 
resolve: clear error queue before calling SSL_*()

2 years agoman: document that 'nofail' also has an effect on ordering
Lennart Poettering [Thu, 2 Aug 2018 18:05:51 +0000 (20:05 +0200)] 
man: document that 'nofail' also has an effect on ordering

Prompted by #9765

2 years agoMerge pull request #9776 from keszybz/sd-bus-docs
Lennart Poettering [Thu, 2 Aug 2018 15:07:03 +0000 (17:07 +0200)] 
Merge pull request #9776 from keszybz/sd-bus-docs

More man pages for sd-bus and related changes

2 years agoresolve: fix error handling of dns_stream_read()
Yu Watanabe [Thu, 2 Aug 2018 13:38:22 +0000 (22:38 +0900)] 
resolve: fix error handling of dns_stream_read()

2 years agoMerge pull request #9764 from yuwata/hash_ops-cleanups
Zbigniew Jędrzejewski-Szmek [Thu, 2 Aug 2018 13:53:05 +0000 (15:53 +0200)] 
Merge pull request #9764 from yuwata/hash_ops-cleanups

Hash ops cleanups

2 years agoman: add sd_bus_message_rewind(3) 9776/head
Zbigniew Jędrzejewski-Szmek [Thu, 2 Aug 2018 08:38:51 +0000 (10:38 +0200)] 
man: add sd_bus_message_rewind(3)

2 years agoman: document sd_bus_slot_get_bus in sd_bus_slot_ref(3)
Zbigniew Jędrzejewski-Szmek [Wed, 1 Aug 2018 22:00:15 +0000 (00:00 +0200)] 
man: document sd_bus_slot_get_bus in sd_bus_slot_ref(3)

Similar reasoning as for sd_bus_message_get_bus().

2 years agoman: add sd_bus_slot_set_description(3)
Zbigniew Jędrzejewski-Szmek [Wed, 1 Aug 2018 21:56:36 +0000 (23:56 +0200)] 
man: add sd_bus_slot_set_description(3)

2 years agoman: add sd_bus_slot_set_userdata(3)
Zbigniew Jędrzejewski-Szmek [Wed, 1 Aug 2018 21:41:49 +0000 (23:41 +0200)] 
man: add sd_bus_slot_set_userdata(3)

2 years agoman: add sd_bus_message_set_expect_reply(3)
Zbigniew Jędrzejewski-Szmek [Wed, 1 Aug 2018 15:27:31 +0000 (17:27 +0200)] 
man: add sd_bus_message_set_expect_reply(3)

2 years agoman: document sd_bus_message_get_bus() in sd_bus_message_new(3)
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 15:47:17 +0000 (17:47 +0200)] 
man: document sd_bus_message_get_bus() in sd_bus_message_new(3)

It's not a particularly obvious place, but it's a trivial function that isn't
worth a man page of its own, and it doesn't fit anywhere else either.

2 years agoman: add sd_bus_message_verify_type(3)
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 14:33:02 +0000 (16:33 +0200)] 
man: add sd_bus_message_verify_type(3)

2 years agosd-bus: verify destination and sender values when setting
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 13:39:46 +0000 (15:39 +0200)] 
sd-bus: verify destination and sender values when setting

We would verify destination e.g. in sd_bus_message_new_call, but allow setting
any value later on with sd_bus_message_set_destination. I assume this check was
omitted not on purpose.

2 years agoman: add sd_bus_message_get_type(3)
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 12:58:41 +0000 (14:58 +0200)] 
man: add sd_bus_message_get_type(3)

sd_bus_message{get_type,is_signal,is_method_call,is_method_error} get one man
page.

sd_bus_message_{set,get}_{destination,path,interface,member,sender} are put in
the second one.

2 years agoman: add sd_bus_slot_ref(3)
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 12:15:50 +0000 (14:15 +0200)] 
man: add sd_bus_slot_ref(3)

2 years agoman: document sd_bus_message_new_method_return
Zbigniew Jędrzejewski-Szmek [Fri, 27 Jul 2018 12:07:02 +0000 (14:07 +0200)] 
man: document sd_bus_message_new_method_return